From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70550C07E99 for ; Fri, 9 Jul 2021 17:29:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 433ED613C3 for ; Fri, 9 Jul 2021 17:29:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229491AbhGIRbo (ORCPT ); Fri, 9 Jul 2021 13:31:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbhGIRbn (ORCPT ); Fri, 9 Jul 2021 13:31:43 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54976C0613E6 for ; Fri, 9 Jul 2021 10:29:00 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id 75-20020a9d08510000b02904acfe6bcccaso10166917oty.12 for ; Fri, 09 Jul 2021 10:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b9a9GBhzP0HS74EZRlotP1XS8wz3lqQjmU5aN6EE/kE=; b=E4UsDh022GB3OmPnBDg0m4K/M0tEXSypF6vo27XD4aikK9LiADWRtKSmLYbDG4IcgR Fuw/+2+xblg3NNEPNn8Tpa+zekiVCoLW1+cyAPOHy5A+OLeojAH0qloREwMobpnQvJe9 2CLR+2eT5TzomBVpBATvEhSQftNZy7KRp7yBNL5UNrpjff+uhsFYXDPPrMdBqZEzuNnf KPZ71UDdbNzWypPw/MT8WR6+Dn1bcf7oxMM+e0O+MjaE97VRnP/SWNwUJyCDpkydJnJ+ mQGi4c0UlMSbbsa8o191Papq895E6iVdBJXWQY7jB1id2Bnv+g3Ivqg+n4/ULNkRrP61 ec/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b9a9GBhzP0HS74EZRlotP1XS8wz3lqQjmU5aN6EE/kE=; b=d6E/kU+SCQ9CTmOWQ818susTYMGrGbT3q01pGw8AIj/xoFo8a7icEUA9e6Y9GZtf4G 9v0gRCR6bCTkWFI5SbQnmRZQSxNtOOh9N7Y3W41P/ikYt27gG2iC3Hsesv4QRHmcVpdT qFoNzLdVDtImtAF7jL4l3jOisg4Yp2QPjD7r3XycqEkb3nLTaXR8Rj58HbS6lwoVE7Bm 27kXgPCgnY7/qwe1+RH8lXc6wf3JP9O7ykbOlyK8hLXoadh2eP2cRYRj9QDcd8EfRfRM QU4h5E36J1PqP4LpFuW/6Q7gZFwdccjcYr4+aTrZBGWB773TPEbrZKrOdJm3ORoX6doJ 0WuA== X-Gm-Message-State: AOAM531lk6TjdURH8dsC84Qjezx+SZYQMCy4OqerRTzeZfmAi+KLKx9f xL5yR7BIUOA81WJmNZW1xKV/fA== X-Google-Smtp-Source: ABdhPJws3+LFB9fqp9c8PbCxZzqrqQkBucb639UmIJ5lfjz8ths67oa2giidnlVG4/5SygUyEZEglg== X-Received: by 2002:a9d:5f07:: with SMTP id f7mr29767852oti.183.1625851739481; Fri, 09 Jul 2021 10:28:59 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id t10sm1111541oor.48.2021.07.09.10.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 10:28:58 -0700 (PDT) Date: Fri, 9 Jul 2021 10:27:32 -0700 From: Bjorn Andersson To: Rob Herring Cc: Andy Gross , Sibi S , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: soc: qcom: aoss: Convert to YAML Message-ID: References: <20210625234018.1324681-1-bjorn.andersson@linaro.org> <20210625234018.1324681-3-bjorn.andersson@linaro.org> <20210701190313.GA2736150@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210701190313.GA2736150@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu 01 Jul 12:03 PDT 2021, Rob Herring wrote: > On Fri, Jun 25, 2021 at 04:40:17PM -0700, Bjorn Andersson wrote: > > Convert to YAML in order to allow validation. > > > > Signed-off-by: Bjorn Andersson > > --- > > > > I'm aware that this conflicts with Sibi's removal of '#power-domain-cells', but > > that's a trivial change regardless of which of the two patches gets in first. > > > > .../bindings/soc/qcom/qcom,aoss-qmp.txt | 90 -------------- > > .../bindings/soc/qcom/qcom,aoss-qmp.yaml | 115 ++++++++++++++++++ > > 2 files changed, 115 insertions(+), 90 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt > > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt > > deleted file mode 100644 > > index 3747032311a4..000000000000 > > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt > > +++ /dev/null > > @@ -1,90 +0,0 @@ > > -Qualcomm Always-On Subsystem side channel binding > > - > > -This binding describes the hardware component responsible for side channel > > -requests to the always-on subsystem (AOSS), used for certain power management > > -requests that is not handled by the standard RPMh interface. Each client in the > > -SoC has it's own block of message RAM and IRQ for communication with the AOSS. > > -The protocol used to communicate in the message RAM is known as Qualcomm > > -Messaging Protocol (QMP) > > - > > -The AOSS side channel exposes control over a set of resources, used to control > > -a set of debug related clocks and to affect the low power state of resources > > -related to the secondary subsystems. These resources are exposed as a set of > > -power-domains. > > - > > -- compatible: > > - Usage: required > > - Value type: > > - Definition: must be one of: > > - "qcom,sc7180-aoss-qmp" > > - "qcom,sc7280-aoss-qmp" > > - "qcom,sc8180x-aoss-qmp" > > - "qcom,sdm845-aoss-qmp" > > - "qcom,sm8150-aoss-qmp" > > - "qcom,sm8250-aoss-qmp" > > - "qcom,sm8350-aoss-qmp" > > - and: > > - "qcom,aoss-qmp" > > - > > -- reg: > > - Usage: required > > - Value type: > > - Definition: the base address and size of the message RAM for this > > - client's communication with the AOSS > > - > > -- interrupts: > > - Usage: required > > - Value type: > > - Definition: should specify the AOSS message IRQ for this client > > - > > -- mboxes: > > - Usage: required > > - Value type: > > - Definition: reference to the mailbox representing the outgoing doorbell > > - in APCS for this client, as described in mailbox/mailbox.txt > > - > > -- #clock-cells: > > - Usage: optional > > - Value type: > > - Definition: must be 0 > > - The single clock represents the QDSS clock. > > - > > -- #power-domain-cells: > > - Usage: optional > > - Value type: > > - Definition: must be 1 > > - The provided power-domains are: > > - CDSP state (0), LPASS state (1), modem state (2), SLPI > > - state (3), SPSS state (4) and Venus state (5). > > - > > -= SUBNODES > > -The AOSS side channel also provides the controls for three cooling devices, > > -these are expressed as subnodes of the QMP node. The name of the node is used > > -to identify the resource and must therefor be "cx", "mx" or "ebi". > > - > > -- #cooling-cells: > > - Usage: optional > > - Value type: > > - Definition: must be 2 > > - > > -= EXAMPLE > > - > > -The following example represents the AOSS side-channel message RAM and the > > -mechanism exposing the power-domains, as found in SDM845. > > - > > - aoss_qmp: qmp@c300000 { > > - compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp"; > > - reg = <0x0c300000 0x100000>; > > - interrupts = ; > > - mboxes = <&apss_shared 0>; > > - > > - #power-domain-cells = <1>; > > - > > - cx_cdev: cx { > > - #cooling-cells = <2>; > > - }; > > - > > - mx_cdev: mx { > > - #cooling-cells = <2>; > > - }; > > - }; > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml > > new file mode 100644 > > index 000000000000..1b9de8e49356 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml > > @@ -0,0 +1,115 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/qcom/qcom,aoss-qmp.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm Always-On Subsystem side channel binding > > + > > +maintainers: > > + - Bjorn Andersson > > + > > +description: > > + This binding describes the hardware component responsible for side channel > > + requests to the always-on subsystem (AOSS), used for certain power management > > + requests that is not handled by the standard RPMh interface. Each client in the > > + SoC has it's own block of message RAM and IRQ for communication with the AOSS. > > + The protocol used to communicate in the message RAM is known as Qualcomm > > + Messaging Protocol (QMP) > > + > > + The AOSS side channel exposes control over a set of resources, used to control > > + a set of debug related clocks and to affect the low power state of resources > > + related to the secondary subsystems. These resources are exposed as a set of > > + power-domains. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - "qcom,sc7180-aoss-qmp" > > + - "qcom,sc7280-aoss-qmp" > > + - "qcom,sc8180x-aoss-qmp" > > + - "qcom,sdm845-aoss-qmp" > > + - "qcom,sm8150-aoss-qmp" > > + - "qcom,sm8250-aoss-qmp" > > + - "qcom,sm8350-aoss-qmp" > > + - const: "qcom,aoss-qmp" > > Don't need quotes. With that and the indentation fixed: > I've installed yamllint and fixed this for v2. But can you please help me understand why the members of the enum should have double indentation here? Is it just that the indentation counts from the 'e' and not the '-'? > Reviewed-by: Rob Herring Thanks, Bjorn