From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: quic_vamslank@quicinc.com
Cc: agross@kernel.org, robh+dt@kernel.org, linus.walleij@linaro.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, manivannan.sadhasivam@linaro.org
Subject: Re: [PATCH 1/1] ARM: dts: qcom: sdx65: Add pincontrol node
Date: Fri, 9 Jul 2021 22:12:42 -0500 [thread overview]
Message-ID: <YOkQKkUMO3cvR4yz@yoga> (raw)
In-Reply-To: <20210709200819.20373-2-quic_vamslank@quicinc.com>
On Fri 09 Jul 15:08 CDT 2021, quic_vamslank@quicinc.com wrote:
> From: Vamsi krishna Lanka <quic_vamslank@quicinc.com>
>
> This commit adds pincontrol node to SDX65 dts.
>
> Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> ---
> arch/arm/boot/dts/qcom-sdx65.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
> index 4b5e7248c34d..155635d1de2f 100644
> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
> @@ -96,6 +96,17 @@ blsp1_uart3: serial@831000 {
> status = "disabled";
> };
>
> + tlmm: pinctrl@f100000 {
> + compatible = "qcom,sdx65-pinctrl";
> + reg = <0xf100000 0x300000>;
> + interrupts = <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + interrupt-parent = <&intc>;
> + #interrupt-cells = <2>;
You're missing gpio-ranges.
Please squash this with the other dts patch.
Thanks,
Bjorn
> + };
> +
> pdc: interrupt-controller@b210000 {
> compatible = "qcom,sdx65-pdc", "qcom,pdc";
> reg = <0xb210000 0x10000>;
> --
> 2.32.0
>
prev parent reply other threads:[~2021-07-10 3:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 20:08 [PATCH 0/1] Devicetree update for SDX65 platform quic_vamslank
2021-07-09 20:08 ` [PATCH 1/1] ARM: dts: qcom: sdx65: Add pincontrol node quic_vamslank
2021-07-10 3:12 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOkQKkUMO3cvR4yz@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_vamslank@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).