Re: [PATCH 2/2] ARM: dts: qcom: Add SDX65 platform and MTP board support

Bjorn Andersson
2021-07-10T03:11:44Z

On Fri 09 Jul 15:05 CDT 2021, quic_vamslank@quicinc.com wrote:

> From: Vamsi krishna Lanka <quic_vamslank@quicinc.com>
>
> Add basic devicetree support for SDX65 platform and MTP board from
> Qualcomm. The SDX65 platform features an ARM Cortex A7 CPU which forms
> the Application Processor Sub System (APSS) along with standard Qualcomm
> peripherals like GCC, TLMM, BLSP, QPIC, and BAM etc... Also, there
> exists the networking parts such as IPA, MHI, PCIE-EP, EMAC, and Modem
> etc..
>
> This commit adds basic devicetree support that includes GCC, RPMh clock, INTC
> and Debug UART.
>
> Signed-off-by: Vamsi Krishna Lanka <quic_vamslank@quicinc.com>
> ---
> arch/arm/boot/dts/Makefile | 3 +-
> arch/arm/boot/dts/qcom-sdx65-mtp.dts | 25 ++++
> arch/arm/boot/dts/qcom-sdx65.dtsi | 215 +++++++++++++++++++++++++++
> 3 files changed, 242 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/qcom-sdx65-mtp.dts
> create mode 100644 arch/arm/boot/dts/qcom-sdx65.dtsi
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 8e5d4ab4e75e..1e3f01496cb3 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -929,7 +929,8 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-msm8974-sony-xperia-castor.dtb \
> qcom-msm8974-sony-xperia-honami.dtb \
> qcom-mdm9615-wp8548-mangoh-green.dtb \
> - qcom-sdx55-mtp.dtb
> + qcom-sdx55-mtp.dtb \
> + qcom-sdx65-mtp.dtb
> dtb-$(CONFIG_ARCH_RDA) += \
> rda8810pl-orangepi-2g-iot.dtb \
> rda8810pl-orangepi-i96.dtb
> diff --git a/arch/arm/boot/dts/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> new file mode 100644
> index 000000000000..59457da8e5f1
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-sdx65-mtp.dts
> @@ -0,0 +1,25 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +/dts-v1/;
> +
> +#include "qcom-sdx65.dtsi"
> +
> +/ {
> + model = "Qualcomm Technologies, Inc. SDX65 MTP";
> + compatible = "qcom,sdx65-mtp", "qcom,sdx65";
> + qcom,board-id = <0x2010008 0x302>;
> +
> + aliases {
> + serial0 = &blsp1_uart3;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +};
> +
> +&blsp1_uart3 {
> + status = "ok";
> +};
> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
> new file mode 100644
> index 000000000000..4b5e7248c34d
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
> @@ -0,0 +1,215 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * SDX65 SoC device tree source
> + *
> + * Copyright (c) 2021 Qualcomm Innovation Center, Inc. All rights reserved.
> + *
> + */
> +
> +#include <dt-bindings/clock/qcom,gcc-sdx65.h>
> +#include <dt-bindings/clock/qcom,rpmh.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/soc/qcom,rpmh-rsc.h>
> +
> +/ {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + qcom,msm-id = <458 0x10000>, <483 0x10000>, <509 0x10000>;
> + interrupt-parent = <&intc>;
> +
> + memory {
> + device_type = "memory";
> + reg = <0 0>;
> + };
> +
> + clocks {
> + xo_board: xo-board {
> + compatible = "fixed-clock";
> + clock-frequency = <76800000>;
> + clock-output-names = "xo_board";
> + #clock-cells = <0>;
> + };
> +
> + sleep_clk: sleep-clk {
> + compatible = "fixed-clock";
> + clock-frequency = <32764>;
> + clock-output-names = "sleep_clk";
> + #clock-cells = <0>;
> + };
> +
> + pcie_pipe_clk: pcie-0-pipe-clk {

Rather than defining a dummy node to have something to provide in &gcc
you can leave this as just 0 in the clocks property in &gcc until you
introduce the PHY.

> + compatible = "fixed-clock";
> + clock-frequency = <1000>;
> + clock-output-names = "pcie_pipe_clk";
> + #clock-cells = <0>;
> + };
> +
> + usb3_phy_wrapper_gcc_usb30_pipe_clk: usb3-phy-wrapper-gcc-usb30-pipe-clk {

Ditto.

> + compatible = "fixed-clock";
> + clock-frequency = <1000>;
> + clock-output-names = "usb3_phy_wrapper_gcc_usb30_pipe_clk";
> + #clock-cells = <0>;
> + };
> + };
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu0: cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a7";
> + reg = <0x0>;
> + enable-method = "psci";
> + };
> + };
> +
> + psci {
> + compatible = "arm,psci-1.0";
> + method = "smc";
> + };
> +
> + soc: soc {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + compatible = "simple-bus";
> +
> + gcc: clock-controller@100000 {
> + compatible = "qcom,gcc-sdx65";
> + reg = <0x100000 0x1f7400>;

Please pad the address to 8 digits, sto make it easier for me to keep
these sorted by address as we move forward.

> + reg-name = "cc_base";

We typically don't use a name for the single memory region for &gcc. I
haven't looked at your gcc patch yet, but I think you should drop this.

Regards,
Bjorn

> + clocks = <&rpmhcc RPMH_CXO_CLK>, <&rpmhcc RPMH_CXO_CLK_A>, <&sleep_clk>,
> + <&pcie_pipe_clk>, <&usb3_phy_wrapper_gcc_usb30_pipe_clk>;
> + clock-names = "bi_tcxo", "bi_tcxo_ao", "sleep_clk",
> + "pcie_pipe_clk", "usb3_phy_wrapper_gcc_usb30_pipe_clk";
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + };
> +
> + blsp1_uart3: serial@831000 {
> + compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm";
> + reg = <0x00831000 0x200>;
> + interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc GCC_BLSP1_UART3_APPS_CLK>, <&gcc GCC_BLSP1_AHB_CLK>;
> + clock-names = "core", "iface";
> + status = "disabled";
> + };
> +
> + pdc: interrupt-controller@b210000 {
> + compatible = "qcom,sdx65-pdc", "qcom,pdc";
> + reg = <0xb210000 0x10000>;
> + qcom,pdc-ranges = <0 147 52>, <52 266 32>;
> + #interrupt-cells = <2>;
> + interrupt-parent = <&intc>;
> + interrupt-controller;
> + };
> +
> + intc: interrupt-controller@17800000 {
> + compatible = "qcom,msm-qgic2";
> + interrupt-controller;
> + interrupt-parent = <&intc>;
> + #interrupt-cells = <3>;
> + reg = <0x17800000 0x1000>,
> + <0x17802000 0x1000>;
> + };
> +
> + timer@17820000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + compatible = "arm,armv7-timer-mem";
> + reg = <0x17820000 0x1000>;
> + clock-frequency = <19200000>;
> +
> + frame@17821000 {
> + frame-number = <0>;
> + interrupts = <GIC_SPI 7 0x4>,
> + <GIC_SPI 6 0x4>;
> + reg = <0x17821000 0x1000>,
> + <0x17822000 0x1000>;
> + };
> +
> + frame@17823000 {
> + frame-number = <1>;
> + interrupts = <GIC_SPI 8 0x4>;
> + reg = <0x17823000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@17824000 {
> + frame-number = <2>;
> + interrupts = <GIC_SPI 9 0x4>;
> + reg = <0x17824000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@17825000 {
> + frame-number = <3>;
> + interrupts = <GIC_SPI 10 0x4>;
> + reg = <0x17825000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@17826000 {
> + frame-number = <4>;
> + interrupts = <GIC_SPI 11 0x4>;
> + reg = <0x17826000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@17827000 {
> + frame-number = <5>;
> + interrupts = <GIC_SPI 12 0x4>;
> + reg = <0x17827000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@17828000 {
> + frame-number = <6>;
> + interrupts = <GIC_SPI 13 0x4>;
> + reg = <0x17828000 0x1000>;
> + status = "disabled";
> + };
> +
> + frame@17829000 {
> + frame-number = <7>;
> + interrupts = <GIC_SPI 14 0x4>;
> + reg = <0x17829000 0x1000>;
> + status = "disabled";
> + };
> + };
> +
> + apps_rsc: rsc@17830000 {
> + label = "apps_rsc";
> + compatible = "qcom,rpmh-rsc";
> + reg = <0x17830000 0x10000>,
> + <0x17840000 0x10000>;
> + reg-names = "drv-0", "drv-1";
> + interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> + qcom,tcs-offset = <0xd00>;
> + qcom,drv-id = <1>;
> + qcom,tcs-config = <ACTIVE_TCS 2>,
> + <SLEEP_TCS 2>,
> + <WAKE_TCS 2>,
> + <CONTROL_TCS 1>;
> +
> + rpmhcc: clock-controller@1 {
> + compatible = "qcom,sdx65-rpmh-clk";
> + #clock-cells = <1>;
> + clock-names = "xo";
> + clocks = <&xo_board>;
> + };
> + };
> + };
> +
> + timer {
> + compatible = "arm,armv7-timer";
> + interrupts = <1 13 0xf08>,
> + <1 12 0xf08>,
> + <1 10 0xf08>,
> + <1 11 0xf08>;
> + clock-frequency = <19200000>;
> + };
> +};
> --
> 2.32.0
>