From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37C25C07E9C for ; Sat, 10 Jul 2021 05:17:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FD40613E5 for ; Sat, 10 Jul 2021 05:17:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231164AbhGJFUY (ORCPT ); Sat, 10 Jul 2021 01:20:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230165AbhGJFUW (ORCPT ); Sat, 10 Jul 2021 01:20:22 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAA8CC0613DD for ; Fri, 9 Jul 2021 22:17:36 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id l26so15116746oic.7 for ; Fri, 09 Jul 2021 22:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=l/AK4cFCkpdPaQEuLimUoJPLn9urUKT/MvatgQ4k6nU=; b=LF/9QPAObWQEXCY2LF9mWC8sAkwGKgi707gou9lTdt917sxoibuzpo50glpkjUlLJI GN554BrmXIRUsUjDXnaA1q5R5zoWG2JxzVWnZ2JiHgiy7j9dPAqPnyzlJB/Z/hinLoth 22/HdfBzslj97LfZQ7XC0rLBPdh6Bc2b6AmNllLl80BprpmWT9G4lL/jh7xymW4IdWXB JFwFrGWScAfknv3DLJPc/7XdSh8M3jha+iZdIVxl3of34A3N/LTejw5qU1pueIJSfZ26 EgDu2jBDVaY2mc2OhoINlCOnLmYqMEeEigpbSvycKvne5OlN2eArtlN8xSjco0GMqRCG Wy0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=l/AK4cFCkpdPaQEuLimUoJPLn9urUKT/MvatgQ4k6nU=; b=o22qHBKQm1jzemt4ByFYsA0IJ/ruurrCat1VUIhfpFHSMSN0few2Wh6mPOdbEN2IDB 4A0Q9NPIVai2mwm3JSPWps8Np4D+5ltnOvnZd90sWa3puadVBSuZJrqyKD82mBhXApaO 4U5ZbhfgUQP/aWnBIQXGhwT1x5iepCbdWPXKFe9LgWIh78Rep2ba1GVhX1hhZN4inDkS ApLD6YBtBQeMh5J5r4Y7exmUXDwax9cLmUcE7QO1x4SBisEUDvqqDqLF2EaJZ3YaPuAe uoSsrSbqe1eaYm/VoD2L3RqP7Pt/p0pqrCI4ddvj1OVixdgduupqsqHG9vQa2MwHeO4x 0Gjw== X-Gm-Message-State: AOAM533DTmQeQYaw0XpwGudofh8UYu5nyhx/ncnMkjdhFswJjgHZUh0K umEYpF7vnHgR3NSqYyc8ZVlzUQ== X-Google-Smtp-Source: ABdhPJxDfXQp7GsJDicje9t4N5mfGorO2kNMjHZcqhSpTKOrTERHm7C9BNYQZB29Hl0vcrMnZJUD8Q== X-Received: by 2002:a05:6808:68f:: with SMTP id k15mr1895527oig.58.1625894256291; Fri, 09 Jul 2021 22:17:36 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id c25sm1639247otn.47.2021.07.09.22.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 22:17:35 -0700 (PDT) Date: Sat, 10 Jul 2021 00:17:33 -0500 From: Bjorn Andersson To: Shawn Guo Cc: Stephen Boyd , Rob Herring , Sivaprakash Murugesan , Benjamin Li , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 2/4] clk: qcom: a53pll/mux: Use unique clock name Message-ID: References: <20210704024032.11559-1-shawn.guo@linaro.org> <20210704024032.11559-3-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210704024032.11559-3-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat 03 Jul 21:40 CDT 2021, Shawn Guo wrote: > Different from MSM8916 which has only one a53pll/mux clock, MSM8939 gets > three for Cluster0 (little cores), Cluster1 (big cores) and CCI (Cache > Coherent Interconnect). That said, a53pll/mux clock needs to be named > uniquely. Append @unit-address of device node to the clock name, so > that a53pll/mux will be named like below on MSM8939. > > a53pll@b016000 > a53pll@b116000 > a53pll@b1d0000 > > a53mux@b1d1000 > a53mux@b011000 > a53mux@b111000 > > Signed-off-by: Shawn Guo > --- > drivers/clk/qcom/a53-pll.c | 8 +++++++- > drivers/clk/qcom/apcs-msm8916.c | 8 +++++++- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/qcom/a53-pll.c b/drivers/clk/qcom/a53-pll.c > index d6756bd777ce..96a118be912d 100644 > --- a/drivers/clk/qcom/a53-pll.c > +++ b/drivers/clk/qcom/a53-pll.c > @@ -37,6 +37,7 @@ static const struct regmap_config a53pll_regmap_config = { > static int qcom_a53pll_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > struct regmap *regmap; > struct resource *res; > struct clk_pll *pll; > @@ -66,7 +67,12 @@ static int qcom_a53pll_probe(struct platform_device *pdev) > pll->status_bit = 16; > pll->freq_tbl = a53pll_freq; > > - init.name = "a53pll"; > + /* Use an unique name by appending @unit-address */ > + init.name = devm_kasprintf(dev, GFP_KERNEL, "a53pll%s", > + strchrnul(np->full_name, '@')); While the result is nice, this isn't... Is your dev_name() reasonable? What about "%s:a53pll", dev_name(dev) ? Regards, Bjorn > + if (!init.name) > + return -ENOMEM; > + > init.parent_names = (const char *[]){ "xo" }; > init.num_parents = 1; > init.ops = &clk_pll_sr2_ops; > diff --git a/drivers/clk/qcom/apcs-msm8916.c b/drivers/clk/qcom/apcs-msm8916.c > index d7ac6d6b15b6..89e0730810ac 100644 > --- a/drivers/clk/qcom/apcs-msm8916.c > +++ b/drivers/clk/qcom/apcs-msm8916.c > @@ -46,6 +46,7 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct device *parent = dev->parent; > + struct device_node *np = parent->of_node; > struct clk_regmap_mux_div *a53cc; > struct regmap *regmap; > struct clk_init_data init = { }; > @@ -61,7 +62,12 @@ static int qcom_apcs_msm8916_clk_probe(struct platform_device *pdev) > if (!a53cc) > return -ENOMEM; > > - init.name = "a53mux"; > + /* Use an unique name by appending parent's @unit-address */ > + init.name = devm_kasprintf(dev, GFP_KERNEL, "a53mux%s", > + strchrnul(np->full_name, '@')); > + if (!init.name) > + return -ENOMEM; > + > init.parent_data = pdata; > init.num_parents = ARRAY_SIZE(pdata); > init.ops = &clk_regmap_mux_div_ops; > -- > 2.17.1 >