From: Andrew Lunn <andrew@lunn.ch>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
michal.simek@xilinx.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 4/5] tsnep: Add TSN endpoint Ethernet MAC driver
Date: Mon, 26 Jul 2021 23:29:23 +0200 [thread overview]
Message-ID: <YP8pM+qD/AfuSCcU@lunn.ch> (raw)
In-Reply-To: <20210726194603.14671-5-gerhard@engleder-embedded.com>
> This driver provides a driver specific interface in tsnep_stream.c for
> direct access to all but the first TX/RX queue pair. There are two
> reasons for this interface. First: It enables the reservation or direct use
> of TX/RX queue pairs by real-time application on dedicated CPU cores or
> in user space.
Hi Gerhard
I expect you will get a lot of push back with a character device in
the middle of an Ethernet driver. One that mmap the Tx/Rx queue is
going to need a lot of review to make sure it is secure. Maybe talk to
the XDP/AF_XDP people, there might be a way to do it through that?
So i strongly suggest your drop tsnep_stream.c for the moment. Get the
basic plain boring Ethernet driver merged. Then start a discussion
about a suitable API for exporting rings to user space.
Andrew
next prev parent reply other threads:[~2021-07-26 21:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 19:45 [PATCH net-next 0/5] TSN endpoint Ethernet MAC driver Gerhard Engleder
2021-07-26 19:45 ` [PATCH net-next 1/5] dt-bindings: Add vendor prefix for Engleder Gerhard Engleder
2021-07-26 19:46 ` [PATCH net-next 2/5] dt-bindings: net: Add tsnep Ethernet controller Gerhard Engleder
2021-07-26 23:35 ` Rob Herring
2021-07-27 18:34 ` Gerhard Engleder
2021-07-27 20:25 ` Rob Herring
2021-07-27 20:33 ` Gerhard Engleder
2021-07-28 5:13 ` Michal Simek
2021-07-28 7:44 ` Gerhard Engleder
2021-07-28 10:55 ` Michal Simek
2021-07-28 20:14 ` Gerhard Engleder
2021-07-29 5:07 ` Michal Simek
2021-07-29 7:07 ` Gerhard Engleder
2021-07-29 7:57 ` Michal Simek
2021-07-26 19:46 ` [PATCH net-next 3/5] dt-bindings: arm: Add Engleder bindings Gerhard Engleder
2021-07-26 19:46 ` [PATCH net-next 4/5] tsnep: Add TSN endpoint Ethernet MAC driver Gerhard Engleder
2021-07-26 20:49 ` Andrew Lunn
2021-07-27 20:18 ` Gerhard Engleder
2021-07-26 21:15 ` Andrew Lunn
2021-07-27 20:49 ` Gerhard Engleder
2021-07-26 21:29 ` Andrew Lunn [this message]
2021-07-27 22:05 ` Gerhard Engleder
2021-07-27 22:41 ` Andrew Lunn
2021-07-28 8:24 ` Gerhard Engleder
2021-07-26 23:25 ` kernel test robot
2021-07-26 19:46 ` [PATCH net-next 5/5] arm64: dts: zynqmp: Add ZCU104 based TSN endpoint Gerhard Engleder
2021-07-26 23:40 ` Rob Herring
2021-07-27 20:10 ` Gerhard Engleder
2021-07-27 20:17 ` Rob Herring
2021-07-27 20:23 ` Gerhard Engleder
2021-07-28 5:10 ` Michal Simek
2021-07-28 8:19 ` Gerhard Engleder
2021-07-28 10:58 ` Michal Simek
2021-07-28 20:51 ` Gerhard Engleder
2021-07-29 5:22 ` Michal Simek
2021-07-29 6:47 ` Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP8pM+qD/AfuSCcU@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gerhard@engleder-embedded.com \
--cc=kuba@kernel.org \
--cc=michal.simek@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).