Re: [PATCH net-next 1/3] dt-bindings: net: qcom,ipa: make imem interconnect optional

Rob Herring
2021-07-23T20:52:59Z

On Mon, Jul 19, 2021 at 04:24:54PM -0500, Alex Elder wrote:
> On some newer SoCs, the interconnect between IPA and SoC internal
> memory (imem) is not used. Reflect this in the binding by moving
> the definition of the "imem" interconnect to the end and defining
> minItems to be 2 for both the interconnects and interconnect-names
> properties.
>
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
> .../devicetree/bindings/net/qcom,ipa.yaml | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index ed88ba4b94df5..4853ab7017bd9 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -87,16 +87,18 @@ properties:
> - const: ipa-setup-ready
>
> interconnects:
> + minItems: 2
> items:
> - - description: Interconnect path between IPA and main memory
> - - description: Interconnect path between IPA and internal memory
> - - description: Interconnect path between IPA and the AP subsystem
> + - description: Path leading to system memory
> + - description: Path between the AP and IPA config space
> + - description: Path leading to internal memory
>
> interconnect-names:
> + minItems: 2
> items:
> - const: memory
> - - const: imem
> - const: config
> + - const: imem

What about existing users? This will generate warnings. Doing this for
the 2nd item would avoid the need for .dts updates:

- enum: [ imem, config ]

Rob