From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10CE5C43214 for ; Fri, 30 Jul 2021 18:25:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E44B560BD3 for ; Fri, 30 Jul 2021 18:25:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230451AbhG3SZI (ORCPT ); Fri, 30 Jul 2021 14:25:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230407AbhG3SZH (ORCPT ); Fri, 30 Jul 2021 14:25:07 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E696C0613CF for ; Fri, 30 Jul 2021 11:25:02 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id i39-20020a9d17270000b02904cf73f54f4bso245522ota.2 for ; Fri, 30 Jul 2021 11:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XpB+LNmPBgnS5Lf6x+b5cG5d1sMq85HwbCnNpZE2zYo=; b=FLU28j8+ohjlgupR219GFzrIl9IH9/YzqxQJSUxHtE5VtGLhrgsFSje8to6mUj/aga x8nInA/4b1SZwqh/E285vMfeKvkbUkoZiHeV5oxS8JUVQLxRozEbb1HUzzi845CHrDBt bH1RLWLP2fGKQKmFMPdNozclJavXJ1RtQ9W1Ruat6YfxfmKna0mnbxpgJnpnz+MApimw JFI1/pM187pK04w61eo5JjNf2ZlDqDzDfs7YLwOWOmHFCAK24b6vFe2/nSOx/nPPc7fP IASY8hUWbtG53IMu3z7y0g2dS8huQ1EQq2BfmjIjTt84iWoT2Jk2MUoYLWoy37YbYT79 fwaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XpB+LNmPBgnS5Lf6x+b5cG5d1sMq85HwbCnNpZE2zYo=; b=XHu8WGE3Za3/jxkLRSh9qN0Wx28UFmUyn8TyNhqkTuolSMXG01oAcsyW8MA4ilgsJo vNivsb9maSzVlLCi1Kv5+LPmXhHfQj6mNU/b9Qnie93wdOws0IMzeKEgrfba/ecE7v+7 uvP2QkMZQBjP1cTKwPqWLCDmWfdWJtWfavyt1OaVk98AjvH9t2kX9dbHPGH8/Ip2xmHj HTYBlpPouU+gDkQiWpj1Jz+gPS+unvXd8TNb6BDbts4y2NGrD7F9uIZtfx7+aK03+EHb 9CALawzICECCv5QPHJT+EFQ/eNuggvG40GLpXl6YV/TK+n15LpQsWtCWxK6TfRjaO8pB D5pg== X-Gm-Message-State: AOAM532lh5BSXj44cshPWR0zG/oDFTFokAIrDMk8DM+rcciBesLTLIN1 Zx/NIXG/vxUoxxLR919P4jvYRg== X-Google-Smtp-Source: ABdhPJx4vNZHT6X7wQKRFb2JUuvmKANycbmxpNeZfUiQDWntbLArDTfaRDIDFIss/nuk9dA3LyoMKw== X-Received: by 2002:a05:6830:25c6:: with SMTP id d6mr3126063otu.226.1627669501571; Fri, 30 Jul 2021 11:25:01 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id i10sm357103ood.48.2021.07.30.11.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 11:25:01 -0700 (PDT) Date: Fri, 30 Jul 2021 13:24:58 -0500 From: Bjorn Andersson To: Sibi Sankar Cc: Matthias Kaehlcke , robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org, swboyd@chromium.org Subject: Re: [PATCH 6/9] arm64: dts: qcom: sc7280: Update reserved memory map Message-ID: References: <1624564058-24095-1-git-send-email-sibis@codeaurora.org> <1624564058-24095-7-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed 30 Jun 15:02 CDT 2021, Sibi Sankar wrote: > On 2021-06-28 23:41, Matthias Kaehlcke wrote: > > On Fri, Jun 25, 2021 at 01:17:35AM +0530, Sibi Sankar wrote: > > > > > Subject: arm64: dts: qcom: sc7280: Update reserved memory map > > > > That's very vague. Also personally I'm not a fan of patches that touch > > SoC and board files with a commit message that only mentions the SoC, as > > is frequently done for IDP boards. Why not split this in (at least) two, > > one for adding the missing memory regions to the SoC, and one for the > > IDP. > > > > sure will split this up. > > > > Add missing regions and remove unused regions from the reserved memory > > > map, as described in version 1. > > > > What is this 'version 1'? > > lol, it's the memory map version number > and it's not entirely internal to qc so > we have been mentioning them in commit > messages from older SoCs. I'll just drop > it when I re-spin the series since it > doesn't add much value. > Every now and then we run into issues with the reserved-memory layout, where knowing were the numbers comes from is useful information to have in order to characterize the issue and come up with a fix. So including information about where those numbers came from is useful, even if it's referencing a version of a document that's not public. Regards, Bjorn