From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 550E2C4338F for ; Wed, 4 Aug 2021 10:28:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36CB661004 for ; Wed, 4 Aug 2021 10:28:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237283AbhHDK24 (ORCPT ); Wed, 4 Aug 2021 06:28:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237263AbhHDK24 (ORCPT ); Wed, 4 Aug 2021 06:28:56 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEABDC0613D5 for ; Wed, 4 Aug 2021 03:28:43 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id k4so893131wms.3 for ; Wed, 04 Aug 2021 03:28:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=pibRPync781Rey72XckhyktXKaHhuUD/jjwvrwByLTU=; b=AEqHZY4Ua0OTOVBBOyyctVU3kaNOKXvJEV44OSQquvmFrUofuT2FpdlBiK08kbucTc Ovrxx3a7PVozVuKm15Wk0qmCd68nfsRgd8ucTo4ww+skdi3BjnMneI5tXFgleCS6b4Jw cIml3EmLHJHkyZIXemSIIGIB4PNaMdnuR4R14QIqFAznVnkeG11d4VWoIaR2sS6OrAUF VmL+7pcM0bDjkM2+VKG2gkhKrFu1W460axDVG0BWexKJhWRXxrBpGpJ7NfFVWhbEa1cU 8eIMpC8W1LDjHcFZJyiyY5nGCfc3I3uGGFjn8/WraEGhNB0UbybhT/23vO3wk0agUw27 bTRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=pibRPync781Rey72XckhyktXKaHhuUD/jjwvrwByLTU=; b=RIVbRjkQoCvrjSWgpewQcysZKpC25QsgvhUtFrTlBZiuMNA3KlRzSewp3SSpGpHivz cAg+Ifqf+FLy8OEvCQVTo+Nag14wFyEikChqgjY4JI7LHEYzIx+nWyniDsj9HBov+I1j m4uaThGOhAT9alwJ3MNkYX4bnJ+8AtfRVTLAGZqdRCeGC60qPtQiJ5FTGC4hCSBaWQMy 0Wx/aDpl2dQJo4RF5y/A5pUu7YwoCfx13gOGSxGq/RpXjeczfNLwBLoj0isFXpVXGyPL eQ0PY8zlCPGsb1fA3CZnVq95ufSBsEYyLSyu0n/MQC6PrNTwBt7TQ17wj8Rek438LVHU qUZA== X-Gm-Message-State: AOAM530m+CewX/Z88SH2Jx8m/nNFeDG9JdERqRz3wf2NQRC9BwY5vkq1 0En1q5Dcx6kpoUengJiy5tcTBQ== X-Google-Smtp-Source: ABdhPJyLL5+IQyQOwrQ3rdoeJ3/iG50sinQci9T23YfmDnbK/M6bQLaxlT/KON9NUBIJ1Yl5G07Ezw== X-Received: by 2002:a7b:cf12:: with SMTP id l18mr9004049wmg.130.1628072922530; Wed, 04 Aug 2021 03:28:42 -0700 (PDT) Received: from google.com ([109.180.115.228]) by smtp.gmail.com with ESMTPSA id q14sm1930131wrs.8.2021.08.04.03.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 03:28:41 -0700 (PDT) Date: Wed, 4 Aug 2021 11:28:39 +0100 From: Lee Jones To: Alistair Francis Cc: Alistair Francis , Rob Herring , lgirdwood@gmail.com, Mark Brown , dl-linux-imx , Sascha Hauer , devicetree , Linux Kernel Mailing List Subject: Re: [PATCH v8 02/11] mfd: sy7636a: Initial commit Message-ID: References: <20210803084456.198-1-alistair@alistair23.me> <20210803084456.198-2-alistair@alistair23.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 04 Aug 2021, Alistair Francis wrote: > On Wed, Aug 4, 2021 at 7:06 PM Lee Jones wrote: > > > > On Wed, 04 Aug 2021, Alistair Francis wrote: > > > > > On Tue, Aug 3, 2021 at 11:16 PM Lee Jones wrote: > > > > > > > > On Tue, 03 Aug 2021, Alistair Francis wrote: > > > > > > > > > Initial support for the Silergy SY7636A Power Management chip. > > > > > > > > > > Signed-off-by: Alistair Francis > > > > > --- > > > > > drivers/mfd/Kconfig | 9 +++++ > > > > > drivers/mfd/Makefile | 1 + > > > > > drivers/mfd/sy7636a.c | 72 +++++++++++++++++++++++++++++++++++++ > > > > > include/linux/mfd/sy7636a.h | 45 +++++++++++++++++++++++ > > > > > 4 files changed, 127 insertions(+) > > > > > create mode 100644 drivers/mfd/sy7636a.c > > > > > create mode 100644 include/linux/mfd/sy7636a.h > > > > > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > > > index 6a3fd2d75f96..b82208f0c79c 100644 > > > > > --- a/drivers/mfd/Kconfig > > > > > +++ b/drivers/mfd/Kconfig > > > > > @@ -1352,6 +1352,15 @@ config MFD_SYSCON > > > > > Select this option to enable accessing system control registers > > > > > via regmap. > > > > > > > > > > +config MFD_SY7636A > > > > > + tristate "Silergy SY7636A Power Management IC" > > > > > + select MFD_CORE > > > > > + select REGMAP_I2C > > > > > + depends on I2C > > > > > + help > > > > > + Select this option to enable support for the Silergy SY7636A > > > > > + Power Management IC. > > > > > + > > > > > config MFD_DAVINCI_VOICECODEC > > > > > tristate > > > > > select MFD_CORE > > > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > > > > index 8116c19d5fd4..cbe581e87fa9 100644 > > > > > --- a/drivers/mfd/Makefile > > > > > +++ b/drivers/mfd/Makefile > > > > > @@ -266,6 +266,7 @@ obj-$(CONFIG_MFD_KHADAS_MCU) += khadas-mcu.o > > > > > obj-$(CONFIG_MFD_ACER_A500_EC) += acer-ec-a500.o > > > > > obj-$(CONFIG_MFD_QCOM_PM8008) += qcom-pm8008.o > > > > > > > > > > +obj-$(CONFIG_MFD_SY7636A) += sy7636a.o > > > > > obj-$(CONFIG_SGI_MFD_IOC3) += ioc3.o > > > > > obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) += simple-mfd-i2c.o > > > > > obj-$(CONFIG_MFD_INTEL_M10_BMC) += intel-m10-bmc.o > > > > > diff --git a/drivers/mfd/sy7636a.c b/drivers/mfd/sy7636a.c > > > > > new file mode 100644 > > > > > index 000000000000..f3ff93c7395d > > > > > --- /dev/null > > > > > +++ b/drivers/mfd/sy7636a.c > > > > > @@ -0,0 +1,72 @@ > > > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > > +/* > > > > > + * MFD parent driver for SY7636A chip > > > > > + * > > > > > + * Copyright (C) 2021 reMarkable AS - http://www.remarkable.com/ > > > > > + * > > > > > + * Authors: Lars Ivar Miljeteig > > > > > + * Alistair Francis > > > > > + * > > > > > + * Based on the lp87565 driver by Keerthy > > > > > + */ > > > > > + > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > + > > > > > +#include > > > > > + > > > > > +static const struct regmap_config sy7636a_regmap_config = { > > > > > + .reg_bits = 8, > > > > > + .val_bits = 8, > > > > > +}; > > > > > + > > > > > +static const struct mfd_cell sy7636a_cells[] = { > > > > > + { .name = "sy7636a-regulator", }, > > > > > > > > What kind of regulator is 'vcom'? LDO? DCDC? > > > > > > Both I guess: > > > > > > "SY7636A is a single-chip power management IC (PMIC) designed for > > > electronic paper display (EPD) applications. The device supports panel > > > sizes up to 9.7 inches and larger. The device integrates two > > > high-efficiency DC-DC boost converters, which are boosted to 25V and > > > -20V by two charge pumps to provide gate driver power for the panel. > > > Two tracking LDOs create a ±15V source driver power supply that > > > supports output currents up to 200mA. SY7636A also provides I2C > > > interface control for specific panel requirements" > > > > Is there a datasheet I could look at? > > I have managed to find this: > > https://www.silergy.com/cn/productsview/SY7636ARMC > > which is in Chinese. The datasheet is behind a login page unfortunately. Where did the snippet above come from then? What documentation are you working to? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog