* [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters
[not found] <20210806102930.3024-1-biju.das.jz@bp.renesas.com>
@ 2021-08-06 10:29 ` Biju Das
2021-08-09 12:57 ` Geert Uytterhoeven
2021-08-13 20:13 ` Rob Herring
0 siblings, 2 replies; 6+ messages in thread
From: Biju Das @ 2021-08-06 10:29 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Liam Girdwood, Mark Brown, Vinod Koul, Chris Brandt,
Kuninori Morimoto, alsa-devel, devicetree, Geert Uytterhoeven,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad,
linux-renesas-soc
The DMAC driver on RZ/G2L expects the slave channel configuration
to be passed in dmas property.
This patch updates the example node to include the encoded slave
channel configuration.
Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Note:-
This patch is based on [1]
[1]:- https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210806095322.2326-2-biju.das.jz@bp.renesas.com/
v3->v4:
* Updated bindings as the DMAC driver on RZ/G2L expects the
slave channel configuration to be passed in dmas property.
v2->v3:
* Merged the binding patch with dmas added
* Updated dt binding example with encoded #dma-cells value.
v1->v2:
* Rebased on 5.14-rc2.
---
Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
index 471937cb8d05..9923e7b8264f 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
+++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
@@ -93,8 +93,8 @@ examples:
clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2";
power-domains = <&cpg>;
resets = <&cpg R9A07G044_SSI0_RST_M2_REG>;
- dmas = <&dmac 0x255>,
- <&dmac 0x256>;
+ dmas = <&dmac 0x2655>,
+ <&dmac 0x2656>;
dma-names = "tx", "rx";
#sound-dai-cells = <0>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters
2021-08-06 10:29 ` [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters Biju Das
@ 2021-08-09 12:57 ` Geert Uytterhoeven
2021-08-12 7:19 ` Biju Das
2021-08-13 20:12 ` Rob Herring
2021-08-13 20:13 ` Rob Herring
1 sibling, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-08-09 12:57 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Liam Girdwood, Mark Brown, Vinod Koul, Chris Brandt,
Kuninori Morimoto, ALSA Development Mailing List,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, Linux-Renesas
Hi Biju,
On Fri, Aug 6, 2021 at 12:29 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> The DMAC driver on RZ/G2L expects the slave channel configuration
> to be passed in dmas property.
> This patch updates the example node to include the encoded slave
> channel configuration.
>
> Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> v3->v4:
> * Updated bindings as the DMAC driver on RZ/G2L expects the
> slave channel configuration to be passed in dmas property.
Thanks for the update!
> --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> @@ -93,8 +93,8 @@ examples:
> clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2";
> power-domains = <&cpg>;
> resets = <&cpg R9A07G044_SSI0_RST_M2_REG>;
> - dmas = <&dmac 0x255>,
> - <&dmac 0x256>;
> + dmas = <&dmac 0x2655>,
> + <&dmac 0x2656>;
> dma-names = "tx", "rx";
> #sound-dai-cells = <0>;
> };
I think it would be good to describe the expected format in the description
for the dmas property, so the DTS writer knows what the numerical
values in the example really mean.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters
2021-08-09 12:57 ` Geert Uytterhoeven
@ 2021-08-12 7:19 ` Biju Das
2021-08-13 20:12 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Biju Das @ 2021-08-12 7:19 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, Liam Girdwood, Mark Brown, Vinod Koul, Chris Brandt,
Kuninori Morimoto, ALSA Development Mailing List,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, Linux-Renesas
Hi Geert,
Thanks for the update.
> Subject: Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi:
> Update slave dma channel configuration parameters
>
> Hi Biju,
>
> On Fri, Aug 6, 2021 at 12:29 PM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > The DMAC driver on RZ/G2L expects the slave channel configuration to
> > be passed in dmas property.
> > This patch updates the example node to include the encoded slave
> > channel configuration.
> >
> > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi:
> > Document DMA support")
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> > v3->v4:
> > * Updated bindings as the DMAC driver on RZ/G2L expects the
> > slave channel configuration to be passed in dmas property.
>
> Thanks for the update!
>
> > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> > @@ -93,8 +93,8 @@ examples:
> > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2";
> > power-domains = <&cpg>;
> > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>;
> > - dmas = <&dmac 0x255>,
> > - <&dmac 0x256>;
> > + dmas = <&dmac 0x2655>,
> > + <&dmac 0x2656>;
> > dma-names = "tx", "rx";
> > #sound-dai-cells = <0>;
> > };
>
> I think it would be good to describe the expected format in the
> description for the dmas property, so the DTS writer knows what the
> numerical values in the example really mean.
Agree, will add description for dmas property.
Regards,
Biju
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters
2021-08-09 12:57 ` Geert Uytterhoeven
2021-08-12 7:19 ` Biju Das
@ 2021-08-13 20:12 ` Rob Herring
2021-08-14 9:11 ` Geert Uytterhoeven
1 sibling, 1 reply; 6+ messages in thread
From: Rob Herring @ 2021-08-13 20:12 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Biju Das, Liam Girdwood, Mark Brown, Vinod Koul, Chris Brandt,
Kuninori Morimoto, ALSA Development Mailing List,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, Linux-Renesas
On Mon, Aug 09, 2021 at 02:57:33PM +0200, Geert Uytterhoeven wrote:
> Hi Biju,
>
> On Fri, Aug 6, 2021 at 12:29 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > The DMAC driver on RZ/G2L expects the slave channel configuration
> > to be passed in dmas property.
> > This patch updates the example node to include the encoded slave
> > channel configuration.
> >
> > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support")
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> > v3->v4:
> > * Updated bindings as the DMAC driver on RZ/G2L expects the
> > slave channel configuration to be passed in dmas property.
>
> Thanks for the update!
>
> > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> > @@ -93,8 +93,8 @@ examples:
> > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2";
> > power-domains = <&cpg>;
> > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>;
> > - dmas = <&dmac 0x255>,
> > - <&dmac 0x256>;
> > + dmas = <&dmac 0x2655>,
> > + <&dmac 0x2656>;
> > dma-names = "tx", "rx";
> > #sound-dai-cells = <0>;
> > };
>
> I think it would be good to describe the expected format in the description
> for the dmas property, so the DTS writer knows what the numerical
> values in the example really mean.
Yes, but that's a property of the DMA controller binding, not this one.
It could vary from chip to chip.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters
2021-08-06 10:29 ` [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters Biju Das
2021-08-09 12:57 ` Geert Uytterhoeven
@ 2021-08-13 20:13 ` Rob Herring
1 sibling, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-08-13 20:13 UTC (permalink / raw)
To: Biju Das
Cc: Geert Uytterhoeven, Rob Herring, Biju Das, alsa-devel,
Liam Girdwood, linux-renesas-soc, Prabhakar Mahadev Lad,
devicetree, Kuninori Morimoto, Chris Paterson, Vinod Koul,
Mark Brown, Chris Brandt
On Fri, 06 Aug 2021 11:29:29 +0100, Biju Das wrote:
> The DMAC driver on RZ/G2L expects the slave channel configuration
> to be passed in dmas property.
> This patch updates the example node to include the encoded slave
> channel configuration.
>
> Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support")
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> Note:-
> This patch is based on [1]
> [1]:- https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210806095322.2326-2-biju.das.jz@bp.renesas.com/
>
> v3->v4:
> * Updated bindings as the DMAC driver on RZ/G2L expects the
> slave channel configuration to be passed in dmas property.
> v2->v3:
> * Merged the binding patch with dmas added
> * Updated dt binding example with encoded #dma-cells value.
> v1->v2:
> * Rebased on 5.14-rc2.
> ---
> Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters
2021-08-13 20:12 ` Rob Herring
@ 2021-08-14 9:11 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2021-08-14 9:11 UTC (permalink / raw)
To: Rob Herring
Cc: Biju Das, Liam Girdwood, Mark Brown, Vinod Koul, Chris Brandt,
Kuninori Morimoto, ALSA Development Mailing List,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Geert Uytterhoeven, Chris Paterson, Biju Das,
Prabhakar Mahadev Lad, Linux-Renesas
Hi Rob,
On Fri, Aug 13, 2021 at 10:12 PM Rob Herring <robh@kernel.org> wrote:
> On Mon, Aug 09, 2021 at 02:57:33PM +0200, Geert Uytterhoeven wrote:
> > On Fri, Aug 6, 2021 at 12:29 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > > The DMAC driver on RZ/G2L expects the slave channel configuration
> > > to be passed in dmas property.
> > > This patch updates the example node to include the encoded slave
> > > channel configuration.
> > >
> > > Fixes: 5df6dfbb6de815ba3a("ASoC: dt-bindings: sound: renesas,rz-ssi: Document DMA support")
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > > v3->v4:
> > > * Updated bindings as the DMAC driver on RZ/G2L expects the
> > > slave channel configuration to be passed in dmas property.
> >
> > Thanks for the update!
> >
> > > --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> > > +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml
> > > @@ -93,8 +93,8 @@ examples:
> > > clock-names = "ssi", "ssi_sfr", "audio_clk1", "audio_clk2";
> > > power-domains = <&cpg>;
> > > resets = <&cpg R9A07G044_SSI0_RST_M2_REG>;
> > > - dmas = <&dmac 0x255>,
> > > - <&dmac 0x256>;
> > > + dmas = <&dmac 0x2655>,
> > > + <&dmac 0x2656>;
> > > dma-names = "tx", "rx";
> > > #sound-dai-cells = <0>;
> > > };
> >
> > I think it would be good to describe the expected format in the description
> > for the dmas property, so the DTS writer knows what the numerical
> > values in the example really mean.
>
> Yes, but that's a property of the DMA controller binding, not this one.
> It could vary from chip to chip.
Right, unlike the other Renesas SoCs, RZ/G2L uses the normal DMAC for
audio, not an audio-specific one.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-14 9:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210806102930.3024-1-biju.das.jz@bp.renesas.com>
2021-08-06 10:29 ` [PATCH v4 2/3] ASoC: dt-bindings: sound: renesas,rz-ssi: Update slave dma channel configuration parameters Biju Das
2021-08-09 12:57 ` Geert Uytterhoeven
2021-08-12 7:19 ` Biju Das
2021-08-13 20:12 ` Rob Herring
2021-08-14 9:11 ` Geert Uytterhoeven
2021-08-13 20:13 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).