From: Rob Herring <robh@kernel.org>
To: chaochao2021666@163.com
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Chao Zeng <chao.zeng@siemens.com>
Subject: Re: [PATCH 1/2] dt-bindings:dp83867:Add binding for the status led
Date: Tue, 17 Aug 2021 13:48:09 -0500 [thread overview]
Message-ID: <YRwEacEuiAuPzA0E@robh.at.kernel.org> (raw)
In-Reply-To: <20210809085213.324129-1-chaochao2021666@163.com>
On Mon, Aug 09, 2021 at 04:52:13PM +0800, chaochao2021666@163.com wrote:
> From: Chao Zeng <chao.zeng@siemens.com>
>
> The phy status led of each of board maybe different.
> Provide a method to custom phy status led behavior.
>
> Datasheet:
> http://www.ti.com/product/DP83867IR/datasheet
>
> Signed-off-by: Chao Zeng <chao.zeng@siemens.com>
> ---
> .../devicetree/bindings/net/ti,dp83867.yaml | 6 ++++++
> include/dt-bindings/net/ti-dp83867.h | 18 ++++++++++++++++++
> 2 files changed, 24 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> index 047d757e8d82..a46a437818f2 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> @@ -106,6 +106,12 @@ properties:
> Transmitt FIFO depth- see dt-bindings/net/ti-dp83867.h for applicable
> values.
>
> + ti,led-sel:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + This configure the status led. See dt-bindings/net/ti-dp83867.h
> + for different status led settings,select different configures
There's ongoing discussions about using the LED bindings/subsystem for
this type of LED.
Rob
prev parent reply other threads:[~2021-08-17 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 8:52 [PATCH 1/2] dt-bindings:dp83867:Add binding for the status led chaochao2021666
2021-08-17 18:48 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRwEacEuiAuPzA0E@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=chao.zeng@siemens.com \
--cc=chaochao2021666@163.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).