From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F16F0C4320A for ; Tue, 17 Aug 2021 21:20:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEDD16102A for ; Tue, 17 Aug 2021 21:20:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232481AbhHQVUp (ORCPT ); Tue, 17 Aug 2021 17:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230515AbhHQVUp (ORCPT ); Tue, 17 Aug 2021 17:20:45 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 749F2C061764; Tue, 17 Aug 2021 14:20:11 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E21A62C5; Tue, 17 Aug 2021 23:20:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1629235210; bh=h5ACte+IYkCtcopGlqXw02CqacNi0HiPaCVWx3i1Baw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wg+D7Whx7l0hPHEu5uotr47+W1S//1wOLYXYTpLJy53s5o1Cm8wiOl209zN7Nnpe3 PrpEjpP+mhcS7wrOeL+aCYIhgb5Tm0BoQ/YtFyb1US3D7kqk0zhQ9+V84rStnvEcfJ o39SwTKp+bWLPwScnsFOD5Bv+Q9zmbBI17Ktt7PQ= Date: Wed, 18 Aug 2021 00:20:02 +0300 From: Laurent Pinchart To: Wolfram Sang Cc: Jonathan Cameron , linux-iio@vger.kernel.org, Lars-Peter Clausen , Rob Herring , Sean Nyekjaer , devicetree@vger.kernel.org, Jose Cazarin , linux-i2c@vger.kernel.org Subject: Re: [PATCH v1.1 2/2] iio: dac: dac5571: Fix chip id detection for OF devices Message-ID: References: <20210723183114.26017-3-laurent.pinchart@ideasonboard.com> <20210724000654.23168-1-laurent.pinchart@ideasonboard.com> <20210724154308.55afb03c@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Aug 17, 2021 at 10:58:19PM +0200, Wolfram Sang wrote: > > > > Couldn't you use the "new" probe_new() callback instead which will drop > > > the i2c_device_id? Kieran was interested in such conversions IIRC. > > > > It's a bit unrelated to this patch, but I can add another patch to the > > series. > > > > While I have your attention, there's a question for you in the cover > > letter :-) Could you please have a look ? > > ? This was the answer to that question. Unless I misunderstood. My point is that this patch shouldn't be needed. I'd like if the I2C core could get the driver data from the i2c_device_id table instead of duplicating it in the of_device_id. This isn't possible today as i2c_match_id() doesn't have the fallback mechanism that OF matching has. -- Regards, Laurent Pinchart