* [PATCH] arm: dts: qcom-msm8974: Add xo_board reference clock to DSI0 PHY
@ 2021-08-30 17:57 Marijn Suijten
2021-08-30 21:28 ` Bjorn Andersson
0 siblings, 1 reply; 3+ messages in thread
From: Marijn Suijten @ 2021-08-30 17:57 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, AngeloGioacchino Del Regno,
Konrad Dybcio, Martin Botka, Jami Kettunen, Pavel Dubrova,
Marijn Suijten, Andy Gross, Bjorn Andersson, Rob Herring,
Brian Masney, Linus Walleij, linux-arm-msm, devicetree,
linux-kernel
According to YAML validation, and for a future patchset putting this
xo_board reference clock to use as VCO reference parent, add the missing
clock to dsi_phy0.
Fixes: 5a9fc531f6ec ("ARM: dts: msm8974: add display support")
Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
---
arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
index db4c06bf7888..96722172b064 100644
--- a/arch/arm/boot/dts/qcom-msm8974.dtsi
+++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
@@ -1580,8 +1580,8 @@ dsi_phy0: dsi-phy@fd922a00 {
#phy-cells = <0>;
qcom,dsi-phy-index = <0>;
- clocks = <&mmcc MDSS_AHB_CLK>;
- clock-names = "iface";
+ clocks = <&mmcc MDSS_AHB_CLK>, <&xo_board>;
+ clock-names = "iface", "ref";
};
};
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm: dts: qcom-msm8974: Add xo_board reference clock to DSI0 PHY
2021-08-30 17:57 [PATCH] arm: dts: qcom-msm8974: Add xo_board reference clock to DSI0 PHY Marijn Suijten
@ 2021-08-30 21:28 ` Bjorn Andersson
2021-08-30 22:15 ` Marijn Suijten
0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Andersson @ 2021-08-30 21:28 UTC (permalink / raw)
To: Marijn Suijten
Cc: phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno, Konrad Dybcio, Martin Botka,
Jami Kettunen, Pavel Dubrova, Andy Gross, Rob Herring,
Brian Masney, Linus Walleij, linux-arm-msm, devicetree,
linux-kernel
On Mon 30 Aug 12:57 CDT 2021, Marijn Suijten wrote:
> According to YAML validation, and for a future patchset putting this
> xo_board reference clock to use as VCO reference parent, add the missing
> clock to dsi_phy0.
>
And just to confirm on MSM8974 "ref" is supposed to be 19.2Mhz?
Regards,
Bjorn
> Fixes: 5a9fc531f6ec ("ARM: dts: msm8974: add display support")
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
> arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index db4c06bf7888..96722172b064 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1580,8 +1580,8 @@ dsi_phy0: dsi-phy@fd922a00 {
> #phy-cells = <0>;
> qcom,dsi-phy-index = <0>;
>
> - clocks = <&mmcc MDSS_AHB_CLK>;
> - clock-names = "iface";
> + clocks = <&mmcc MDSS_AHB_CLK>, <&xo_board>;
> + clock-names = "iface", "ref";
> };
> };
>
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm: dts: qcom-msm8974: Add xo_board reference clock to DSI0 PHY
2021-08-30 21:28 ` Bjorn Andersson
@ 2021-08-30 22:15 ` Marijn Suijten
0 siblings, 0 replies; 3+ messages in thread
From: Marijn Suijten @ 2021-08-30 22:15 UTC (permalink / raw)
To: Bjorn Andersson
Cc: phone-devel, ~postmarketos/upstreaming,
AngeloGioacchino Del Regno, Konrad Dybcio, Martin Botka,
Jami Kettunen, Pavel Dubrova, Andy Gross, Rob Herring,
Brian Masney, Linus Walleij, linux-arm-msm, devicetree,
linux-kernel
On 2021-08-30 16:28:15, Bjorn Andersson wrote:
> On Mon 30 Aug 12:57 CDT 2021, Marijn Suijten wrote:
>
> > According to YAML validation, and for a future patchset putting this
> > xo_board reference clock to use as VCO reference parent, add the missing
> > clock to dsi_phy0.
> >
>
> And just to confirm on MSM8974 "ref" is supposed to be 19.2Mhz?
Yes, the 28nm-hpm driver (unlike the 28nm-8960 driver for apq8064) uses
19.2MHz for its hardcoded VCO_REF_CLK_RATE calculations.
Perhaps we should reword the commit message to read "... add the missing
19.2MHz xo clock ...".
- Marijn
> Regards,
> Bjorn
>
> > Fixes: 5a9fc531f6ec ("ARM: dts: msm8974: add display support")
> > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> > ---
> > arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> > index db4c06bf7888..96722172b064 100644
> > --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> > +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> > @@ -1580,8 +1580,8 @@ dsi_phy0: dsi-phy@fd922a00 {
> > #phy-cells = <0>;
> > qcom,dsi-phy-index = <0>;
> >
> > - clocks = <&mmcc MDSS_AHB_CLK>;
> > - clock-names = "iface";
> > + clocks = <&mmcc MDSS_AHB_CLK>, <&xo_board>;
> > + clock-names = "iface", "ref";
> > };
> > };
> >
> > --
> > 2.33.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-30 22:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-30 17:57 [PATCH] arm: dts: qcom-msm8974: Add xo_board reference clock to DSI0 PHY Marijn Suijten
2021-08-30 21:28 ` Bjorn Andersson
2021-08-30 22:15 ` Marijn Suijten
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox