From: Rob Herring <robh@kernel.org>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
ath9k-devel@qca.qualcomm.com
Subject: Re: [RFC PATCH v1 1/3] dt-bindings:net:wireless:qca,ath9k: add nvmem-cells for calibration data
Date: Tue, 24 Aug 2021 11:51:02 -0500 [thread overview]
Message-ID: <YSUjdsS3ggmTo8c4@robh.at.kernel.org> (raw)
In-Reply-To: <cf25eb4a-197d-161a-5902-64830c383746@gmail.com>
On Sat, Aug 21, 2021 at 10:02:57PM +0200, Christian Lamparter wrote:
> On 21/08/2021 07:40, Kalle Valo wrote:
> > Christian Lamparter <chunkeey@gmail.com> writes:
> >
> > > On most embedded ath9k devices (like range extenders,
> > > routers, accesspoints, ...) the calibration data for
> > > the RF/PHY is simply stored in a MTD partition named
> > > "ART", "caldata"/"calibration", etc.
> > >
> > > Any mtd partition is automatically registered in the
> > > nvmem subsystem. This makes is possible to fetch the
> > > necessary calibration directly from there at the low
> > > cost of adding nvmem cell information via the
> > > device-tree or via similar means.
> > >
> > > This speeds up the driver's initialization a lot,
> > > because the driver doesn't have to wait for userspace
> > > to provide the data via helpers.
> > >
> > > Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
> >
> > The series looks good to me. But I'm curious, why you marked this as
> > RFC? Is there something controversial I missed?
>
> yeah. Last night (it was already really late) I was tunnel-visioning
> at the thought that device-tree binding update was a must there.
> ... And ath9k's qca,ath9k.txt is still in that .txt and not .yaml
> format. So, I'm not sure if that file has to be converted first.
That would be nice, but it still falls under my bar for must convert
first. :)
> (I couldn't get Rob's tools to work. And without them, I've no idea
> what error messages a converted .yaml of it will pop up)
What issue were you having?
Rob
next prev parent reply other threads:[~2021-08-24 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 1:09 [RFC PATCH v1 1/3] dt-bindings:net:wireless:qca,ath9k: add nvmem-cells for calibration data Christian Lamparter
2021-08-21 1:09 ` [RFC PATCH v1 2/3] ath9k: fetch calibration data via nvmem subsystem Christian Lamparter
2021-08-21 1:09 ` [RFC PATCH v1 3/3] ath9k: owl-loader: fetch pci init values through nvmem Christian Lamparter
2021-08-21 5:40 ` [RFC PATCH v1 1/3] dt-bindings:net:wireless:qca,ath9k: add nvmem-cells for calibration data Kalle Valo
2021-08-21 20:02 ` Christian Lamparter
2021-08-22 5:09 ` Kalle Valo
2021-08-24 16:51 ` Rob Herring [this message]
2021-08-24 16:51 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSUjdsS3ggmTo8c4@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=chunkeey@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).