From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
kernel test robot <lkp@intel.com>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH] of: fdt: Rename reserve_elfcorehdr() to fdt_reserve_elfcorehdr()
Date: Wed, 25 Aug 2021 11:05:56 -0500 [thread overview]
Message-ID: <YSZqZFdNbzwk4ZXH@robh.at.kernel.org> (raw)
In-Reply-To: <f6eabbbce0fba6da3da0264c1e1cf23c01173999.1629884393.git.geert+renesas@glider.be>
On Wed, 25 Aug 2021 11:40:40 +0200, Geert Uytterhoeven wrote:
> On ia64/allmodconfig:
>
> drivers/of/fdt.c:609:20: error: conflicting types for 'reserve_elfcorehdr'; have 'void(void)'
> 609 | static void __init reserve_elfcorehdr(void)
> | ^~~~~~~~~~~~~~~~~~
> arch/ia64/include/asm/meminit.h:43:12: note: previous declaration of 'reserve_elfcorehdr' with type 'int(u64 *, u64 *)' {aka 'int(long long unsigned int *, long long unsigned int *)'}
> 43 | extern int reserve_elfcorehdr(u64 *start, u64 *end);
> | ^~~~~~~~~~~~~~~~~~
>
> Fix this by prefixing the FDT function name with "fdt_".
>
> Fixes: f7e7ce93aac13118 ("of: fdt: Add generic support for handling elf core headers property")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This change was planned for v6.
> Feel free to fold into the original.
> ---
> drivers/of/fdt.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Applied, thanks!
prev parent reply other threads:[~2021-08-25 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 9:40 [PATCH] of: fdt: Rename reserve_elfcorehdr() to fdt_reserve_elfcorehdr() Geert Uytterhoeven
2021-08-25 12:20 ` Rob Herring
2021-08-25 12:44 ` Geert Uytterhoeven
2021-08-25 12:49 ` Rob Herring
2021-08-25 16:05 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSZqZFdNbzwk4ZXH@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=lkp@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).