From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97FFFC433F5 for ; Sun, 19 Sep 2021 12:02:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 821AA60F43 for ; Sun, 19 Sep 2021 12:02:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234594AbhISMDj (ORCPT ); Sun, 19 Sep 2021 08:03:39 -0400 Received: from rosenzweig.io ([138.197.143.207]:46618 "EHLO rosenzweig.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235729AbhISMDe (ORCPT ); Sun, 19 Sep 2021 08:03:34 -0400 Date: Sun, 19 Sep 2021 07:47:28 -0400 From: Alyssa Rosenzweig To: Sven Peter Cc: Jassi Brar , Rob Herring , Mark Kettenis , Hector Martin , Mohamed Mediouni , Stan Skowronek , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] Apple Mailbox Controller support Message-ID: References: <20210916154911.3168-1-sven@svenpeter.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916154911.3168-1-sven@svenpeter.dev> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org I've dropped v1 from my tree and cherry-picked "mailbox: apple: Add driver for Apple mailboxes". NVMe and DCP both still work, so this is Tested-by: Alyssa Rosenzweig Thanks! On Thu , Sep 16, 2021 at 05:49:09PM +0200, Sven Peter wrote: > Hi, > > This is the second version of my series which adds support for the mailbox > controllers found on the Apple M1. > > v1: https://lore.kernel.org/lkml/20210907145501.69161-1-sven@svenpeter.dev/ > > Thanks to Jassi, Mark and Alyssa for the initial review. I've addressed > your comments with the following changes: > > - switched to txdone_irq instead of introducing a new mode > - switched to a threaded interrupt handler for receiving messages > - added co-processor examples to the device tree binding > - reformatted the register defines and clarified multiple comments > > Best, > > Sven > > Sven Peter (2): > dt-bindings: mailbox: Add Apple mailbox bindings > mailbox: apple: Add driver for Apple mailboxes > > .../bindings/mailbox/apple,mailbox.yaml | 84 ++++ > MAINTAINERS | 3 + > drivers/mailbox/Kconfig | 12 + > drivers/mailbox/Makefile | 2 + > drivers/mailbox/apple-mailbox.c | 431 ++++++++++++++++++ > include/linux/apple-mailbox.h | 18 + > 6 files changed, 550 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml > create mode 100644 drivers/mailbox/apple-mailbox.c > create mode 100644 include/linux/apple-mailbox.h > > -- > 2.25.1 >