From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <devicetree-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 57D75C4332F
	for <linux-devicetree@archiver.kernel.org>; Sun, 19 Sep 2021 12:02:18 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 4214C61353
	for <linux-devicetree@archiver.kernel.org>; Sun, 19 Sep 2021 12:02:18 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S237969AbhISMDm (ORCPT
        <rfc822;linux-devicetree@archiver.kernel.org>);
        Sun, 19 Sep 2021 08:03:42 -0400
Received: from rosenzweig.io ([138.197.143.207]:46640 "EHLO rosenzweig.io"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S231921AbhISMDf (ORCPT <rfc822;devicetree@vger.kernel.org>);
        Sun, 19 Sep 2021 08:03:35 -0400
Date:   Sun, 19 Sep 2021 07:51:17 -0400
From:   Alyssa Rosenzweig <alyssa@rosenzweig.io>
To:     Sven Peter <sven@svenpeter.dev>
Cc:     Jassi Brar <jassisinghbrar@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Kettenis <mark.kettenis@xs4all.nl>,
        Hector Martin <marcan@marcan.st>,
        Mohamed Mediouni <mohamed.mediouni@caramail.com>,
        Stan Skowronek <stan@corellium.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] mailbox: apple: Add driver for Apple mailboxes
Message-ID: <YUckNbQwfD4X2PA7@sunset>
References: <20210916154911.3168-1-sven@svenpeter.dev>
 <20210916154911.3168-3-sven@svenpeter.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210916154911.3168-3-sven@svenpeter.dev>
Precedence: bulk
List-ID: <devicetree.vger.kernel.org>
X-Mailing-List: devicetree@vger.kernel.org

> +#define APPLE_ASC_MBOX_CONTROL_FULL  BIT(16)
> +#define APPLE_ASC_MBOX_CONTROL_EMPTY BIT(17)
...
> +#define APPLE_M3_MBOX_CONTROL_FULL  BIT(16)
> +#define APPLE_M3_MBOX_CONTROL_EMPTY BIT(17)

It might make sense to combine these to just

> +#define APPLE_MBOX_CONTROL_FULL  BIT(16)
> +#define APPLE_MBOX_CONTROL_EMPTY BIT(17)

..unless we have a reason to think the status bits otherwise differ.

Regardless of that minor nit, this is

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>