From: Rob Herring <robh@kernel.org>
To: Abel Vesa <abel.vesa@nxp.com>
Cc: Jacky Bai <ping.bai@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 1/9] dt-bindings: clock: Add imx8ulp clock support
Date: Mon, 20 Sep 2021 16:44:43 -0500 [thread overview]
Message-ID: <YUkAyw1pGE8EOKd1@robh.at.kernel.org> (raw)
In-Reply-To: <YUDAJ18URdZRGIup@ryzen>
On Tue, Sep 14, 2021 at 06:30:47PM +0300, Abel Vesa wrote:
> On 21-09-14 16:11:13, Jacky Bai wrote:
> > > Subject: Re: [PATCH v3 1/9] dt-bindings: clock: Add imx8ulp clock support
> > >
> > > On 21-09-14 14:52:00, Jacky Bai wrote:
> > > > Add the clock dt-binding file for i.MX8ULP.
> > > >
> > > > For pcc node, it will also be used as a reset controller, so add the
> > > > '#reset-cells' property description and add the pcc reset IDs.
> > > >
> > > > Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> > > > ---
> > > > v3 changes:
> > > > - split into two binding file, one for pcc, one for cgc
> > > >
> > > > v2 changes:
> > > > - removed the redundant clocks & clock-names property
> > > >
> > > > v1 changes:
> > > > - Move this patch from dts patchset into this patchset
> > > > ---
> > > > .../bindings/clock/imx8ulp-cgc-clock.yaml | 43 +++
> > > > .../bindings/clock/imx8ulp-pcc-clock.yaml | 50 ++++
> > > > include/dt-bindings/clock/imx8ulp-clock.h | 258
> > > ++++++++++++++++++
> > > > include/dt-bindings/reset/imx8ulp-pcc-reset.h | 59 ++++
> > > > 4 files changed, 410 insertions(+)
> > > > create mode 100644
> > > > Documentation/devicetree/bindings/clock/imx8ulp-cgc-clock.yaml
> > > > create mode 100644
> > > > Documentation/devicetree/bindings/clock/imx8ulp-pcc-clock.yaml
> > > > create mode 100644 include/dt-bindings/clock/imx8ulp-clock.h
> > > > create mode 100644 include/dt-bindings/reset/imx8ulp-pcc-reset.h
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/clock/imx8ulp-cgc-clock.yaml
> > > > b/Documentation/devicetree/bindings/clock/imx8ulp-cgc-clock.yaml
> > >
> > > I'm not sure but I think the Documentation part is usually done in a separate
> > > patch.
> > >
> >
> > The clk-imx8ulp.c file highly depends on the clock/reset index in this dt-binding patch.
> >
>
> Yeah, I get that, but I was suggesting splitting the Documentation part
> and the binding header part into two separate patches. It's up to you.
The header is part of the binding ABI, so it belongs in this patch.
Rob
next prev parent reply other threads:[~2021-09-20 21:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 6:51 [PATCH v3 0/9] Add imx8ulp clock & reset driver support Jacky Bai
2021-09-14 6:52 ` [PATCH v3 1/9] dt-bindings: clock: Add imx8ulp clock support Jacky Bai
2021-09-14 11:25 ` Abel Vesa
2021-09-14 13:11 ` Jacky Bai
2021-09-14 15:30 ` Abel Vesa
2021-09-20 21:44 ` Rob Herring [this message]
2021-09-14 6:52 ` [PATCH v3 2/9] clk: imx: Update the pllv4 to support imx8ulp Jacky Bai
2021-09-14 11:29 ` Abel Vesa
2021-09-14 6:52 ` [PATCH v3 3/9] clk: imx: Update the compsite driver " Jacky Bai
2021-09-14 11:30 ` Abel Vesa
2021-09-14 6:52 ` [PATCH v3 4/9] clk: imx: disable i.mx7ulp composite clock during initialization Jacky Bai
2021-09-14 11:32 ` Abel Vesa
2021-09-14 6:52 ` [PATCH v3 5/9] clk: imx: Add 'CLK_SET_RATE_NO_REPARENT' for composite-7ulp Jacky Bai
2021-09-14 11:33 ` Abel Vesa
2021-09-14 6:52 ` [PATCH v3 6/9] clk: imx: disable the pfd when set pfdv2 clock rate Jacky Bai
2021-09-14 11:34 ` Abel Vesa
2021-09-14 6:52 ` [PATCH v3 7/9] clk: imx: Update the pfdv2 for 8ulp specific support Jacky Bai
2021-09-14 11:35 ` Abel Vesa
2021-09-14 6:52 ` [PATCH v3 8/9] clk: imx: Add clock driver for imx8ulp Jacky Bai
2021-09-14 11:55 ` Abel Vesa
2021-09-14 6:52 ` [PATCH v3 9/9] clk: imx: Add the pcc reset controller support on imx8ulp Jacky Bai
2021-09-14 12:09 ` Abel Vesa
2021-09-14 13:07 ` Jacky Bai
2021-09-14 15:19 ` Abel Vesa
2021-09-14 11:17 ` [PATCH v3 0/9] Add imx8ulp clock & reset driver support Abel Vesa
2021-09-16 6:46 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUkAyw1pGE8EOKd1@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=p.zabel@pengutronix.de \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).