From: Rob Herring <robh@kernel.org>
To: Yong Wu <yong.wu@mediatek.com>
Cc: Ikjoon Jang <ikjn@chromium.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
youlin.pei@mediatek.com,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
devicetree@vger.kernel.org, Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, yi.kuo@mediatek.com,
anan.sun@mediatek.com, Tomasz Figa <tfiga@chromium.org>,
ming-fan.chen@mediatek.com,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
iommu@lists.linux-foundation.org,
Rob Herring <robh+dt@kernel.org>,
anthony.huang@mediatek.com, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v4 02/13] dt-bindings: memory: mediatek: Add mt8195 smi sub common
Date: Tue, 21 Sep 2021 15:36:42 -0500 [thread overview]
Message-ID: <YUpCWib8Tpf0wfif@robh.at.kernel.org> (raw)
In-Reply-To: <20210914113703.31466-3-yong.wu@mediatek.com>
On Tue, 14 Sep 2021 19:36:52 +0800, Yong Wu wrote:
> Add the binding for smi-sub-common. The SMI block diagram like this:
>
> IOMMU
> | |
> smi-common
> ------------------
> | .... |
> larb0 larb7 <-max is 8
>
> The smi-common connects with smi-larb and IOMMU. The maximum larbs number
> that connects with a smi-common is 8. If the engines number is over 8,
> sometimes we use a smi-sub-common which is nearly same with smi-common.
> It supports up to 8 input and 1 output(smi-common has 2 output)
>
> Something like:
>
> IOMMU
> | |
> smi-common
> ---------------------
> | | ...
> larb0 sub-common ... <-max is 8
> -----------
> | | ... <-max is 8 too.
> larb2 larb5
>
> We don't need extra SW setting for smi-sub-common, only the sub-common has
> special clocks need to enable when the engines access dram.
>
> If it is sub-common, it should have a "mediatek,smi" phandle to point to
> its smi-common. meanwhile the sub-common only has one gals clock.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
> ---
> change note: add "else mediatek,smi: false".
> ---
> .../mediatek,smi-common.yaml | 28 +++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-09-21 20:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 11:36 [PATCH v4 00/13] MT8195 SMI support Yong Wu
2021-09-14 11:36 ` [PATCH v4 01/13] dt-bindings: memory: mediatek: Add mt8195 smi binding Yong Wu
2021-09-14 11:36 ` [PATCH v4 02/13] dt-bindings: memory: mediatek: Add mt8195 smi sub common Yong Wu
2021-09-21 20:36 ` Rob Herring [this message]
2021-09-14 11:36 ` [PATCH v4 03/13] memory: mtk-smi: Use clk_bulk clock ops Yong Wu
2021-10-15 13:38 ` AngeloGioacchino Del Regno
2021-10-15 13:43 ` Krzysztof Kozlowski
2021-10-15 13:47 ` AngeloGioacchino Del Regno
2021-09-14 11:36 ` [PATCH v4 04/13] memory: mtk-smi: Rename smi_gen to smi_type Yong Wu
2021-09-14 11:36 ` [PATCH v4 05/13] memory: mtk-smi: Adjust some code position Yong Wu
2021-09-14 11:36 ` [PATCH v4 06/13] memory: mtk-smi: Add error handle for smi_probe Yong Wu
2021-09-14 11:36 ` [PATCH v4 07/13] memory: mtk-smi: Add device link for smi-sub-common Yong Wu
2021-09-14 11:36 ` [PATCH v4 08/13] memory: mtk-smi: Add clocks " Yong Wu
2021-09-14 11:36 ` [PATCH v4 09/13] memory: mtk-smi: Use devm_platform_ioremap_resource Yong Wu
2021-09-14 11:37 ` [PATCH v4 10/13] memory: mtk-smi: mt8195: Add smi support Yong Wu
2021-09-14 11:37 ` [PATCH v4 11/13] memory: mtk-smi: mt8195: Add initial setting for smi-common Yong Wu
2021-09-14 11:37 ` [PATCH v4 12/13] memory: mtk-smi: mt8195: Add initial setting for smi-larb Yong Wu
2021-09-14 11:37 ` [PATCH v4 13/13] MAINTAINERS: Add entry for MediaTek SMI Yong Wu
2021-09-22 6:44 ` [PATCH v4 00/13] MT8195 SMI support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUpCWib8Tpf0wfif@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=anan.sun@mediatek.com \
--cc=anthony.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=ikjn@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ming-fan.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=will@kernel.org \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).