From: Rob Herring <robh@kernel.org>
To: Sinthu Raja <sinthu.raja@mistralsolutions.com>
Cc: linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Suman Anna <s-anna@ti.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Ohad Ben-Cohen <ohad@wizery.com>, Nishanth Menon <nm@ti.com>,
Sinthu Raja <sinthu.raja@ti.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH V3] dt-bindings: hwlock: omap: Remove redundant binding example
Date: Thu, 23 Sep 2021 08:09:27 -0500 [thread overview]
Message-ID: <YUx8h0MTHg+TMG3z@robh.at.kernel.org> (raw)
In-Reply-To: <20210920123152.32751-1-sinthu.raja@ti.com>
On Mon, 20 Sep 2021 18:01:52 +0530, Sinthu Raja wrote:
> From: Sinthu Raja <sinthu.raja@ti.com>
>
> The example includes a board-specific compatible property, this is wrong
> as the example should be board agnostic and should represent the particular
> binding. Also, the file includes two similar examples but with a different
> compatible. So, drop the entire second example
>
> Suggested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
>
> ---
>
> Changes in V3:
> Addressed review comment, that includes adding Suggested By: tag to the
> commit message
>
> V2: https://lore.kernel.org/all/20210917170805.5079-1-sinthu.raja@ti.com/
> V1: https://lore.kernel.org/all/20210917094740.18891-1-sinthu.raja@ti.com/
>
> .../bindings/hwlock/ti,omap-hwspinlock.yaml | 33 +------------------
> 1 file changed, 1 insertion(+), 32 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2021-09-23 13:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:31 [PATCH V3] dt-bindings: hwlock: omap: Remove redundant binding example Sinthu Raja
2021-09-20 20:57 ` Suman Anna
2021-09-23 13:09 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUx8h0MTHg+TMG3z@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=baolin.wang7@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=nm@ti.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=s-anna@ti.com \
--cc=sinthu.raja@mistralsolutions.com \
--cc=sinthu.raja@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).