From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DD2C433FE for ; Thu, 23 Sep 2021 09:11:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22A3161216 for ; Thu, 23 Sep 2021 09:11:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240096AbhIWJM7 (ORCPT ); Thu, 23 Sep 2021 05:12:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240091AbhIWJMw (ORCPT ); Thu, 23 Sep 2021 05:12:52 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30B90C061757 for ; Thu, 23 Sep 2021 02:11:17 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id t8so15181488wrq.4 for ; Thu, 23 Sep 2021 02:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=12EQr3ZLzKhK5ETv63IZ0Tjj44UHMvHzw6pTaaaVejk=; b=oZ1AjSVrUD/dVn2FpE7IzgZHVXx3Zr4Db8ttahRB4jS+mvtQ6lJmu64c1fZj2L0XYu Nk+knP4iBIw+WEFCm8uK9ym2pVOIFRjk8U2jiudtBwtfAEg/sUN4FraMC/Z3PjwoIw1y 0wdGMV2l4/3+LTtaWsQLAA4r3wtejkmbb03UVP9otgbKU7goQToYMh48VOJn21QmlYnt CaGMVQ3dQqusilc79T/CqAsAqWw8bu4BvrwNjnJmMCQmyZQDK3JYW593p4QdT+FR+S11 uNEwUNSBbbm5oXJKbPtL+aOXT/4NJoK7/CEYK6vVzHV7e3/aRiFHT0Ia1u08Hc090MHR 9J7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=12EQr3ZLzKhK5ETv63IZ0Tjj44UHMvHzw6pTaaaVejk=; b=Ej3oOfhtfDdSVqN7SExO1xKs2+NpcRcBmIZVn5Ba4IpmSB++WTGqX2vBp/a2lW2ju9 fwbyRuQTq+YrqS7MEnkc9acjfl7C3bxAMQCAW/7wcixjW97vC2GSN54QEFR7zNl0e7Yl umhVBv0dycd5V0donzwSp/J5qhRNtkK8TOmxVPl1YEBoI1dxbN3XAtJAw1+1YI8fIsba 1U2AnoJkeMTW6tahZZcn1bKbqu5l+nI1iWYuUlnzen1dAletiZ4ET2iK0s66drt2RgmA IkTQy6OTKylyr9rSEkXJXuw135ULyOs1DaVor3xz6R4cR6OFUyUsJuWNodTmfepbU3L2 Bbsw== X-Gm-Message-State: AOAM531psKqPv0nOuYfW5aely3hwFAEgpOn/HjAEOTnfHHA/xoCdWsYs nmlyQAFRGzwItHt/x7YevReJxSo5WIkvFQ== X-Google-Smtp-Source: ABdhPJzsZyxJPiWcYgyjEaAxZQmGBvHDVjGMpwzVh6RVfLuFHlx9uWt9U3zqfL7XJ1MZkxFm98ajBQ== X-Received: by 2002:a1c:7714:: with SMTP id t20mr14740503wmi.163.1632388275609; Thu, 23 Sep 2021 02:11:15 -0700 (PDT) Received: from google.com ([95.148.6.233]) by smtp.gmail.com with ESMTPSA id c7sm4890729wmq.13.2021.09.23.02.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 02:11:15 -0700 (PDT) Date: Thu, 23 Sep 2021 10:11:13 +0100 From: Lee Jones To: Miquel Raynal Cc: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Dmitry Torokhov , bcousson@baylibre.com, Tony Lindgren , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, Thomas Petazzoni , Vignesh Raghavendra , Lokesh Vutla , Tero Kristo , Ryan Barnett , Grygorii Strashko , Jason Reeder , Jonathan Cameron Subject: Re: [PATCH v3 36/47] mfd: ti_am335x_tscadc: Support the correctly spelled DT property Message-ID: References: <20210915155908.476767-1-miquel.raynal@bootlin.com> <20210915155908.476767-37-miquel.raynal@bootlin.com> <20210923101922.2c108d2b@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210923101922.2c108d2b@xps13> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 23 Sep 2021, Miquel Raynal wrote: > Hi Lee, > > lee.jones@linaro.org wrote on Wed, 22 Sep 2021 16:57:10 +0100: > > > On Wed, 15 Sep 2021, Miquel Raynal wrote: > > > > > There was in the past a typo in the coordinate readouts property. The > > > bindings have been updated, the touchscreen driver as well and now > > > supports both. However, the MFD driver that is in charge of verifying > > > the validity of the property only checks the bogus one. Add support for > > > the correctly spelled DT property. > > > > > > Fixes: c9aeb249bf72 ("Input: ti_am335x_tsc - fix spelling mistake in TSC/ADC DT binding") > > > Signed-off-by: Miquel Raynal > > > Reviewed-by: Jonathan Cameron > > > --- > > > drivers/mfd/ti_am335x_tscadc.c | 8 +++++++- > > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c > > > index 155a8ed879b3..aa46ed669016 100644 > > > --- a/drivers/mfd/ti_am335x_tscadc.c > > > +++ b/drivers/mfd/ti_am335x_tscadc.c > > > @@ -144,8 +144,14 @@ static int ti_tscadc_probe(struct platform_device *pdev) > > > if (tscadc->data->has_tsc) { > > > node = of_get_child_by_name(pdev->dev.of_node, "tsc"); > > > of_property_read_u32(node, "ti,wires", &tscmag_wires); > > > - of_property_read_u32(node, "ti,coordiante-readouts", &readouts); > > > + err = of_property_read_u32(node, "ti,coordinate-readouts", > > > + &readouts); > > > + if (err < 0) > > > + of_property_read_u32(node, "ti,coordiante-readouts", > > > + &readouts); > > > + > > > > How long are you proposing that we support this churn? > > Well, I am not proposing anything, I am just "fixing" the driver so > that it fits the bindings :) Given the fact that at the end of this > series there is a patch that changes the "coordiante" typo to > "coordinate" in a device tree source file, I believe it is still too > soon... If this is something you're changing in this set, please reconsider. I'd rather have a slightly misspelled documented property than being forced to support 2 for any length of time. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog