From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D84DC433EF for ; Wed, 6 Oct 2021 09:18:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 258CE61165 for ; Wed, 6 Oct 2021 09:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237703AbhJFJUe (ORCPT ); Wed, 6 Oct 2021 05:20:34 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:59806 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbhJFJUd (ORCPT ); Wed, 6 Oct 2021 05:20:33 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F006A581; Wed, 6 Oct 2021 11:18:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1633511921; bh=lHlaAMccgyN3f2+iHICqMUQ8B2hxG5eHnMuV76r9n0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=coeeqRMKluoR1uSJ5kI+0a68znpR1V1/QAzoH+SQkVjq234UAaufykftcGXQ4vvMG 7WziKhL4T67550RmeWaBZ5Q9mycpdUmrTvsoIt7FYm3H0ixEoRd6ubXSH7adjQAXQn hVkYGkcwGhzIbWArZyXjA2tRuV15lHKuz4NO/mxc= Date: Wed, 6 Oct 2021 12:18:33 +0300 From: Laurent Pinchart To: Alexander Stein Cc: David Airlie , Daniel Vetter , Rob Herring , Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH 3/3] drm/bridge: ti-sn65dsi8: Make enable GPIO optional Message-ID: References: <20211006074713.1094396-1-alexander.stein@ew.tq-group.com> <20211006074713.1094396-3-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Oct 06, 2021 at 12:18:02PM +0300, Laurent Pinchart wrote: > Hi Alexander, > > Thank you for the patch. One more thing, the subject line has a typo, it should read ti-sn65dsi83. > On Wed, Oct 06, 2021 at 09:47:13AM +0200, Alexander Stein wrote: > > The enable signal may not be controllable by the kernel. Make it > > optional. > > This is a similar to commit bbda1704fc15 ("drm/bridge: ti-sn65dsi86: Make > > enable GPIO optional") > > > > Signed-off-by: Alexander Stein > > --- > > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > > index 5fab0fabcd15..101da29ba698 100644 > > --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > > @@ -679,7 +679,7 @@ static int sn65dsi83_probe(struct i2c_client *client, > > model = id->driver_data; > > } > > > > - ctx->enable_gpio = devm_gpiod_get(ctx->dev, "enable", GPIOD_OUT_LOW); > > + ctx->enable_gpio = devm_gpiod_get_optional(ctx->dev, "enable", GPIOD_OUT_LOW); > > You can wrap this line as > > ctx->enable_gpio = devm_gpiod_get_optional(ctx->dev, "enable", > GPIOD_OUT_LOW); > > Reviewed-by: Laurent Pinchart > > Corresponding DT bindings changes are needed, I've sent a patch in this > mail thread. > > > if (IS_ERR(ctx->enable_gpio)) > > return PTR_ERR(ctx->enable_gpio); > > -- Regards, Laurent Pinchart