Re: [PATCH 3/3] drm/bridge: ti-sn65dsi8: Make enable GPIO optional

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Alexander,

Thank you for the patch.

On Wed, Oct 06, 2021 at 09:47:13AM +0200, Alexander Stein wrote:
> The enable signal may not be controllable by the kernel. Make it
> optional.
> This is a similar to commit bbda1704fc15 ("drm/bridge: ti-sn65dsi86: Make
> enable GPIO optional")
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> index 5fab0fabcd15..101da29ba698 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
> @@ -679,7 +679,7 @@ static int sn65dsi83_probe(struct i2c_client *client,
>  		model = id->driver_data;
>  	}
>  
> -	ctx->enable_gpio = devm_gpiod_get(ctx->dev, "enable", GPIOD_OUT_LOW);
> +	ctx->enable_gpio = devm_gpiod_get_optional(ctx->dev, "enable", GPIOD_OUT_LOW);

You can wrap this line as

	ctx->enable_gpio = devm_gpiod_get_optional(ctx->dev, "enable",
						   GPIOD_OUT_LOW);

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Corresponding DT bindings changes are needed, I've sent a patch in this
mail thread.

>  	if (IS_ERR(ctx->enable_gpio))
>  		return PTR_ERR(ctx->enable_gpio);
>  

-- 
Regards,

Laurent Pinchart