Re: [PATCH v3 11/11] dt-bindings: hwmon: allow specifying channels for tmp421

[Krzysztof Adamski <krzysztof.adamski@nokia.com>]

Dnia Wed, Oct 06, 2021 at 03:55:46PM -0500, Rob Herring napisał(a):
>>
>> 	input@0 {
>> 		reg = <0>;
>> 		label = "output voltage";
>> 	};
>>
>> Anyway, maybe Rob has an idea how to name this properly.
>
>No, I don't have a sense of the range of h/w...

I feel like we are stuck. Rob does not have a sense of the range of the
h/w and Guenter does not have a sense of the DeviceTree idioms. How can
we solve that?

Could we, maybe, just focus on this typical, simplified, case I have for
now - a sensor with several channels of known, same type (temperature)?
We clearly are unable handle all possible cases here, for now.

Does this look sane for that usecase or what would you, Rob, change?

sensor@4c {
   compatible = "ti,tmp422";
   reg = <0x4c>;
   #address-cells = <1>;
   #size-cells = <0>;

   input@0 {
     reg = <0x0>;
     ti,n-factor = <0x1>;
     label = "local";
   };

   input@1 {
     reg = <0x1>;
     ti,n-factor = <0x0>;
     label = "somelabel";
   };

   input@2 {
     reg = <0x2>;
     status = "disabled";
   };
};

There were some doubts whether "input" makes sense here.  I still think
it doas as even in HWMON subsystem, we have "hwmon_temp_input" and
HWMON_T_INPUT, so a temperature channel _is_ an input.  Of course I can
change it to "temperature" or "channel", just tell me which one is
accepted.

Krzysztof