* [PATCH v3 1/6] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 [not found] <20210922234726.3337265-1-kieran.bingham@ideasonboard.com> @ 2021-09-22 23:47 ` Kieran Bingham 2021-09-23 7:43 ` Geert Uytterhoeven 2021-09-23 13:01 ` [PATCH v3.1] " Kieran Bingham 0 siblings, 2 replies; 5+ messages in thread From: Kieran Bingham @ 2021-09-22 23:47 UTC (permalink / raw) To: linux-renesas-soc, Laurent Pinchart Cc: Kieran Bingham, David Airlie, Daniel Vetter, Rob Herring, open list:DRM DRIVERS FOR RENESAS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Extend the Renesas DU display bindings to support the r8a779a0 V3U. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- v2: - Collected Laurent's tag - Remove clock-names requirement - Specify only a single clock v3: - Use clocknames: 'du.0' instead of 'du' to remain consistent .../bindings/display/renesas,du.yaml | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml index e3ca5389c17d..6db6a3f15395 100644 --- a/Documentation/devicetree/bindings/display/renesas,du.yaml +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml @@ -39,6 +39,7 @@ properties: - renesas,du-r8a77980 # for R-Car V3H compatible DU - renesas,du-r8a77990 # for R-Car E3 compatible DU - renesas,du-r8a77995 # for R-Car D3 compatible DU + - renesas,du-r8a779a0 # for R-Car V3U compatible DU reg: maxItems: 1 @@ -773,6 +774,55 @@ allOf: - reset-names - renesas,vsps + - if: + properties: + compatible: + contains: + enum: + - renesas,du-r8a779a0 + then: + properties: + clocks: + items: + - description: Functional clock + + clock-names: + maxItems: 1 + items: + - const: du.0 + + interrupts: + maxItems: 2 + + resets: + maxItems: 1 + + reset-names: + items: + - const: du.0 + + ports: + properties: + port@0: + description: DSI 0 + port@1: + description: DSI 1 + port@2: false + port@3: false + + required: + - port@0 + - port@1 + + renesas,vsps: + minItems: 2 + + required: + - interrupts + - resets + - reset-names + - renesas,vsps + additionalProperties: false examples: -- 2.30.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/6] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 2021-09-22 23:47 ` [PATCH v3 1/6] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 Kieran Bingham @ 2021-09-23 7:43 ` Geert Uytterhoeven 2021-09-23 13:01 ` [PATCH v3.1] " Kieran Bingham 1 sibling, 0 replies; 5+ messages in thread From: Geert Uytterhoeven @ 2021-09-23 7:43 UTC (permalink / raw) To: Kieran Bingham Cc: Linux-Renesas, Laurent Pinchart, Kieran Bingham, David Airlie, Daniel Vetter, Rob Herring, open list:DRM DRIVERS FOR RENESAS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list Hi Kieran, On Thu, Sep 23, 2021 at 1:47 AM Kieran Bingham <kieran.bingham@ideasonboard.com> wrote: > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > --- > v2: > - Collected Laurent's tag > - Remove clock-names requirement > - Specify only a single clock > > v3: > - Use clocknames: 'du.0' instead of 'du' to remain consistent Thanks for the update! > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml > @@ -39,6 +39,7 @@ properties: > - renesas,du-r8a77980 # for R-Car V3H compatible DU > - renesas,du-r8a77990 # for R-Car E3 compatible DU > - renesas,du-r8a77995 # for R-Car D3 compatible DU > + - renesas,du-r8a779a0 # for R-Car V3U compatible DU > > reg: > maxItems: 1 > @@ -773,6 +774,55 @@ allOf: > - reset-names > - renesas,vsps > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,du-r8a779a0 > + then: > + properties: > + clocks: > + items: > + - description: Functional clock > + > + clock-names: > + maxItems: 1 > + items: > + - const: du.0 > + > + interrupts: > + maxItems: 2 > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: du.0 > + > + ports: > + properties: > + port@0: > + description: DSI 0 > + port@1: > + description: DSI 1 > + port@2: false > + port@3: false > + > + required: > + - port@0 > + - port@1 > + > + renesas,vsps: > + minItems: 2 > + > + required: > + - interrupts > + - resets > + - reset-names > + - renesas,vsps clock-names, for consistency? > + > additionalProperties: false > > examples: With the above fixed: Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3.1] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 2021-09-22 23:47 ` [PATCH v3 1/6] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 Kieran Bingham 2021-09-23 7:43 ` Geert Uytterhoeven @ 2021-09-23 13:01 ` Kieran Bingham 2021-09-27 20:57 ` Rob Herring 1 sibling, 1 reply; 5+ messages in thread From: Kieran Bingham @ 2021-09-23 13:01 UTC (permalink / raw) To: linux-renesas-soc, Laurent Pinchart, Geert Uytterhoeven Cc: Kieran Bingham, Geert Uytterhoeven, David Airlie, Daniel Vetter, Rob Herring, open list:DRM DRIVERS FOR RENESAS, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Extend the Renesas DU display bindings to support the r8a779a0 V3U. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> --- v2: - Collected Laurent's tag - Remove clock-names requirement - Specify only a single clock v3: - Use clocknames: 'du.0' instead of 'du' to remain consistent v3.1: - Require clock-names - Collect Geert's tag .../bindings/display/renesas,du.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml index e3ca5389c17d..13efea574584 100644 --- a/Documentation/devicetree/bindings/display/renesas,du.yaml +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml @@ -39,6 +39,7 @@ properties: - renesas,du-r8a77980 # for R-Car V3H compatible DU - renesas,du-r8a77990 # for R-Car E3 compatible DU - renesas,du-r8a77995 # for R-Car D3 compatible DU + - renesas,du-r8a779a0 # for R-Car V3U compatible DU reg: maxItems: 1 @@ -773,6 +774,56 @@ allOf: - reset-names - renesas,vsps + - if: + properties: + compatible: + contains: + enum: + - renesas,du-r8a779a0 + then: + properties: + clocks: + items: + - description: Functional clock + + clock-names: + maxItems: 1 + items: + - const: du.0 + + interrupts: + maxItems: 2 + + resets: + maxItems: 1 + + reset-names: + items: + - const: du.0 + + ports: + properties: + port@0: + description: DSI 0 + port@1: + description: DSI 1 + port@2: false + port@3: false + + required: + - port@0 + - port@1 + + renesas,vsps: + minItems: 2 + + required: + - clock-names + - interrupts + - resets + - reset-names + - renesas,vsps + additionalProperties: false examples: -- 2.30.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3.1] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 2021-09-23 13:01 ` [PATCH v3.1] " Kieran Bingham @ 2021-09-27 20:57 ` Rob Herring 2021-09-28 1:11 ` Laurent Pinchart 0 siblings, 1 reply; 5+ messages in thread From: Rob Herring @ 2021-09-27 20:57 UTC (permalink / raw) To: Kieran Bingham Cc: Geert Uytterhoeven, devicetree, linux-kernel, David Airlie, linux-renesas-soc, Laurent Pinchart, Geert Uytterhoeven, dri-devel, Kieran Bingham, Rob Herring, Daniel Vetter On Thu, 23 Sep 2021 14:01:38 +0100, Kieran Bingham wrote: > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > --- > v2: > - Collected Laurent's tag > - Remove clock-names requirement > - Specify only a single clock > > v3: > - Use clocknames: 'du.0' instead of 'du' to remain consistent > > v3.1: > - Require clock-names > - Collect Geert's tag > > .../bindings/display/renesas,du.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3.1] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 2021-09-27 20:57 ` Rob Herring @ 2021-09-28 1:11 ` Laurent Pinchart 0 siblings, 0 replies; 5+ messages in thread From: Laurent Pinchart @ 2021-09-28 1:11 UTC (permalink / raw) To: Rob Herring Cc: Kieran Bingham, Geert Uytterhoeven, devicetree, linux-kernel, David Airlie, linux-renesas-soc, Geert Uytterhoeven, dri-devel, Kieran Bingham, Rob Herring, Daniel Vetter On Mon, Sep 27, 2021 at 03:57:34PM -0500, Rob Herring wrote: > On Thu, 23 Sep 2021 14:01:38 +0100, Kieran Bingham wrote: > > From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > Extend the Renesas DU display bindings to support the r8a779a0 V3U. > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > > > > --- > > v2: > > - Collected Laurent's tag > > - Remove clock-names requirement > > - Specify only a single clock > > > > v3: > > - Use clocknames: 'du.0' instead of 'du' to remain consistent > > > > v3.1: > > - Require clock-names > > - Collect Geert's tag > > > > .../bindings/display/renesas,du.yaml | 51 +++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > Reviewed-by: Rob Herring <robh@kernel.org> Thank you Rob, that was the missing piece for a pull request :-) -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-28 1:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210922234726.3337265-1-kieran.bingham@ideasonboard.com>
2021-09-22 23:47 ` [PATCH v3 1/6] dt-bindings: display: renesas,du: Provide bindings for r8a779a0 Kieran Bingham
2021-09-23 7:43 ` Geert Uytterhoeven
2021-09-23 13:01 ` [PATCH v3.1] " Kieran Bingham
2021-09-27 20:57 ` Rob Herring
2021-09-28 1:11 ` Laurent Pinchart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).