From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency
Date: Mon, 4 Oct 2021 09:56:13 -0500 [thread overview]
Message-ID: <YVsWDaC0TOSOrrxW@robh.at.kernel.org> (raw)
In-Reply-To: <20210928082346.22398-1-krzysztof.kozlowski@canonical.com>
On Tue, Sep 28, 2021 at 10:23:46AM +0200, Krzysztof Kozlowski wrote:
> The meta-schema already defines dependency between clock-cells and
You mean the schema already does.
> clock-output-names.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> index 23abb7e8b9d8..dd70431df0b7 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.yaml
> @@ -158,10 +158,6 @@ properties:
> description:
> The MIO bank number in which the command and data lines are configured.
>
> -dependencies:
> - clock-output-names: [ '#clock-cells' ]
The schema defines this.
> - '#clock-cells': [ clock-output-names ]
But not this. That's because in the common case, clock-output-names is
optional. But here it is required when '#clock-cells' is present.
Rob
next prev parent reply other threads:[~2021-10-04 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 8:23 [PATCH] dt-bindings: mmc: arasan,sdci: drop unneeded clock-cells dependency Krzysztof Kozlowski
2021-09-30 11:24 ` Ulf Hansson
2021-10-04 14:56 ` Rob Herring [this message]
2021-10-04 14:59 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVsWDaC0TOSOrrxW@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).