From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA520C433EF for ; Mon, 4 Oct 2021 18:07:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B32D61163 for ; Mon, 4 Oct 2021 18:07:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237789AbhJDSIw (ORCPT ); Mon, 4 Oct 2021 14:08:52 -0400 Received: from mail-oi1-f178.google.com ([209.85.167.178]:36608 "EHLO mail-oi1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237757AbhJDSIg (ORCPT ); Mon, 4 Oct 2021 14:08:36 -0400 Received: by mail-oi1-f178.google.com with SMTP id y201so22746674oie.3; Mon, 04 Oct 2021 11:06:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0nglCwSmLkqWcDDYbgeQI0Rj6hImnZUh6ykmGdkaXq8=; b=IxbFNuQMU6zNOxo/0NJb+24MxCdv2rJEPOWZyoQDPgsXd35iudXasTMy1BcFrmOIIf kqYsdzxp5X/QafrXXB7hKXcnfwmsx3YB9PA4ZvNNCaBUCsc+2UK5hfbWsK1qSahhMb3a fL9fr8zQaQBqWAZJDV0wJu1OOCnyvP/n+xpU4rvc0AXpRlvhG6ozuCnvGMQGtshF9yeK vQdW5mDwvKwYYAEWxoStjnQFJnh32WVz04VZ/g/9cx2DtHNzb5F+sQTwmcihYDy/cAtq jOPUbBwyhW6K8vKTcnauVPFkfwWt9yQtdu9yVIOrPNKUsLUmA0+XkU/8oswb/gVjOXkI PJOA== X-Gm-Message-State: AOAM531IYIyAiLIJ7sAWoyyxSwiCX0S5XfuwD1At83HsYHlgnbckPDEQ 2jFybbYu1oqwZXXQhzaezg== X-Google-Smtp-Source: ABdhPJzc6i6SjUk6crMunB3I6rcO8tJCZQ3N0J3WDSTRxPs5tV4XPfPSZZeDN54KEpyM2WQoVndhDw== X-Received: by 2002:aca:e143:: with SMTP id y64mr14547898oig.21.1633370806633; Mon, 04 Oct 2021 11:06:46 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id w14sm3032395oth.5.2021.10.04.11.06.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 11:06:46 -0700 (PDT) Received: (nullmailer pid 1577410 invoked by uid 1000); Mon, 04 Oct 2021 18:06:44 -0000 Date: Mon, 4 Oct 2021 13:06:44 -0500 From: Rob Herring To: Sergio Paracuellos Cc: linux-staging@lists.linux.dev, john@phrozen.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, neil@brown.name, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt: bindings: add ralink RT2880 resets device tree binding documentation Message-ID: References: <20210926145931.14603-1-sergio.paracuellos@gmail.com> <20210926145931.14603-3-sergio.paracuellos@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210926145931.14603-3-sergio.paracuellos@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sun, Sep 26, 2021 at 04:59:30PM +0200, Sergio Paracuellos wrote: > Adds device tree binding documentation for resets in the ralink RT2880 SoCs. > > Signed-off-by: Sergio Paracuellos > --- > .../bindings/reset/ralink,rt2880-reset.yaml | 39 +++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/ralink,rt2880-reset.yaml > > diff --git a/Documentation/devicetree/bindings/reset/ralink,rt2880-reset.yaml b/Documentation/devicetree/bindings/reset/ralink,rt2880-reset.yaml > new file mode 100644 > index 000000000000..88eddeb4ee45 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/ralink,rt2880-reset.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/reset/ralink,rt2880-reset.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ralink RT2880 Reset Controller Device Tree Bindings > + > +maintainers: > + - Sergio Paracuellos > + > +description: | > + Ralink RT2880 reset controller driver which supports the SoC > + system controller supplied reset registers for the various peripherals > + of the SoC. > + > + See also: > + - dt-bindings/reset/ralink-rt2880.h > + > +properties: > + compatible: > + const: ralink,rt2880-reset > + > + '#reset-cells': > + const: 1 > + > +required: > + - '#reset-cells' > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include > + rstctrl: reset-controller { > + compatible = "ralink,rt2880-reset"; > + #reset-cells = <1>; How is this h/w controlled? If this is part of a system controller, then it needs to be documented as such. IOW, you need to document the binding for the whole block. Do you really need a child node here? All you need to make a system controller a reset provider is add '#reset-cells' to it. Rob