* [PATCH 0/2] Add QCM2290 USB3 PHY support
@ 2021-09-27 6:48 Shawn Guo
2021-09-27 6:48 ` [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY Shawn Guo
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Shawn Guo @ 2021-09-27 6:48 UTC (permalink / raw)
To: Vinod Koul
Cc: Bjorn Andersson, Rob Herring, Loic Poulain, linux-phy, devicetree,
linux-arm-msm, linux-kernel, Shawn Guo
The series adds support for USB3 PHY found on QCM2290 SoC.
Shawn Guo (2):
dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY
phy: qcom-qmp: Add QCM2290 USB3 PHY support
.../devicetree/bindings/phy/qcom,qmp-phy.yaml | 27 ++++
drivers/phy/qualcomm/phy-qcom-qmp.c | 143 ++++++++++++++++++
drivers/phy/qualcomm/phy-qcom-qmp.h | 2 +
3 files changed, 172 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY 2021-09-27 6:48 [PATCH 0/2] Add QCM2290 USB3 PHY support Shawn Guo @ 2021-09-27 6:48 ` Shawn Guo 2021-09-27 12:23 ` Rob Herring 2021-10-04 18:14 ` Rob Herring 2021-09-27 6:48 ` [PATCH 2/2] phy: qcom-qmp: Add QCM2290 USB3 PHY support Shawn Guo 2021-10-05 7:50 ` [PATCH 0/2] " Vinod Koul 2 siblings, 2 replies; 7+ messages in thread From: Shawn Guo @ 2021-09-27 6:48 UTC (permalink / raw) To: Vinod Koul Cc: Bjorn Andersson, Rob Herring, Loic Poulain, linux-phy, devicetree, linux-arm-msm, linux-kernel, Shawn Guo Add support for USB3 PHY found on Qualcomm QCM2290 SoC. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml index 75be5650a198..4e7371956ed4 100644 --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml @@ -27,6 +27,7 @@ properties: - qcom,msm8998-qmp-pcie-phy - qcom,msm8998-qmp-ufs-phy - qcom,msm8998-qmp-usb3-phy + - qcom,qcm2290-qmp-usb3-phy - qcom,sc7180-qmp-usb3-phy - qcom,sc8180x-qmp-pcie-phy - qcom,sc8180x-qmp-ufs-phy @@ -414,6 +415,32 @@ allOf: items: - const: phy - const: common + - if: + properties: + compatible: + contains: + enum: + - qcom,qcm2290-qmp-usb3-phy + then: + properties: + clocks: + items: + - description: Phy config clock. + - description: 19.2 MHz ref clk. + - description: Phy common block aux clock. + clock-names: + items: + - const: cfg_ahb + - const: ref + - const: com_aux + resets: + items: + - description: phy_phy reset. + - description: reset of phy block. + reset-names: + items: + - const: phy_phy + - const: phy examples: - | -- 2.17.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY 2021-09-27 6:48 ` [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY Shawn Guo @ 2021-09-27 12:23 ` Rob Herring 2021-10-01 8:19 ` Vinod Koul 2021-10-04 18:14 ` Rob Herring 1 sibling, 1 reply; 7+ messages in thread From: Rob Herring @ 2021-09-27 12:23 UTC (permalink / raw) To: Shawn Guo Cc: Rob Herring, devicetree, linux-phy, Bjorn Andersson, Loic Poulain, linux-arm-msm, Vinod Koul, linux-kernel On Mon, 27 Sep 2021 14:48:28 +0800, Shawn Guo wrote: > Add support for USB3 PHY found on Qualcomm QCM2290 SoC. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1533226 phy@1c06000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml phy@1c06000: 'lane@1c06800' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml phy@1c06000: 'lanes@1c06200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml phy@1c0a000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml phy@1c0a000: 'lanes@1c06200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml phy@1c0e000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml phy@1c0e000: 'lanes@1c0e200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml phy@1c16000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml phy@1c16000: 'lanes@1c16200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml phy@1d87000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sa8155p-adp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dt.yaml arch/arm64/boot/dts/qcom/sm8150-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml phy@1d87000: 'lanes@1d87400' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml phy@1d87000: 'lanes@1d87400', 'vdda-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sa8155p-adp.dt.yaml arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dt.yaml arch/arm64/boot/dts/qcom/sm8150-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8350-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8350-mtp.dt.yaml phy@1da7000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml phy@1da7000: 'lanes@1da7400' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml phy@1da7000: 'lanes@1da7400', 'vdda-phy-max-microamp', 'vdda-pll-max-microamp', 'vddp-ref-clk-always-on', 'vddp-ref-clk-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml phy@1da7000: 'vdda-phy-supply' is a required property arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml phy@1da7000: 'vdda-pll-supply' is a required property arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml phy@34000: 'lane@35000', 'lane@36000', 'lane@37000' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml phy@58000: 'lane@58200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@58000: 'vdda-phy-supply' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml phy@58000: 'vdda-pll-supply' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml phy@627000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml phy@627000: 'lanes@627400' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml phy@627000: 'lanes@627400', 'vdda-phy-max-microamp', 'vdda-pll-max-microamp' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml phy@7410000: 'lane@7410200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/apq8096-db820c.dt.yaml arch/arm64/boot/dts/qcom/apq8096-ifc6640.dt.yaml arch/arm64/boot/dts/qcom/msm8996-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-pmi8996-sony-xperia-tone-keyaki.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-kagura.dt.yaml arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-keyaki.dt.yaml phy@78000: 'lane@78200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@78000: 'vdda-phy-supply' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml phy@78000: 'vdda-pll-supply' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml phy@84000: 'lane@84200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml phy@86000: '#address-cells' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@86000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@86000: '#phy-cells', 'clock-output-names' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@86000: 'ranges' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@86000: '#size-cells' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@86000: 'vdda-phy-supply' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@86000: 'vdda-pll-supply' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@88e9000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dt.yaml arch/arm64/boot/dts/qcom/sm8150-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dt.yaml phy@88e9000: 'lanes@88e9200', 'reg-names' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sa8155p-adp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dt.yaml arch/arm64/boot/dts/qcom/sm8150-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dt.yaml phy@88eb000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sa8155p-adp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml phy@88eb000: 'lane@88eb200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sa8155p-adp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dt.yaml arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dt.yaml arch/arm64/boot/dts/qcom/sdm845-db845c.dt.yaml arch/arm64/boot/dts/qcom/sdm845-mtp.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dt.yaml arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium.dt.yaml arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dt.yaml arch/arm64/boot/dts/qcom/sm8150-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dt.yaml arch/arm64/boot/dts/qcom/sm8150-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-bahamut.dt.yaml arch/arm64/boot/dts/qcom/sm8150-sony-xperia-kumano-griffin.dt.yaml phy@88eb000: 'lanes@88eb200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/qrb5165-rb5.dt.yaml arch/arm64/boot/dts/qcom/sm8250-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8250-mtp.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx203.dt.yaml arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo-pdx206.dt.yaml phy@8e000: '#address-cells' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@8e000: '#clock-cells' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@8e000: '#phy-cells', 'clock-output-names' do not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@8e000: 'ranges' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@8e000: '#size-cells' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@8e000: 'vdda-phy-supply' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@8e000: 'vdda-pll-supply' is a required property arch/arm64/boot/dts/qcom/ipq8074-hk01.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c1.dt.yaml arch/arm64/boot/dts/qcom/ipq8074-hk10-c2.dt.yaml phy@c010000: 'lane@c010200' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/msm8998-asus-novago-tp370ql.dt.yaml arch/arm64/boot/dts/qcom/msm8998-hp-envy-x2.dt.yaml arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dt.yaml arch/arm64/boot/dts/qcom/msm8998-mtp.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dt.yaml arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dt.yaml phy-wrapper@88e9000: 'reg-names' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+' arch/arm64/boot/dts/qcom/sm8350-hdk.dt.yaml arch/arm64/boot/dts/qcom/sm8350-mtp.dt.yaml ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY 2021-09-27 12:23 ` Rob Herring @ 2021-10-01 8:19 ` Vinod Koul 0 siblings, 0 replies; 7+ messages in thread From: Vinod Koul @ 2021-10-01 8:19 UTC (permalink / raw) To: Rob Herring Cc: Shawn Guo, Rob Herring, devicetree, linux-phy, Bjorn Andersson, Loic Poulain, linux-arm-msm, linux-kernel On 27-09-21, 07:23, Rob Herring wrote: > On Mon, 27 Sep 2021 14:48:28 +0800, Shawn Guo wrote: > > Add support for USB3 PHY found on Qualcomm QCM2290 SoC. > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > --- > > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 27 +++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. Shawn has fixed it at: https://lore.kernel.org/r/20210929034253.24570-1-shawn.guo@linaro.org I guess you are okay with this patch, if not do let me know... -- ~Vinod ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY 2021-09-27 6:48 ` [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY Shawn Guo 2021-09-27 12:23 ` Rob Herring @ 2021-10-04 18:14 ` Rob Herring 1 sibling, 0 replies; 7+ messages in thread From: Rob Herring @ 2021-10-04 18:14 UTC (permalink / raw) To: Shawn Guo Cc: devicetree, Vinod Koul, linux-phy, linux-kernel, Bjorn Andersson, Loic Poulain, Rob Herring, linux-arm-msm On Mon, 27 Sep 2021 14:48:28 +0800, Shawn Guo wrote: > Add support for USB3 PHY found on Qualcomm QCM2290 SoC. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > --- > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] phy: qcom-qmp: Add QCM2290 USB3 PHY support 2021-09-27 6:48 [PATCH 0/2] Add QCM2290 USB3 PHY support Shawn Guo 2021-09-27 6:48 ` [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY Shawn Guo @ 2021-09-27 6:48 ` Shawn Guo 2021-10-05 7:50 ` [PATCH 0/2] " Vinod Koul 2 siblings, 0 replies; 7+ messages in thread From: Shawn Guo @ 2021-09-27 6:48 UTC (permalink / raw) To: Vinod Koul Cc: Bjorn Andersson, Rob Herring, Loic Poulain, linux-phy, devicetree, linux-arm-msm, linux-kernel, Shawn Guo Enable QCM2290 USB3 PHY support by adding the qmp_phy_cfg data which are taken from downstream kernel. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- drivers/phy/qualcomm/phy-qcom-qmp.c | 143 ++++++++++++++++++++++++++++ drivers/phy/qualcomm/phy-qcom-qmp.h | 2 + 2 files changed, 145 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index f14032170b1c..a39ec8280482 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -135,6 +135,8 @@ enum qphy_reg_layout { QPHY_PCS_LFPS_RXTERM_IRQ_CLEAR, QPHY_PCS_LFPS_RXTERM_IRQ_STATUS, QPHY_PCS_POWER_DOWN_CONTROL, + /* PCS_MISC registers */ + QPHY_PCS_MISC_TYPEC_CTRL, /* Keep last to ensure regs_layout arrays are properly initialized */ QPHY_LAYOUT_SIZE }; @@ -229,6 +231,16 @@ static const unsigned int sm8350_usb3_uniphy_regs_layout[QPHY_LAYOUT_SIZE] = { [QPHY_PCS_LFPS_RXTERM_IRQ_CLEAR] = 0x1014, }; +static const unsigned int qcm2290_usb3phy_regs_layout[QPHY_LAYOUT_SIZE] = { + [QPHY_SW_RESET] = 0x00, + [QPHY_PCS_POWER_DOWN_CONTROL] = 0x04, + [QPHY_START_CTRL] = 0x08, + [QPHY_PCS_AUTONOMOUS_MODE_CTRL] = 0xd8, + [QPHY_PCS_LFPS_RXTERM_IRQ_CLEAR] = 0xdc, + [QPHY_PCS_STATUS] = 0x174, + [QPHY_PCS_MISC_TYPEC_CTRL] = 0x00, +}; + static const unsigned int sdm845_ufsphy_regs_layout[QPHY_LAYOUT_SIZE] = { [QPHY_START_CTRL] = 0x00, [QPHY_PCS_READY_STATUS] = 0x160, @@ -2761,6 +2773,99 @@ static const struct qmp_phy_init_tbl sm8350_usb3_uniphy_pcs_tbl[] = { QMP_PHY_INIT_CFG(QPHY_V4_PCS_REFGEN_REQ_CONFIG1, 0x21), }; +static const struct qmp_phy_init_tbl qcm2290_usb3_serdes_tbl[] = { + QMP_PHY_INIT_CFG(QSERDES_COM_SYSCLK_EN_SEL, 0x14), + QMP_PHY_INIT_CFG(QSERDES_COM_BIAS_EN_CLKBUFLR_EN, 0x08), + QMP_PHY_INIT_CFG(QSERDES_COM_CLK_SELECT, 0x30), + QMP_PHY_INIT_CFG(QSERDES_COM_SYS_CLK_CTRL, 0x06), + QMP_PHY_INIT_CFG(QSERDES_COM_RESETSM_CNTRL, 0x00), + QMP_PHY_INIT_CFG(QSERDES_COM_RESETSM_CNTRL2, 0x08), + QMP_PHY_INIT_CFG(QSERDES_COM_BG_TRIM, 0x0f), + QMP_PHY_INIT_CFG(QSERDES_COM_SVS_MODE_CLK_SEL, 0x01), + QMP_PHY_INIT_CFG(QSERDES_COM_HSCLK_SEL, 0x00), + QMP_PHY_INIT_CFG(QSERDES_COM_DEC_START_MODE0, 0x82), + QMP_PHY_INIT_CFG(QSERDES_COM_DIV_FRAC_START1_MODE0, 0x55), + QMP_PHY_INIT_CFG(QSERDES_COM_DIV_FRAC_START2_MODE0, 0x55), + QMP_PHY_INIT_CFG(QSERDES_COM_DIV_FRAC_START3_MODE0, 0x03), + QMP_PHY_INIT_CFG(QSERDES_COM_CP_CTRL_MODE0, 0x0b), + QMP_PHY_INIT_CFG(QSERDES_COM_PLL_RCTRL_MODE0, 0x16), + QMP_PHY_INIT_CFG(QSERDES_COM_PLL_CCTRL_MODE0, 0x28), + QMP_PHY_INIT_CFG(QSERDES_COM_INTEGLOOP_GAIN0_MODE0, 0x80), + QMP_PHY_INIT_CFG(QSERDES_COM_INTEGLOOP_GAIN1_MODE0, 0x00), + QMP_PHY_INIT_CFG(QSERDES_COM_CORECLK_DIV, 0x0a), + QMP_PHY_INIT_CFG(QSERDES_COM_LOCK_CMP1_MODE0, 0x15), + QMP_PHY_INIT_CFG(QSERDES_COM_LOCK_CMP2_MODE0, 0x34), + QMP_PHY_INIT_CFG(QSERDES_COM_LOCK_CMP3_MODE0, 0x00), + QMP_PHY_INIT_CFG(QSERDES_COM_LOCK_CMP_EN, 0x00), + QMP_PHY_INIT_CFG(QSERDES_COM_CORE_CLK_EN, 0x00), + QMP_PHY_INIT_CFG(QSERDES_COM_LOCK_CMP_CFG, 0x00), + QMP_PHY_INIT_CFG(QSERDES_COM_VCO_TUNE_MAP, 0x00), + QMP_PHY_INIT_CFG(QSERDES_COM_BG_TIMER, 0x0a), + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_EN_CENTER, 0x01), + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_PER1, 0x31), + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_PER2, 0x01), + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_ADJ_PER1, 0x00), + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_ADJ_PER2, 0x00), + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_STEP_SIZE1, 0xde), + QMP_PHY_INIT_CFG(QSERDES_COM_SSC_STEP_SIZE2, 0x07), + QMP_PHY_INIT_CFG(QSERDES_COM_PLL_IVCO, 0x0f), + QMP_PHY_INIT_CFG(QSERDES_COM_CMN_CONFIG, 0x06), + QMP_PHY_INIT_CFG(QSERDES_COM_INTEGLOOP_INITVAL, 0x80), + QMP_PHY_INIT_CFG(QSERDES_COM_BIAS_EN_CTRL_BY_PSM, 0x01), +}; + +static const struct qmp_phy_init_tbl qcm2290_usb3_tx_tbl[] = { + QMP_PHY_INIT_CFG(QSERDES_V3_TX_HIGHZ_DRVR_EN, 0x10), + QMP_PHY_INIT_CFG(QSERDES_V3_TX_RCV_DETECT_LVL_2, 0x12), + QMP_PHY_INIT_CFG(QSERDES_V3_TX_LANE_MODE_1, 0xc6), + QMP_PHY_INIT_CFG(QSERDES_V3_TX_RES_CODE_LANE_OFFSET_TX, 0x00), + QMP_PHY_INIT_CFG(QSERDES_V3_TX_RES_CODE_LANE_OFFSET_RX, 0x00), +}; + +static const struct qmp_phy_init_tbl qcm2290_usb3_rx_tbl[] = { + QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_FASTLOCK_FO_GAIN, 0x0b), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_PI_CONTROLS, 0x00), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_FASTLOCK_COUNT_LOW, 0x00), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_FASTLOCK_COUNT_HIGH, 0x00), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_FO_GAIN, 0x0a), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_SO_GAIN, 0x06), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_UCDR_SO_SATURATION_AND_ENABLE, 0x75), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_RX_EQU_ADAPTOR_CNTRL2, 0x02), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_RX_EQU_ADAPTOR_CNTRL3, 0x4e), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_RX_EQU_ADAPTOR_CNTRL4, 0x18), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_RX_EQ_OFFSET_ADAPTOR_CNTRL1, 0x77), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_RX_OFFSET_ADAPTOR_CNTRL2, 0x80), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_VGA_CAL_CNTRL2, 0x0a), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_SIGDET_CNTRL, 0x03), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_SIGDET_DEGLITCH_CNTRL, 0x16), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_SIGDET_ENABLES, 0x00), + QMP_PHY_INIT_CFG(QSERDES_V3_RX_RX_MODE_00, 0x00), +}; + +static const struct qmp_phy_init_tbl qcm2290_usb3_pcs_tbl[] = { + QMP_PHY_INIT_CFG(QPHY_V3_PCS_TXMGN_V0, 0x9f), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_TXDEEMPH_M6DB_V0, 0x17), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_TXDEEMPH_M3P5DB_V0, 0x0f), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_FLL_CNTRL2, 0x83), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_FLL_CNTRL1, 0x02), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_FLL_CNT_VAL_L, 0x09), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_FLL_CNT_VAL_H_TOL, 0xa2), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_FLL_MAN_CODE, 0x85), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_LOCK_DETECT_CONFIG1, 0xd1), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_LOCK_DETECT_CONFIG2, 0x1f), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_LOCK_DETECT_CONFIG3, 0x47), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_RXEQTRAINING_WAIT_TIME, 0x75), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_RXEQTRAINING_RUN_TIME, 0x13), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_LFPS_TX_ECSTART_EQTLOCK, 0x86), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_PWRUP_RESET_DLY_TIME_AUXCLK, 0x04), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_TSYNC_RSYNC_TIME, 0x44), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_RCVR_DTCT_DLY_P1U2_L, 0xe7), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_RCVR_DTCT_DLY_P1U2_H, 0x03), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_RCVR_DTCT_DLY_U3_L, 0x40), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_RCVR_DTCT_DLY_U3_H, 0x00), + QMP_PHY_INIT_CFG(QPHY_V3_PCS_RX_SIGDET_LVL, 0x88), +}; + struct qmp_phy; /* struct qmp_phy_cfg - per-PHY initialization config */ @@ -2995,6 +3100,10 @@ static const char * const qmp_v4_sdx55_usbphy_clk_l[] = { "aux", "cfg_ahb", "ref" }; +static const char * const qcm2290_usb3phy_clk_l[] = { + "cfg_ahb", "ref", "com_aux", +}; + /* list of resets */ static const char * const msm8996_pciephy_reset_l[] = { "phy", "common", "cfg", @@ -3008,6 +3117,10 @@ static const char * const sc7180_usb3phy_reset_l[] = { "phy", }; +static const char * const qcm2290_usb3phy_reset_l[] = { + "phy_phy", "phy", +}; + static const char * const sdm845_pciephy_reset_l[] = { "phy", }; @@ -3974,6 +4087,33 @@ static const struct qmp_phy_cfg sm8350_usb3_uniphy_cfg = { .pwrdn_delay_max = POWER_DOWN_DELAY_US_MAX, }; +static const struct qmp_phy_cfg qcm2290_usb3phy_cfg = { + .type = PHY_TYPE_USB3, + .nlanes = 1, + + .serdes_tbl = qcm2290_usb3_serdes_tbl, + .serdes_tbl_num = ARRAY_SIZE(qcm2290_usb3_serdes_tbl), + .tx_tbl = qcm2290_usb3_tx_tbl, + .tx_tbl_num = ARRAY_SIZE(qcm2290_usb3_tx_tbl), + .rx_tbl = qcm2290_usb3_rx_tbl, + .rx_tbl_num = ARRAY_SIZE(qcm2290_usb3_rx_tbl), + .pcs_tbl = qcm2290_usb3_pcs_tbl, + .pcs_tbl_num = ARRAY_SIZE(qcm2290_usb3_pcs_tbl), + .clk_list = qcm2290_usb3phy_clk_l, + .num_clks = ARRAY_SIZE(qcm2290_usb3phy_clk_l), + .reset_list = qcm2290_usb3phy_reset_l, + .num_resets = ARRAY_SIZE(qcm2290_usb3phy_reset_l), + .vreg_list = qmp_phy_vreg_l, + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l), + .regs = qcm2290_usb3phy_regs_layout, + + .start_ctrl = SERDES_START | PCS_START, + .pwrdn_ctrl = SW_PWRDN, + .phy_status = PHYSTATUS, + + .is_dual_lane_phy = true, +}; + static void qcom_qmp_phy_configure_lane(void __iomem *base, const unsigned int *regs, const struct qmp_phy_init_tbl tbl[], @@ -5613,6 +5753,9 @@ static const struct of_device_id qcom_qmp_phy_of_match_table[] = { }, { .compatible = "qcom,sm8350-qmp-usb3-uni-phy", .data = &sm8350_usb3_uniphy_cfg, + }, { + .compatible = "qcom,qcm2290-qmp-usb3-phy", + .data = &qcm2290_usb3phy_cfg, }, { }, }; diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.h b/drivers/phy/qualcomm/phy-qcom-qmp.h index bebeac2c091c..e15f461065bb 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.h +++ b/drivers/phy/qualcomm/phy-qcom-qmp.h @@ -169,6 +169,7 @@ #define QSERDES_COM_BIAS_EN_CTRL_BY_PSM 0x0a8 #define QSERDES_COM_SYSCLK_EN_SEL 0x0ac #define QSERDES_COM_RESETSM_CNTRL 0x0b4 +#define QSERDES_COM_RESETSM_CNTRL2 0x0b8 #define QSERDES_COM_RESTRIM_CTRL 0x0bc #define QSERDES_COM_RESCODE_DIV_NUM 0x0c4 #define QSERDES_COM_LOCK_CMP_EN 0x0c8 @@ -181,6 +182,7 @@ #define QSERDES_COM_DIV_FRAC_START1_MODE1 0x0e8 #define QSERDES_COM_DIV_FRAC_START2_MODE1 0x0ec #define QSERDES_COM_DIV_FRAC_START3_MODE1 0x0f0 +#define QSERDES_COM_INTEGLOOP_INITVAL 0x100 #define QSERDES_COM_INTEGLOOP_GAIN0_MODE0 0x108 #define QSERDES_COM_INTEGLOOP_GAIN1_MODE0 0x10c #define QSERDES_COM_INTEGLOOP_GAIN0_MODE1 0x110 -- 2.17.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] Add QCM2290 USB3 PHY support 2021-09-27 6:48 [PATCH 0/2] Add QCM2290 USB3 PHY support Shawn Guo 2021-09-27 6:48 ` [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY Shawn Guo 2021-09-27 6:48 ` [PATCH 2/2] phy: qcom-qmp: Add QCM2290 USB3 PHY support Shawn Guo @ 2021-10-05 7:50 ` Vinod Koul 2 siblings, 0 replies; 7+ messages in thread From: Vinod Koul @ 2021-10-05 7:50 UTC (permalink / raw) To: Shawn Guo Cc: Bjorn Andersson, Rob Herring, Loic Poulain, linux-phy, devicetree, linux-arm-msm, linux-kernel On 27-09-21, 14:48, Shawn Guo wrote: > The series adds support for USB3 PHY found on QCM2290 SoC. Applied, thanks -- ~Vinod ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-10-05 7:50 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-09-27 6:48 [PATCH 0/2] Add QCM2290 USB3 PHY support Shawn Guo 2021-09-27 6:48 ` [PATCH 1/2] dt-bindings: phy: qcom,qmp: Add QCM2290 USB3 PHY Shawn Guo 2021-09-27 12:23 ` Rob Herring 2021-10-01 8:19 ` Vinod Koul 2021-10-04 18:14 ` Rob Herring 2021-09-27 6:48 ` [PATCH 2/2] phy: qcom-qmp: Add QCM2290 USB3 PHY support Shawn Guo 2021-10-05 7:50 ` [PATCH 0/2] " Vinod Koul
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).