* [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select
@ 2021-07-27 16:13 Marek Vasut
2021-08-02 20:53 ` Rob Herring
2021-10-05 0:03 ` Laurent Pinchart
0 siblings, 2 replies; 4+ messages in thread
From: Marek Vasut @ 2021-07-27 16:13 UTC (permalink / raw)
To: dri-devel
Cc: Marek Vasut, Laurent Pinchart, Rob Herring, Sam Ravnborg,
devicetree
Decoder input LVDS format is a property of the decoder chip or even
its strapping. Add DT property data-mapping the same way lvds-panel
does, to define the LVDS data mapping.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org
To: dri-devel@lists.freedesktop.org
---
V2: - Use allOf
- Move the data-mapping to endpoint
V3: - Rebase on V2 submitted a while ago, reinstate changelog
- Drop the allOf and un-rebase on previous pclk patch
V4: - port@1, remove $ref: /schemas/graph.yaml#/properties/port and
add $ref: /schemas/graph.yaml#/$defs/port-base
---
.../bindings/display/bridge/lvds-codec.yaml | 33 ++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
index 304a1367faaa7..c0400c60f272a 100644
--- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
@@ -55,11 +55,26 @@ properties:
For LVDS decoders, port 0 is the LVDS input
port@1:
- $ref: /schemas/graph.yaml#/properties/port
+ $ref: /schemas/graph.yaml#/$defs/port-base
description: |
For LVDS encoders, port 1 is the LVDS output
For LVDS decoders, port 1 is the parallel output
+ properties:
+ endpoint:
+ $ref: /schemas/media/video-interfaces.yaml#
+ unevaluatedProperties: false
+
+ properties:
+ data-mapping:
+ enum:
+ - jeida-18
+ - jeida-24
+ - vesa-24
+ description: |
+ The color signals mapping order. See details in
+ Documentation/devicetree/bindings/display/panel/lvds.yaml
+
required:
- port@0
- port@1
@@ -71,6 +86,22 @@ properties:
power-supply: true
+if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: lvds-decoder
+then:
+ properties:
+ ports:
+ properties:
+ port@1:
+ properties:
+ endpoint:
+ properties:
+ data-mapping: false
+
required:
- compatible
- ports
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select
2021-07-27 16:13 [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select Marek Vasut
@ 2021-08-02 20:53 ` Rob Herring
2021-10-05 0:03 ` Laurent Pinchart
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-08-02 20:53 UTC (permalink / raw)
To: Marek Vasut
Cc: Laurent Pinchart, dri-devel, devicetree, Sam Ravnborg,
Rob Herring
On Tue, 27 Jul 2021 18:13:56 +0200, Marek Vasut wrote:
> Decoder input LVDS format is a property of the decoder chip or even
> its strapping. Add DT property data-mapping the same way lvds-panel
> does, to define the LVDS data mapping.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> V2: - Use allOf
> - Move the data-mapping to endpoint
> V3: - Rebase on V2 submitted a while ago, reinstate changelog
> - Drop the allOf and un-rebase on previous pclk patch
> V4: - port@1, remove $ref: /schemas/graph.yaml#/properties/port and
> add $ref: /schemas/graph.yaml#/$defs/port-base
> ---
> .../bindings/display/bridge/lvds-codec.yaml | 33 ++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select
2021-07-27 16:13 [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select Marek Vasut
2021-08-02 20:53 ` Rob Herring
@ 2021-10-05 0:03 ` Laurent Pinchart
2021-10-05 0:11 ` Laurent Pinchart
1 sibling, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2021-10-05 0:03 UTC (permalink / raw)
To: Marek Vasut; +Cc: dri-devel, Rob Herring, Sam Ravnborg, devicetree
Hi Marek,
Thank you for the patch.
On Tue, Jul 27, 2021 at 06:13:56PM +0200, Marek Vasut wrote:
> Decoder input LVDS format is a property of the decoder chip or even
> its strapping. Add DT property data-mapping the same way lvds-panel
> does, to define the LVDS data mapping.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
And all my apologies for the delay.
> ---
> V2: - Use allOf
> - Move the data-mapping to endpoint
> V3: - Rebase on V2 submitted a while ago, reinstate changelog
> - Drop the allOf and un-rebase on previous pclk patch
> V4: - port@1, remove $ref: /schemas/graph.yaml#/properties/port and
> add $ref: /schemas/graph.yaml#/$defs/port-base
> ---
> .../bindings/display/bridge/lvds-codec.yaml | 33 ++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> index 304a1367faaa7..c0400c60f272a 100644
> --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> @@ -55,11 +55,26 @@ properties:
> For LVDS decoders, port 0 is the LVDS input
>
> port@1:
> - $ref: /schemas/graph.yaml#/properties/port
> + $ref: /schemas/graph.yaml#/$defs/port-base
> description: |
> For LVDS encoders, port 1 is the LVDS output
> For LVDS decoders, port 1 is the parallel output
>
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-mapping:
> + enum:
> + - jeida-18
> + - jeida-24
> + - vesa-24
> + description: |
> + The color signals mapping order. See details in
> + Documentation/devicetree/bindings/display/panel/lvds.yaml
> +
> required:
> - port@0
> - port@1
> @@ -71,6 +86,22 @@ properties:
>
> power-supply: true
>
> +if:
> + not:
> + properties:
> + compatible:
> + contains:
> + const: lvds-decoder
> +then:
> + properties:
> + ports:
> + properties:
> + port@1:
> + properties:
> + endpoint:
> + properties:
> + data-mapping: false
> +
> required:
> - compatible
> - ports
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select
2021-10-05 0:03 ` Laurent Pinchart
@ 2021-10-05 0:11 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2021-10-05 0:11 UTC (permalink / raw)
To: Marek Vasut; +Cc: dri-devel, Rob Herring, Sam Ravnborg, devicetree
On Tue, Oct 05, 2021 at 03:03:40AM +0300, Laurent Pinchart wrote:
> Hi Marek,
>
> Thank you for the patch.
>
> On Tue, Jul 27, 2021 at 06:13:56PM +0200, Marek Vasut wrote:
> > Decoder input LVDS format is a property of the decoder chip or even
> > its strapping. Add DT property data-mapping the same way lvds-panel
> > does, to define the LVDS data mapping.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Sam Ravnborg <sam@ravnborg.org>
> > Cc: devicetree@vger.kernel.org
> > To: dri-devel@lists.freedesktop.org
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I think I have to retract this, see below :-(
> And all my apologies for the delay.
>
> > ---
> > V2: - Use allOf
> > - Move the data-mapping to endpoint
> > V3: - Rebase on V2 submitted a while ago, reinstate changelog
> > - Drop the allOf and un-rebase on previous pclk patch
> > V4: - port@1, remove $ref: /schemas/graph.yaml#/properties/port and
> > add $ref: /schemas/graph.yaml#/$defs/port-base
> > ---
> > .../bindings/display/bridge/lvds-codec.yaml | 33 ++++++++++++++++++-
> > 1 file changed, 32 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> > index 304a1367faaa7..c0400c60f272a 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> > @@ -55,11 +55,26 @@ properties:
> > For LVDS decoders, port 0 is the LVDS input
> >
> > port@1:
> > - $ref: /schemas/graph.yaml#/properties/port
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > description: |
> > For LVDS encoders, port 1 is the LVDS output
> > For LVDS decoders, port 1 is the parallel output
> >
> > + properties:
> > + endpoint:
> > + $ref: /schemas/media/video-interfaces.yaml#
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + data-mapping:
> > + enum:
> > + - jeida-18
> > + - jeida-24
> > + - vesa-24
> > + description: |
> > + The color signals mapping order. See details in
> > + Documentation/devicetree/bindings/display/panel/lvds.yaml
> > +
Shouldn't this be for port 0 ? For decoders, port 1 is the parallel
side, not the LVDS side.
With this fixed, you can retain the
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > required:
> > - port@0
> > - port@1
> > @@ -71,6 +86,22 @@ properties:
> >
> > power-supply: true
> >
> > +if:
> > + not:
> > + properties:
> > + compatible:
> > + contains:
> > + const: lvds-decoder
> > +then:
> > + properties:
> > + ports:
> > + properties:
> > + port@1:
> > + properties:
> > + endpoint:
> > + properties:
> > + data-mapping: false
> > +
> > required:
> > - compatible
> > - ports
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-05 0:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-27 16:13 [PATCH V4 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select Marek Vasut
2021-08-02 20:53 ` Rob Herring
2021-10-05 0:03 ` Laurent Pinchart
2021-10-05 0:11 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).