From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82861C433F5 for ; Tue, 12 Oct 2021 17:04:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69D5B60EDF for ; Tue, 12 Oct 2021 17:04:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232231AbhJLRGN (ORCPT ); Tue, 12 Oct 2021 13:06:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231945AbhJLRGN (ORCPT ); Tue, 12 Oct 2021 13:06:13 -0400 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B250C061745 for ; Tue, 12 Oct 2021 10:04:11 -0700 (PDT) Received: by mail-ot1-x333.google.com with SMTP id r43-20020a05683044ab00b0054716b40005so176399otv.4 for ; Tue, 12 Oct 2021 10:04:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Gf0L13uSii7MojEsnWksglO0xsvhFpJcmZAlnq3Pg+E=; b=esGdid55ZR9bCKI/QbCUWRXJbIODKcncDyBVDLpTIC30LQz09Agm2+Dtwr0C5okmdb ctCca3LEC3jh5MJESKccL8D+yJdnQRdq+/BsuKUUCXLTp4lJTPq9dV8nX72MUobG0Ku0 5cBZFrh0FCPNUoYZ322S58iUU+03vU33dLDT0M6s4hRVG11s9kOGDOQ7FPuYeo7JFnvc z3NFSmzQT6XmO4MQyTTNzXSp4l/IBkWpEbGyreM/U5exAQdwieALtgTRx5ZYgbCz75VR +xXgPz9g/CGK5dhRAnUUPWcVxjEQlMbZ3c/VTB66SnlaHlkRDu0cg3kIPUAFo1nnKYDK l/iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Gf0L13uSii7MojEsnWksglO0xsvhFpJcmZAlnq3Pg+E=; b=pX1hG2zw29W9zXmpsLz5xK4+QbeaveTMstMnhyKwsEZbGFo/Qf+8Vcab8R9kkvdwqD TcgcKYSkw33jpUYD1S7sn5ivklNeWuPbg7P+08CmB4fK5uwOSowqKLVgiWN1v7Rk4ntE CwBZNgY3WiCnQGUKwnoihvZ7QYUExvjqj2odpkVPO4FKxCQ8bCFH55DEVU8NFXZKyOpL ofXgeDI3xlBi3gAr8nflCWnTJ7B6CN4D3NEVIghN+J2hGPSm7G3C0ypbCjCeAUWF+NdH JrDqD0SU9i+NXDSqGX/TlLlRRBBhfMviyhpHCx7EU3l48JSoAwtbNWH5VqQwmyE5aD1H boTw== X-Gm-Message-State: AOAM533S9VxeBIAzFhJPrQOYTFMXbgoKUR6oWFyKR71Maw5WRAzuW8rF Aa458U/dElR0t74quuPT0p0nhhEa5Dp5xA== X-Google-Smtp-Source: ABdhPJz21Dp7s6QAAqXmbuotHmAyoTENKlHT9ql5SjsNnd3exHtLWbGEeHfu1fakREawJUYAyRg0JA== X-Received: by 2002:a9d:4f1a:: with SMTP id d26mr25662931otl.65.1634058250501; Tue, 12 Oct 2021 10:04:10 -0700 (PDT) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id h26sm905877oov.28.2021.10.12.10.04.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 10:04:10 -0700 (PDT) Date: Tue, 12 Oct 2021 12:04:08 -0500 From: Bjorn Andersson To: Lee Jones Cc: Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mfd: qcom-spmi-pmic: Document eight more PMICs to binding Message-ID: References: <20211005024812.2038249-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 12 Oct 09:46 CDT 2021, Lee Jones wrote: > On Mon, 04 Oct 2021, Bjorn Andersson wrote: > > > Update the binding with eitght more SPMI PMIC compatibles found in the > > Spell check. > Bummer... > > PMIC info list in the Qualcomm socinfo driver. > > > > Signed-off-by: Bjorn Andersson > > --- > > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > index 5ef79bf3d035..1d2b5f067556 100644 > > --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt > > @@ -29,6 +29,8 @@ Required properties: > > "qcom,pm8916", > > "qcom,pm8004", > > "qcom,pm8909", > > + "qcom,pm8028", > > + "qcom,pm8901", > > "qcom,pm8950", > > "qcom,pmi8950", > > "qcom,pm8998", > > @@ -38,6 +40,12 @@ Required properties: > > "qcom,pmk8350", > > "qcom,pm7325", > > "qcom,pmr735a", > > + "qcom,pm8150", > > + "qcom,pm8150l", > > + "qcom,pm8150b", > > + "qcom,pmk8002", > > + "qcom,pm8150c", > > + "qcom,smb2351", > > or generalized "qcom,spmi-pmic". > > - reg: Specifies the SPMI USID slave address for this device. > > For more information see: > > Is there any reason why these can't be in lexicographical order? > Definitely not, both this list and the list compatible list in the driver would be better of sorted. I just didn't want to sort and add the entries in a single commit. Do you want me to respin this, adding two patches that sort the elements? Or will you fix my awesome spelling of 8 above and I send you the patches that shuffles the entries? Thanks, Bjorn > -- > Lee Jones [?????????] > Senior Technical Lead - Developer Services > Linaro.org ??? Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog