From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13E9BC433EF for ; Wed, 13 Oct 2021 07:23:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3F3D604DA for ; Wed, 13 Oct 2021 07:23:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229644AbhJMHZz (ORCPT ); Wed, 13 Oct 2021 03:25:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:50338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229548AbhJMHZz (ORCPT ); Wed, 13 Oct 2021 03:25:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 57620604DA; Wed, 13 Oct 2021 07:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634109832; bh=8tW3jrUtGh8D9IU8h+F9Q4KrLn2sM5xgpjJKt7sTuJU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ajPZjsQOgWjU9UI0nm93R3TbZ3+CwaymKKRi5sOwoCNnFUE6AiOPWN9C1kk/PBjNp z8Rz7KnYTpREYRz7yeV2viNAYvG02to5NL46z9RFaCnfseCNL7nC5qh02lVDV7yzI6 tGgXvlSXX6UND33vElSheIYmPKBHXkZFe4ktHNmXHjkJd2i0zjx1aHZmsI01nPFsR3 v2qrrd0tKpfCigGK8phCGe5w73CB1thoE0vy4bTspR+Jq5Fmg7/9F2yR+rHr7P2k7D B7diX5icAa4X1btgKmRvKNiZAyphCNaZx335rQaJ/pQeJOC/Jn8+LE8RtOWSC9JfxE /BZdA79qSTX5Q== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1maYc2-0005xc-SY; Wed, 13 Oct 2021 09:23:43 +0200 Date: Wed, 13 Oct 2021 09:23:42 +0200 From: Johan Hovold To: Drew Fustini Cc: Benoit Cousson , Dave Gerlach , Keerthy , Tony Lindgren , Rob Herring , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: am335x: Add rtc node as system-power-controller Message-ID: References: <20211012191311.879838-1-dfustini@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211012191311.879838-1-dfustini@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Oct 12, 2021 at 12:13:12PM -0700, Drew Fustini wrote: > From: Keerthy > > PMIC_PWR_EN pin of RTC on am335x-evm, bone, and boneblack is connected to > PMIC on board, so flag rtc node as system-power-controller to allow > software to poweroff boards. The "system-power-controller" property is already set in bone-common.dtsi since 2876cc4a773c ("ARM: dts: Move most of am335x-boneblack.dts to am335x-boneblack-common.dtsi") so this probably only affects am335x-evm and that should be reflected in the commit message. Also, should you now remove the property from boneblack-common? Or just add it to am335x-evm instead? > Signed-off-by: Dave Gerlach > Signed-off-by: Keerthy > Signed-off-by: Drew Fustini > --- > arch/arm/boot/dts/am335x-bone-common.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi > index 0ccdc7cd463b..56ae5095a5b8 100644 > --- a/arch/arm/boot/dts/am335x-bone-common.dtsi > +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi > @@ -399,6 +399,7 @@ &sham { > &rtc { > clocks = <&clk_32768_ck>, <&clk_24mhz_clkctrl AM3_CLK_24MHZ_CLKDIV32K_CLKCTRL 0>; > clock-names = "ext-clk", "int-clk"; > + system-power-controller; > }; > > &pruss_tm { Johan