From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4595DC433FE for ; Wed, 13 Oct 2021 12:24:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D7C760E09 for ; Wed, 13 Oct 2021 12:24:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232491AbhJMM0z (ORCPT ); Wed, 13 Oct 2021 08:26:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:34330 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbhJMM0z (ORCPT ); Wed, 13 Oct 2021 08:26:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AF6A60F23; Wed, 13 Oct 2021 12:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1634127892; bh=4s6wU6xVKQAR878cEXhPsqNrnWGlU/+dyX5KTUREZ18=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S4umREiHN43ck0bJtS5IRQc0Hf0stWqeWleSpMWn3iSIeP/bdGO8xsT0+JWIxLs+N z7t0n7C+46wOreMyY5MtU9w9c1d+JcnbAnT6YWDcQQr6BtwS4UJZEPBRKt6KlwFZfz T++70qYJgZK6yVJod1zvCaGaTM2uPd56fvopHfeg= Date: Wed, 13 Oct 2021 14:24:49 +0200 From: Greg KH To: Geert Uytterhoeven Cc: Christian Gromm , Rob Herring , Nikita Yushchenko , linux-staging@lists.linux.dev, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 23/28] staging: most: dim2: use device tree Message-ID: References: <1525772716-15742-1-git-send-email-christian.gromm@microchip.com> <1525772716-15742-24-git-send-email-christian.gromm@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Oct 12, 2021 at 08:14:14PM +0200, Geert Uytterhoeven wrote: > Hi Christian, Greg, > > CC devicetree, linux-renesas-soc > > On Tue, 8 May 2018, Christian Gromm wrote: > > This patch removes the dependency to platform specific source files > > that do platform specific initialization and supply the IRQ number. > > Instead DT code is added > > > > Signed-off-by: Christian Gromm > > This patch bypassed review by the DT people, and ended up in v4.18 as > commit 21e57ff086056c01 ("staging: most: dim2: use device tree"). Yeah, staging-only dt changes are not usually run by the dt maintainers. > > > --- a/drivers/staging/most/dim2/dim2.c > > +++ b/drivers/staging/most/dim2/dim2.c > > +static const struct of_device_id dim2_of_match[] = { > > + { > > + .compatible = "fsl,imx6q-mlb150", > > + .data = plat_data + FSL_MX6 > > + }, > > + { > > + .compatible = "renesas,mlp", > > + .data = plat_data + RCAR_H2 > > + }, > > + { > > + .compatible = "rcar,medialb-dim2", > > + .data = plat_data + RCAR_M3 > > + }, > > + { > > + .compatible = "xlnx,axi4-os62420_3pin-1.00.a", > > + }, > > + { > > + .compatible = "xlnx,axi4-os62420_6pin-1.00.a", > > + }, > > + {}, > > }; > > There are no documented DT bindings for this hardware block, nor any > upstream example users. Given some compatible values do not follow > standard practises (no idea about the other parts), it's very likely > these de facto bindings, and all their out-of-tree users, will have to > be changed. Great, fix the bindings and anything in-kernel here please. We don't care about out-of-kernel stuff for drivers/staging/ at all. thanks, greg k-h