From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77FA3C433FE for ; Thu, 14 Oct 2021 12:20:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51CF861167 for ; Thu, 14 Oct 2021 12:20:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229994AbhJNMW5 (ORCPT ); Thu, 14 Oct 2021 08:22:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229912AbhJNMW4 (ORCPT ); Thu, 14 Oct 2021 08:22:56 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8CE6C061570 for ; Thu, 14 Oct 2021 05:20:51 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id t9so25903121lfd.1 for ; Thu, 14 Oct 2021 05:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech-se.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=aEg5x4AVkWpua15/HSCgkbo2+YEZ1rQlTpXQmJEzzuo=; b=169eSdO2ZH1niKCmx2JEK+4FxPMfk1BlEb+fxhvErDgCejprPiohxLRmtExi1iv8W5 SSY0zQHMhxqCLpfqSm4YP/lobwjh/PvroFgWWss9FXQvO0OqMebfsv5KV5Usl99LT+jT ZoZFCw139Vb0/lZYd3yYDZJuAPCfdRQEFbkzjQQ4ySs7HoLlJpVvQ+w+UzDEqBIihFmF bBgdbKHh/U/VTJJ+zL/5S75kyz/u19ih8pSkkEfUerTbE4Cpo7lsuLnin64k9tZJSZJ0 oMp01NQmzpKCT2iUv9KYw4ICBsfYzrkuiiyG+5HcBuiY/z7ktNy/7g+BhlwpjOUt/o3X w55g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aEg5x4AVkWpua15/HSCgkbo2+YEZ1rQlTpXQmJEzzuo=; b=eIOn+pVQ/z7tN94mQ+TpcHlJwjkEeu9SjtUC/ROsDKg/gixEkJS8JTZxtBDBWLmTL+ qmY10FsXrZRDLjQfPeoDsKSz5cbfCsZWkgtP8EHnyylEHRFXYf4FTJu2UwdeZyWrPpuh bZX7KPZ8Nk1Q++n9pyHcP7WyOQnFEEYrU3RjsmD/zgJ0rjQvdIR1sji3sOxGrbgIrGeA pPkK83VAdl6SxYbbrQ2xmmvgMJ9Yt3E6PrkgD4S6XsUh5eyUmwol+Kken+8yw+YwXJoR LUymW7IEYovVGpLsEkx5ogsuPiGnqRES9bi33mern3MlIit5qn9vvk76jgLW9Y+k05nL vO/w== X-Gm-Message-State: AOAM5327f5CA+FKTPW7KqvmgKrq2RMdEwyWfBZUUqi/rL11xU9qzpJAb czK+X4paJlINymioUG08kM4KVqnssaElXCjL X-Google-Smtp-Source: ABdhPJzS8EfDArwZogyF4P6S9I0/5GID66hJd/miHaaK9jNkML45rZ5jFB3XImQRDX0iIXoGmm/qNw== X-Received: by 2002:ac2:5d4b:: with SMTP id w11mr4649427lfd.676.1634214048937; Thu, 14 Oct 2021 05:20:48 -0700 (PDT) Received: from localhost (h-46-59-88-219.A463.priv.bahnhof.se. [46.59.88.219]) by smtp.gmail.com with ESMTPSA id p9sm215447lfe.3.2021.10.14.05.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 05:20:48 -0700 (PDT) Date: Thu, 14 Oct 2021 14:20:47 +0200 From: Niklas =?iso-8859-1?Q?S=F6derlund?= To: Geert Uytterhoeven Cc: Rob Herring , Kieran Bingham , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Media Mailing List , Linux-Renesas Subject: Re: [PATCH] dt-bindings: adv748x: Convert bindings to json-schema Message-ID: References: <20211012183324.717975-1-niklas.soderlund+renesas@ragnatech.se> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Geert, On 2021-10-14 14:14:26 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Thu, Oct 14, 2021 at 1:39 PM Niklas Söderlund > wrote: > > On 2021-10-14 13:07:30 +0200, Geert Uytterhoeven wrote: > > > On Thu, Oct 14, 2021 at 12:48 PM Niklas Söderlund > > > wrote: > > > > On 2021-10-13 17:08:44 +0200, Geert Uytterhoeven wrote: > > > > > On Tue, Oct 12, 2021 at 8:48 PM Niklas Söderlund > > > > > wrote: > > > > > > Convert ADV748X analog video decoder documentation to json-schema. > > > > > > > > > --- /dev/null > > > > > > +++ b/Documentation/devicetree/bindings/media/i2c/adv748x.yaml > > > > > > > > > +allOf: > > > > > > + - if: > > > > > > + properties: > > > > > > + compatible: > > > > > > + contains: > > > > > > + const: adi,adv7481 > > > > > > + then: > > > > > > + properties: > > > > > > + interrupts: > > > > > > + minItems: 1 > > > > > > + maxItems: 3 > > > > > > + > > > > > > + interrupt-names: > > > > > > + minItems: 1 > > > > > > + items: > > > > > > + - enum: [ intrq1, intrq2, intrq3 ] > > > > > > + - enum: [ intrq1, intrq2, intrq3 ] > > > > > > + - enum: [ intrq1, intrq2, intrq3 ] > > > > > > > > > > They can really appear in any order? > > > > > > > > Yes, as not all interrupt lines may be wired up. It would be nice to > > > > enforce that intrq2 must come before intrq3 if both are wired but I'm > > > > not sure how to express that. > > > > > > You mean > > > > > > items: > > > - const: intrq1 > > > - const: intrq2 > > > - const: intrq3 > > > > Will this not enforce that if intrq2 is present intrq1 must be too? > > > > > > > > ? > > > > > > If the first two might be exchanged, you can still fix the last one: > > > > > > items: > > > - const: [ intrq1, intrq2 ] > > > - const: [ intrq1, intrq2 ] > > > - const: intrq3 > > > > Same here, will this not fail if only intrq3 is given? > > Right. And these combinations are all valid? Yes, there is two or three depending on model irq pins on the device itself and all, none or any combination of them could be wired up. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Regards, Niklas Söderlund