From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Joey Gouly <joey.gouly@arm.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Hector Martin <marcan@marcan.st>, Marc Zyngier <maz@kernel.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Sven Peter <sven@svenpeter.dev>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Kettenis <kettenis@openbsd.org>,
nd@arm.com, Stan Skowronek <stan@corellium.com>
Subject: Re: [PATCH v3 4/5] pinctrl: add pinctrl/GPIO driver for Apple SoCs
Date: Sat, 16 Oct 2021 14:07:31 -0400 [thread overview]
Message-ID: <YWsU48UwClC3QYzD@maud> (raw)
In-Reply-To: <20211016141839.45460-5-joey.gouly@arm.com>
> +static int apple_gpio_gpio_get_direction(struct gpio_chip *chip,
> + unsigned int offset)
> +{
> + struct apple_gpio_pinctrl *pctl = gpiochip_get_data(chip);
> + unsigned int reg = apple_gpio_get_reg(pctl, offset);
> +
> + return (FIELD_GET(REG_GPIOx_MODE, reg) == REG_GPIOx_OUT) ?
> + GPIO_LINE_DIRECTION_OUT :
> + GPIO_LINE_DIRECTION_IN;
> +}
Nit: weird spacing.
next prev parent reply other threads:[~2021-10-16 18:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 14:18 [PATCH v3 0/5] pinctrl/GPIO driver for Apple SoCs Joey Gouly
2021-10-16 14:18 ` [PATCH v3 1/5] gpio: Allow per-parent interrupt data Joey Gouly
2021-10-16 22:37 ` Linus Walleij
2021-11-04 15:30 ` Bartosz Golaszewski
2021-10-16 14:18 ` [PATCH v3 2/5] dt-bindings: pinctrl: add #interrupt-cells to apple,pinctrl Joey Gouly
2021-10-17 10:20 ` Sven Peter
2021-10-18 19:30 ` Rob Herring
2021-10-16 14:18 ` [PATCH v3 3/5] dt-bindings: pinctrl: Add apple,npins property " Joey Gouly
2021-10-18 19:30 ` Rob Herring
2021-10-16 14:18 ` [PATCH v3 4/5] pinctrl: add pinctrl/GPIO driver for Apple SoCs Joey Gouly
2021-10-16 18:07 ` Alyssa Rosenzweig [this message]
2021-10-16 19:00 ` Mark Kettenis
2021-10-16 22:57 ` Linus Walleij
2021-10-16 14:18 ` [PATCH v3 5/5] MAINTAINERS: add pinctrl-apple-gpio to ARM/APPLE MACHINE Joey Gouly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWsU48UwClC3QYzD@maud \
--to=alyssa@collabora.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=joey.gouly@arm.com \
--cc=kettenis@openbsd.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=nd@arm.com \
--cc=robh+dt@kernel.org \
--cc=stan@corellium.com \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).