From: Rob Herring <robh@kernel.org>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
kael_w@yeah.net, Frank Rowand <frowand.list@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] of/unittest: Add of_node_put() before return
Date: Wed, 20 Oct 2021 12:58:32 -0500 [thread overview]
Message-ID: <YXBYyM2f3vRb9676@robh.at.kernel.org> (raw)
In-Reply-To: <20211015082658.19005-1-wanjiabing@vivo.com>
On Fri, 15 Oct 2021 04:26:58 -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/of/unittest.c:3091:1-23: WARNING: Function
> for_each_child_of_node should have of_node_put() before return
>
> Early exits from for_each_child_of_node should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/of/unittest.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks!
prev parent reply other threads:[~2021-10-20 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 8:26 [PATCH] of/unittest: Add of_node_put() before return Wan Jiabing
2021-10-20 17:58 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXBYyM2f3vRb9676@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).