* [PATCH v2 2/4] mfd: qcom-spmi-pmic: Sort compatibles in the driver
2021-10-17 16:12 [PATCH v2 1/4] mfd: qcom-spmi-pmic: Sort the compatibles in the binding Bjorn Andersson
@ 2021-10-17 16:12 ` Bjorn Andersson
2021-10-21 11:44 ` Lee Jones
2021-10-17 16:12 ` [PATCH v2 3/4] mfd: qcom-spmi-pmic: Document ten more PMICs in the binding Bjorn Andersson
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Bjorn Andersson @ 2021-10-17 16:12 UTC (permalink / raw)
To: Lee Jones, Rob Herring; +Cc: linux-arm-msm, devicetree, linux-kernel
Sort the compatibles in the driver, to make it easier to validate that
the DT binding and driver are in sync.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Changes since v1:
- New patch
drivers/mfd/qcom-spmi-pmic.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
index a35d5cf16faa..8be07102a468 100644
--- a/drivers/mfd/qcom-spmi-pmic.c
+++ b/drivers/mfd/qcom-spmi-pmic.c
@@ -40,27 +40,27 @@
#define PM660_SUBTYPE 0x1B
static const struct of_device_id pmic_spmi_id_table[] = {
- { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE },
- { .compatible = "qcom,pm8941", .data = (void *)PM8941_SUBTYPE },
- { .compatible = "qcom,pm8841", .data = (void *)PM8841_SUBTYPE },
+ { .compatible = "qcom,pm660", .data = (void *)PM660_SUBTYPE },
+ { .compatible = "qcom,pm660l", .data = (void *)PM660L_SUBTYPE },
+ { .compatible = "qcom,pm8004", .data = (void *)PM8004_SUBTYPE },
+ { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE },
{ .compatible = "qcom,pm8019", .data = (void *)PM8019_SUBTYPE },
- { .compatible = "qcom,pm8226", .data = (void *)PM8226_SUBTYPE },
{ .compatible = "qcom,pm8110", .data = (void *)PM8110_SUBTYPE },
- { .compatible = "qcom,pma8084", .data = (void *)PMA8084_SUBTYPE },
- { .compatible = "qcom,pmi8962", .data = (void *)PMI8962_SUBTYPE },
- { .compatible = "qcom,pmd9635", .data = (void *)PMD9635_SUBTYPE },
- { .compatible = "qcom,pm8994", .data = (void *)PM8994_SUBTYPE },
- { .compatible = "qcom,pmi8994", .data = (void *)PMI8994_SUBTYPE },
- { .compatible = "qcom,pm8916", .data = (void *)PM8916_SUBTYPE },
- { .compatible = "qcom,pm8004", .data = (void *)PM8004_SUBTYPE },
+ { .compatible = "qcom,pm8226", .data = (void *)PM8226_SUBTYPE },
+ { .compatible = "qcom,pm8841", .data = (void *)PM8841_SUBTYPE },
{ .compatible = "qcom,pm8909", .data = (void *)PM8909_SUBTYPE },
+ { .compatible = "qcom,pm8916", .data = (void *)PM8916_SUBTYPE },
+ { .compatible = "qcom,pm8941", .data = (void *)PM8941_SUBTYPE },
{ .compatible = "qcom,pm8950", .data = (void *)PM8950_SUBTYPE },
- { .compatible = "qcom,pmi8950", .data = (void *)PMI8950_SUBTYPE },
+ { .compatible = "qcom,pm8994", .data = (void *)PM8994_SUBTYPE },
{ .compatible = "qcom,pm8998", .data = (void *)PM8998_SUBTYPE },
+ { .compatible = "qcom,pma8084", .data = (void *)PMA8084_SUBTYPE },
+ { .compatible = "qcom,pmd9635", .data = (void *)PMD9635_SUBTYPE },
+ { .compatible = "qcom,pmi8950", .data = (void *)PMI8950_SUBTYPE },
+ { .compatible = "qcom,pmi8962", .data = (void *)PMI8962_SUBTYPE },
+ { .compatible = "qcom,pmi8994", .data = (void *)PMI8994_SUBTYPE },
{ .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE },
- { .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE },
- { .compatible = "qcom,pm660l", .data = (void *)PM660L_SUBTYPE },
- { .compatible = "qcom,pm660", .data = (void *)PM660_SUBTYPE },
+ { .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE },
{ }
};
--
2.29.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 2/4] mfd: qcom-spmi-pmic: Sort compatibles in the driver
2021-10-17 16:12 ` [PATCH v2 2/4] mfd: qcom-spmi-pmic: Sort compatibles in the driver Bjorn Andersson
@ 2021-10-21 11:44 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2021-10-21 11:44 UTC (permalink / raw)
To: Bjorn Andersson; +Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel
On Sun, 17 Oct 2021, Bjorn Andersson wrote:
> Sort the compatibles in the driver, to make it easier to validate that
> the DT binding and driver are in sync.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v1:
> - New patch
>
> drivers/mfd/qcom-spmi-pmic.c | 30 +++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 3/4] mfd: qcom-spmi-pmic: Document ten more PMICs in the binding
2021-10-17 16:12 [PATCH v2 1/4] mfd: qcom-spmi-pmic: Sort the compatibles in the binding Bjorn Andersson
2021-10-17 16:12 ` [PATCH v2 2/4] mfd: qcom-spmi-pmic: Sort compatibles in the driver Bjorn Andersson
@ 2021-10-17 16:12 ` Bjorn Andersson
2021-10-21 11:45 ` Lee Jones
2021-10-17 16:12 ` [PATCH v2 4/4] mfd: qcom-spmi-pmic: Add missing PMICs supported by socinfo Bjorn Andersson
2021-10-21 11:44 ` [PATCH v2 1/4] mfd: qcom-spmi-pmic: Sort the compatibles in the binding Lee Jones
3 siblings, 1 reply; 8+ messages in thread
From: Bjorn Andersson @ 2021-10-17 16:12 UTC (permalink / raw)
To: Lee Jones, Rob Herring; +Cc: linux-arm-msm, devicetree, linux-kernel
Update the binding with eight more SPMI PMIC compatibles found in the
PMIC info list in the Qualcomm socinfo driver and add the two PM660
related PMICs supported by the SPMI PMIC driver but are missing from the
document.
Then remove the duplicate entry for pma8084.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Changes since v1:
- Rebased on top of sorting of entries
- Added the two PM660 related PMICs from the binding
- Dropped he duplicate pma8084 that showed up in the sort
.../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
index 67785b6d66e9..7a27c500ff63 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
@@ -15,14 +15,22 @@ each. A function can consume one or more of these fixed-size register regions.
Required properties:
- compatible: Should contain one of:
+ "qcom,pm660",
+ "qcom,pm660l",
"qcom,pm7325",
"qcom,pm8004",
"qcom,pm8005",
"qcom,pm8019",
+ "qcom,pm8028",
"qcom,pm8110",
+ "qcom,pm8150",
+ "qcom,pm8150b",
+ "qcom,pm8150c",
+ "qcom,pm8150l",
"qcom,pm8226",
"qcom,pm8350c",
"qcom,pm8841",
+ "qcom,pm8901",
"qcom,pm8909",
"qcom,pm8916",
"qcom,pm8941",
@@ -30,14 +38,15 @@ Required properties:
"qcom,pm8994",
"qcom,pm8998",
"qcom,pma8084",
- "qcom,pma8084",
"qcom,pmd9635",
"qcom,pmi8950",
"qcom,pmi8962",
"qcom,pmi8994",
"qcom,pmi8998",
+ "qcom,pmk8002",
"qcom,pmk8350",
"qcom,pmr735a",
+ "qcom,smb2351",
or generalized "qcom,spmi-pmic".
- reg: Specifies the SPMI USID slave address for this device.
For more information see:
--
2.29.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 3/4] mfd: qcom-spmi-pmic: Document ten more PMICs in the binding
2021-10-17 16:12 ` [PATCH v2 3/4] mfd: qcom-spmi-pmic: Document ten more PMICs in the binding Bjorn Andersson
@ 2021-10-21 11:45 ` Lee Jones
0 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2021-10-21 11:45 UTC (permalink / raw)
To: Bjorn Andersson; +Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel
On Sun, 17 Oct 2021, Bjorn Andersson wrote:
> Update the binding with eight more SPMI PMIC compatibles found in the
> PMIC info list in the Qualcomm socinfo driver and add the two PM660
> related PMICs supported by the SPMI PMIC driver but are missing from the
> document.
>
> Then remove the duplicate entry for pma8084.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v1:
> - Rebased on top of sorting of entries
> - Added the two PM660 related PMICs from the binding
> - Dropped he duplicate pma8084 that showed up in the sort
>
> .../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 4/4] mfd: qcom-spmi-pmic: Add missing PMICs supported by socinfo
2021-10-17 16:12 [PATCH v2 1/4] mfd: qcom-spmi-pmic: Sort the compatibles in the binding Bjorn Andersson
2021-10-17 16:12 ` [PATCH v2 2/4] mfd: qcom-spmi-pmic: Sort compatibles in the driver Bjorn Andersson
2021-10-17 16:12 ` [PATCH v2 3/4] mfd: qcom-spmi-pmic: Document ten more PMICs in the binding Bjorn Andersson
@ 2021-10-17 16:12 ` Bjorn Andersson
2021-10-21 11:45 ` Lee Jones
2021-10-21 11:44 ` [PATCH v2 1/4] mfd: qcom-spmi-pmic: Sort the compatibles in the binding Lee Jones
3 siblings, 1 reply; 8+ messages in thread
From: Bjorn Andersson @ 2021-10-17 16:12 UTC (permalink / raw)
To: Lee Jones, Rob Herring; +Cc: linux-arm-msm, devicetree, linux-kernel
The Qualcomm socinfo driver has eight more PMICs described, add these to
the SPMI PMIC driver as well.
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Changes since v1:
- Rebased on top of sorting of entries
drivers/mfd/qcom-spmi-pmic.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c
index 8be07102a468..1cacc00aa6c9 100644
--- a/drivers/mfd/qcom-spmi-pmic.c
+++ b/drivers/mfd/qcom-spmi-pmic.c
@@ -31,6 +31,8 @@
#define PM8916_SUBTYPE 0x0b
#define PM8004_SUBTYPE 0x0c
#define PM8909_SUBTYPE 0x0d
+#define PM8028_SUBTYPE 0x0e
+#define PM8901_SUBTYPE 0x0f
#define PM8950_SUBTYPE 0x10
#define PMI8950_SUBTYPE 0x11
#define PM8998_SUBTYPE 0x14
@@ -38,6 +40,13 @@
#define PM8005_SUBTYPE 0x18
#define PM660L_SUBTYPE 0x1A
#define PM660_SUBTYPE 0x1B
+#define PM8150_SUBTYPE 0x1E
+#define PM8150L_SUBTYPE 0x1f
+#define PM8150B_SUBTYPE 0x20
+#define PMK8002_SUBTYPE 0x21
+#define PM8009_SUBTYPE 0x24
+#define PM8150C_SUBTYPE 0x26
+#define SMB2351_SUBTYPE 0x29
static const struct of_device_id pmic_spmi_id_table[] = {
{ .compatible = "qcom,pm660", .data = (void *)PM660_SUBTYPE },
@@ -45,9 +54,15 @@ static const struct of_device_id pmic_spmi_id_table[] = {
{ .compatible = "qcom,pm8004", .data = (void *)PM8004_SUBTYPE },
{ .compatible = "qcom,pm8005", .data = (void *)PM8005_SUBTYPE },
{ .compatible = "qcom,pm8019", .data = (void *)PM8019_SUBTYPE },
+ { .compatible = "qcom,pm8028", .data = (void *)PM8028_SUBTYPE },
{ .compatible = "qcom,pm8110", .data = (void *)PM8110_SUBTYPE },
+ { .compatible = "qcom,pm8150", .data = (void *)PM8150_SUBTYPE },
+ { .compatible = "qcom,pm8150b", .data = (void *)PM8150B_SUBTYPE },
+ { .compatible = "qcom,pm8150c", .data = (void *)PM8150C_SUBTYPE },
+ { .compatible = "qcom,pm8150l", .data = (void *)PM8150L_SUBTYPE },
{ .compatible = "qcom,pm8226", .data = (void *)PM8226_SUBTYPE },
{ .compatible = "qcom,pm8841", .data = (void *)PM8841_SUBTYPE },
+ { .compatible = "qcom,pm8901", .data = (void *)PM8901_SUBTYPE },
{ .compatible = "qcom,pm8909", .data = (void *)PM8909_SUBTYPE },
{ .compatible = "qcom,pm8916", .data = (void *)PM8916_SUBTYPE },
{ .compatible = "qcom,pm8941", .data = (void *)PM8941_SUBTYPE },
@@ -60,6 +75,8 @@ static const struct of_device_id pmic_spmi_id_table[] = {
{ .compatible = "qcom,pmi8962", .data = (void *)PMI8962_SUBTYPE },
{ .compatible = "qcom,pmi8994", .data = (void *)PMI8994_SUBTYPE },
{ .compatible = "qcom,pmi8998", .data = (void *)PMI8998_SUBTYPE },
+ { .compatible = "qcom,pmk8002", .data = (void *)PMK8002_SUBTYPE },
+ { .compatible = "qcom,smb2351", .data = (void *)SMB2351_SUBTYPE },
{ .compatible = "qcom,spmi-pmic", .data = (void *)COMMON_SUBTYPE },
{ }
};
--
2.29.2
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 1/4] mfd: qcom-spmi-pmic: Sort the compatibles in the binding
2021-10-17 16:12 [PATCH v2 1/4] mfd: qcom-spmi-pmic: Sort the compatibles in the binding Bjorn Andersson
` (2 preceding siblings ...)
2021-10-17 16:12 ` [PATCH v2 4/4] mfd: qcom-spmi-pmic: Add missing PMICs supported by socinfo Bjorn Andersson
@ 2021-10-21 11:44 ` Lee Jones
3 siblings, 0 replies; 8+ messages in thread
From: Lee Jones @ 2021-10-21 11:44 UTC (permalink / raw)
To: Bjorn Andersson; +Cc: Rob Herring, linux-arm-msm, devicetree, linux-kernel
On Sun, 17 Oct 2021, Bjorn Andersson wrote:
> Create some order in the list of compatibles by sorting them.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changed since v1:
> - New patch
>
> .../bindings/mfd/qcom,spmi-pmic.txt | 30 +++++++++----------
> 1 file changed, 15 insertions(+), 15 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 8+ messages in thread