From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CBA7C4332F for ; Fri, 22 Oct 2021 17:21:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54D7460FBF for ; Fri, 22 Oct 2021 17:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233820AbhJVRXS (ORCPT ); Fri, 22 Oct 2021 13:23:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233630AbhJVRXQ (ORCPT ); Fri, 22 Oct 2021 13:23:16 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAE74C061766 for ; Fri, 22 Oct 2021 10:20:58 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id o4so5869431oia.10 for ; Fri, 22 Oct 2021 10:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Z4mIXFa4iFtG0/3MwjffVdtreROCML6cO1oSaovl7kw=; b=XOzPRrO+Dvgdv3N4+FSroOWjBFonbuNYcEmpzvPV6UGjh253V/4q5E9p8PiTGIBpHC rOILz6x6sIFB9QWjRemrSUyUcvHTStC+p5kboTvkRdIwK4F07acGSnS6RUa+aq0CodDx 04hutEYEf4NNzk0mCmzM3/lVOITwnf8xljYzwwEhF06r5W2jIMvc+Zbh+ixBi/5ZjqIB 9g7HFYayHuHrepHGvKKOXbgp6yWBjT3e/mpUwRbb+43i9U2C37hUvL55kyhWd9gwwDsl I/8YdJzBjaDSHAKBgCLhb64AHVu3+pqDpdrNJjWI30WsyEQw9XefCACVP3kJpw4iaXTF U7pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Z4mIXFa4iFtG0/3MwjffVdtreROCML6cO1oSaovl7kw=; b=Cl8gbOebcU6kZ89ww27mhcgdneWlaUd2F7Yq873IDAZKzfDMUAeeFW6bcUqEwQ5Gw5 gVzh3CNfSIU6gnr/WmBbIvMzWBi6MdeIdP5/Dr9JQpu5uDvszpfuwUY1lGlbYwpCaZqL Ku1zHRqMPqHYqGf8X2JpwfOqho7We7BLpzFKdheocrgjQTl8zNX6DFthMprvk8FASoy0 GTa77jNyUEUKRqb8n46E/hQttGCQlL0IIlIpzXBBepcJxKwfIx4IEz5YJ80W0SpZFqJs +vvsop8WRmakX38JM1a6YYjwCvZ+cAnowl2rwOyZ1ts8Z3W/uvIlJMMZivAU82ZXFUxw H2/A== X-Gm-Message-State: AOAM531RyDi1AbS4+zZvqVaQcC4IXoi2+2RO1JQ4GMQotD2efOTcJqtR MaDolOUxxCm5zcNT6BFmwkXn7g== X-Google-Smtp-Source: ABdhPJyR2plvLY6BCo2Ofj58TKpqgSWaXCB+Dm622BxD1FqjVK5Fs30d1anipkQ7nPlZrg6E+bkBFw== X-Received: by 2002:a05:6808:188a:: with SMTP id bi10mr11093696oib.9.1634923255751; Fri, 22 Oct 2021 10:20:55 -0700 (PDT) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id c37sm1871895otu.36.2021.10.22.10.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Oct 2021 10:20:55 -0700 (PDT) Date: Fri, 22 Oct 2021 10:22:37 -0700 From: Bjorn Andersson To: Satya Priya Cc: Pavel Machek , Rob Herring , Andy Gross , Matthias Kaehlcke , swboyd@chromium.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V2 2/3] leds: Add pm8350c support to Qualcomm LPG driver Message-ID: References: <1634640531-15813-1-git-send-email-skakit@codeaurora.org> <1634640531-15813-3-git-send-email-skakit@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1634640531-15813-3-git-send-email-skakit@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue 19 Oct 03:48 PDT 2021, Satya Priya wrote: > From: satya priya > > Add pm8350c compatible and lpg_data to the driver. > > Signed-off-by: satya priya > Reviewed-by: Matthias Kaehlcke > --- > Changes in V2: > - Added const for lpg_channel_data[] struct. > > drivers/leds/rgb/leds-qcom-lpg.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c > index 45ef4ec..99235af 100644 > --- a/drivers/leds/rgb/leds-qcom-lpg.c > +++ b/drivers/leds/rgb/leds-qcom-lpg.c > @@ -1275,9 +1275,19 @@ static const struct lpg_data pm8150l_lpg_data = { > }, > }; > > +static const struct lpg_data pm8350c_pwm_data = { > + .pwm_9bit_mask = BIT(2), > + > + .num_channels = 1, No, this should be 4. The fact that you only care about the first channel in your product should be reflected in the dts, not in the driver. Thanks, Bjorn > + .channels = (const struct lpg_channel_data[]) { > + { .base = 0xeb00 }, > + }, > +}; > + > static const struct of_device_id lpg_of_table[] = { > { .compatible = "qcom,pm8150b-lpg", .data = &pm8150b_lpg_data }, > { .compatible = "qcom,pm8150l-lpg", .data = &pm8150l_lpg_data }, > + { .compatible = "qcom,pm8350c-pwm", .data = &pm8350c_pwm_data }, > { .compatible = "qcom,pm8916-pwm", .data = &pm8916_pwm_data }, > { .compatible = "qcom,pm8941-lpg", .data = &pm8941_lpg_data }, > { .compatible = "qcom,pm8994-lpg", .data = &pm8994_lpg_data }, > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation >