From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4120CC433EF for ; Sun, 24 Oct 2021 03:54:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 17E1460FD8 for ; Sun, 24 Oct 2021 03:54:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231131AbhJXD4k (ORCPT ); Sat, 23 Oct 2021 23:56:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229794AbhJXD4k (ORCPT ); Sat, 23 Oct 2021 23:56:40 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 021E0C061764 for ; Sat, 23 Oct 2021 20:54:19 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id o204so10533840oih.13 for ; Sat, 23 Oct 2021 20:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RSVUv8wCLMR5NbP2KKxEFrNw99dgjbVZVt1xAWb2Dxo=; b=v7OcfIHbtTAqRffqGtqasqZdL3UmgRTpq/uaheUKyEz0T12NzQAsvzGbd4La/vjYYT 3pOD9gwJBlGkc8MPo45/eDPvKhoQG+5FYCdrHGlRexr4Sn68W1AouG+2Se+H02lwukMB QDb7ei+Vs6B6HZp9AtweSc61UXdBAYl6JaJX9ph/Q7tKmsrzWUjC/Gm+VdY7R/t3e4sp Now5vxNES/4poJKY919L0zXdgx9IGAU0wadt3cKTs1Uu4xmJ02oC3BeEMYcnS1Q6Hoqx VQBhcQvUz3PDhlsWshr8QYPSn4x0KE+RtieKATaoymphpxcXK8Ap/DPQ7EToZpE7OhGn dyWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RSVUv8wCLMR5NbP2KKxEFrNw99dgjbVZVt1xAWb2Dxo=; b=UrIdrNg4RZMrVtN/nts5aSohpfRFVxWpXP3ov0jwba+NpVV10Qw+GtQzxqumHzgNUw IDCYZn4dXL0dnUYLzqixpuU1+v9In3/S6xiWIIFuD8o9yo4eN5oC4E2P5s7nU3WsjISA pZxPzsE4MRNoRe+Z/q0Jm2Xa2tRFs/7LCfzOQYrYNis8lDzo4P+HzsB+KYPZkZt6OS/S 4jgjghe2rarb5mz9R5yqBxsfRtPMPR8EG+jld9vYDJv18C3FlKMA42a2dEmHFTKQX4WF jLe8xB4esAnDe4esNy3p/+kGxUNV2X7u6omMnP7y20MMfaY5o0tDDYz62Ch74wbLjftU 6UDg== X-Gm-Message-State: AOAM531PeMB8TylubwJvl+z8CyYBbs7GjmoTwZLxqh/bTKA8oQihhWbJ gG6MqQJAksBszzXX99WOD12ODCtSqqM08w== X-Google-Smtp-Source: ABdhPJztJiPTxtqDIWCiiZprKlfavD1GL89TgP/adgnPe7RRnQBmZoQZUNIsvCU6e0NF1TpOrN5C3g== X-Received: by 2002:a54:4f8f:: with SMTP id g15mr6518394oiy.169.1635047659265; Sat, 23 Oct 2021 20:54:19 -0700 (PDT) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id o2sm2650333otl.34.2021.10.23.20.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Oct 2021 20:54:18 -0700 (PDT) Date: Sat, 23 Oct 2021 22:54:16 -0500 From: Bjorn Andersson To: Doug Anderson Cc: satya priya , Vinod Koul , Matthias Kaehlcke , Stephen Boyd , Andy Gross , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , LKML Subject: Re: [PATCH] arm64: dts: qcom: pmk8350: Make RTC disabled by default; enable on sc7280-idp Message-ID: References: <20210929153553.1.Ib44c2ac967833d7a3f51452d44d15b7b8d23c1f0@changeid> <86b0d847ddf06c1b445f3dbac9c771a9@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon 18 Oct 16:45 CDT 2021, Doug Anderson wrote: > Bjorn, > > On Wed, Sep 29, 2021 at 9:00 PM wrote: > > > > On 2021-09-30 04:08, Douglas Anderson wrote: > > > The RTC on the pmk8350 is not useful on all boards. Some boards may > > > not provide backup power to the PMIC but might have another RTC on the > > > board that does have backup power. In this case it's better to not use > > > the RTC on the PMIC. > > > > > > At the moment, the only boards that includes this PMIC are sc7280-idp > > > and sc7280-idp2. On sc7280-idp I'm not aware of any other RTCs, but > > > sc7280-idp2 has a Chrome OS EC on it and this is intended to provide > > > the RTC for the AP. > > > > > > Let's do what we normally do for hardware that's not used by all > > > boards and set it to a default status of "disabled" and then enable it > > > on the boards that need it. > > > > > > NOTE: for sc7280-idp it's _possible_ we might also want to add > > > `allow-set-time;`. That could be the subject of a future patch if it > > > is indeed true. > > > > > > Signed-off-by: Douglas Anderson > > > --- > > > > > > > Reviewed-by: Satya Priya > > If you're still accepting patches for 5.16, it'd be keen if you'd > consider taking this one. Thanks! > I've picked the patch and hope to get it included in v5.16. I do however not understand why the commit message so clearly defines that the only device including pmk8350 is the sc7280 idp when the sm8350-mtp.dts contains the following line: #include "pmk8350.dtsi" Perhaps I'm missing something obvious, but I took the liberty of also enabling the RTC in the SM8350 MTP. Regards, Bjorn