[PATCH] arm64: dts: rockchip: disable USB type-c DisplayPort

[PATCH] arm64: dts: rockchip: disable USB type-c DisplayPort

[Jian-Hong Pan]

The cdn-dp sub driver probes the device failed on PINEBOOK Pro.

kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
kernel: cdn-dp: probe of fec00000.dp failed with error -22

Then, the device halts all of the DRM related device jobs. For example,
the operations: vop_component_ops, vop_component_ops and
rockchip_dp_component_ops cannot be bound to corresponding devices. So,
Xorg cannot find the correct DRM device.

The USB type-C DisplayPort does not work for now. So, disable the
DisplayPort node until the type-C phy work has been done.

Link: https://patchwork.kernel.org/patch/11794141/#23639877
Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
---
 arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 06d48338c836..d624c595c533 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -380,7 +380,7 @@ mains_charger: dc-charger {
 };
 
 &cdn_dp {
-	status = "okay";
+	status = "disabled";
 };
 
 &cpu_b0 {
-- 
2.28.0

Re: [PATCH] arm64: dts: rockchip: disable USB type-c DisplayPort

[Siva Mahadevan]

Jian-Hong Pan wrote:
> The cdn-dp sub driver probes the device failed on PINEBOOK Pro.
> 
> kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
> kernel: cdn-dp: probe of fec00000.dp failed with error -22
> 
> Then, the device halts all of the DRM related device jobs. For example,
> the operations: vop_component_ops, vop_component_ops and
> rockchip_dp_component_ops cannot be bound to corresponding devices. So,
> Xorg cannot find the correct DRM device.
> 
> The USB type-C DisplayPort does not work for now. So, disable the
> DisplayPort node until the type-C phy work has been done.
> 
> Link: https://patchwork.kernel.org/patch/11794141/#23639877
> Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> index 06d48338c836..d624c595c533 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> @@ -380,7 +380,7 @@ mains_charger: dc-charger {
>  };
>  
>  &cdn_dp {
> -	status = "okay";
> +	status = "disabled";
>  };
>  
>  &cpu_b0 {
> -- 
> 2.28.0

I saw a similar patch posted at https://lkml.org/lkml/2021/7/15/752. I
was wondering if one of these patches will be submitted to mainline, or
what the status on this patch is. I can confirm that this does solve
the issue on my Pinebook Pro. Will this go forward?

Re: [PATCH] arm64: dts: rockchip: disable USB type-c DisplayPort

[Jian-Hong Pan]

Siva Mahadevan <me@svmhdvn.name> 於 2021年10月25日 週一 上午5:17寫道：
>
> Jian-Hong Pan wrote:
> > The cdn-dp sub driver probes the device failed on PINEBOOK Pro.
> >
> > kernel: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
> > kernel: cdn-dp: probe of fec00000.dp failed with error -22
> >
> > Then, the device halts all of the DRM related device jobs. For example,
> > the operations: vop_component_ops, vop_component_ops and
> > rockchip_dp_component_ops cannot be bound to corresponding devices. So,
> > Xorg cannot find the correct DRM device.
> >
> > The USB type-C DisplayPort does not work for now. So, disable the
> > DisplayPort node until the type-C phy work has been done.
> >
> > Link: https://patchwork.kernel.org/patch/11794141/#23639877
> > Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> > index 06d48338c836..d624c595c533 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> > @@ -380,7 +380,7 @@ mains_charger: dc-charger {
> >  };
> >
> >  &cdn_dp {
> > -     status = "okay";
> > +     status = "disabled";
> >  };
> >
> >  &cpu_b0 {
> > --
> > 2.28.0
>
> I saw a similar patch posted at https://lkml.org/lkml/2021/7/15/752. I
> was wondering if one of these patches will be submitted to mainline, or
> what the status on this patch is. I can confirm that this does solve
> the issue on my Pinebook Pro. Will this go forward?

Notice that commit ("arm64: dts: rockchip: Disable CDN DP on Pinebook
Pro") [1] is already in linux-next.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20211022&id=2513fa5c25d42f55ca5f0f0ab247af7c9fbfa3b1

Jian-Hong Pan