From: Rob Herring <robh@kernel.org>
To: George Song <georgesong0119@gmail.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org,
george.song@maximintegrated.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"george.song" <george.song@analog.com>
Subject: Re: [PATCH 1/2] ALSA SoC MAX98520 dt-bindings : Added device tree binding for max98520 Signed-off-by: George Song <george.song@maximintegrated.com>
Date: Tue, 26 Oct 2021 14:38:14 -0500 [thread overview]
Message-ID: <YXhZJiXmT/duNu/M@robh.at.kernel.org> (raw)
In-Reply-To: <20211013060441.18177-1-georgesong0119@gmail.com>
On Wed, Oct 13, 2021 at 03:04:41PM +0900, George Song wrote:
> From: "george.song" <george.song@analog.com>
Patches must have an author name, commit message, and a Signed-off-by.
Please use checkpatch.pl which will point out some of this.
>
> ---
> .../bindings/sound/maxim,max98520.yaml | 35 +++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98520.yaml
>
> diff --git a/Documentation/devicetree/bindings/sound/maxim,max98520.yaml b/Documentation/devicetree/bindings/sound/maxim,max98520.yaml
> new file mode 100644
> index 000000000000..02481428e2ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/maxim,max98520.yaml
> @@ -0,0 +1,35 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/maxim,max98520.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim Integrated MAX98520 Speaker Amplifier Driver
> +
> +maintainers:
> + - Goerge Song <George.song@maximintegrated.com>
> +
> +properties:
> + compatible:
> + const: maxim,max98520
> +
> + reg:
> + maxItems: 1
> + description: I2C address of the device.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + max98520: amplifier@38 {
> + compatible = "maxim,max98520";
> + reg = <0x38>;
> + };
> + };
> --
> 2.25.1
>
>
prev parent reply other threads:[~2021-10-26 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 6:04 [PATCH 1/2] ALSA SoC MAX98520 dt-bindings : Added device tree binding for max98520 Signed-off-by: George Song <george.song@maximintegrated.com> George Song
2021-10-26 19:38 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXhZJiXmT/duNu/M@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=george.song@analog.com \
--cc=george.song@maximintegrated.com \
--cc=georgesong0119@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).