From: Rob Herring <robh@kernel.org>
To: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Cc: hminas@synopsys.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
devicetree@vger.kernel.org, amelie.delaunay@foss.st.com,
alexandre.torgue@foss.st.com
Subject: Re: [PATCH] dt-bindings: usb: dwc2: document the port when usb-role-switch is used
Date: Tue, 26 Oct 2021 15:38:06 -0500 [thread overview]
Message-ID: <YXhnLh9OYxUz8dIC@robh.at.kernel.org> (raw)
In-Reply-To: <1634144026-3326-1-git-send-email-fabrice.gasnier@foss.st.com>
On Wed, Oct 13, 2021 at 06:53:46PM +0200, Fabrice Gasnier wrote:
> Document the "port" property, which is used with "usb-role-switch"
> to describe the bus connector.
> Definition is inspired from mediatek,mtu3.yaml.
>
> This fixes some errors seen when running "make dtbs_check":
> ... 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: ... Documentation/devicetree/bindings/usb/dwc2.yaml
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
> index 10c7d9b..7d1aa53 100644
> --- a/Documentation/devicetree/bindings/usb/dwc2.yaml
> +++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
> @@ -130,6 +130,16 @@ properties:
> description: If present indicates that we need to reset the PHY when we
> detect a wakeup. This is due to a hardware errata.
>
> + port:
> + description:
> + Any connector to the data bus of this controller should be modelled
> + using the OF graph bindings specified, if the "usb-role-switch"
> + property is used. See graph.txt
Drop 'See graph.txt'
> + $ref: /schemas/graph.yaml#/properties/port
> +
> +dependencies:
> + port: [ 'usb-role-switch' ]
usb-role-switch without port is valid or both must be present. In case
of the latter, you need to add:
usb-role-switch: [ port ]
Also, you don't need quotes.
> +
> required:
> - compatible
> - reg
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2021-10-26 20:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 16:53 [PATCH] dt-bindings: usb: dwc2: document the port when usb-role-switch is used Fabrice Gasnier
2021-10-26 20:38 ` Rob Herring [this message]
2021-10-27 12:05 ` Fabrice Gasnier
2021-10-28 22:50 ` Rob Herring
2021-10-29 14:52 ` Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXhnLh9OYxUz8dIC@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).