* [PATCH] dt-bindings: display: xilinx: Fix example with psgtr
@ 2021-10-18 6:40 Michal Simek
2021-10-18 7:25 ` Laurent Pinchart
2021-10-26 23:37 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Michal Simek @ 2021-10-18 6:40 UTC (permalink / raw)
To: linux-kernel, monstr, michal.simek, git
Cc: Daniel Vetter, David Airlie, Hyun Kwon, Laurent Pinchart,
Rob Herring, Sam Ravnborg, devicetree, dri-devel,
linux-arm-kernel
Commit cea0f76a483d ("dt-bindings: phy: Add DT bindings for Xilinx ZynqMP
PSGTR PHY") clearly defines #phy-cells as 4. In past 5 cells were used by
it never went to upstream. That's why fix example by using only 4 cells
instead of 5.
Fixes: e7c7970a678d ("dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings")
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
.../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
index d88bd93f4b80..10ec78ca1c65 100644
--- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
+++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
@@ -160,8 +160,8 @@ examples:
<&xlnx_dpdma 2>,
<&xlnx_dpdma 3>;
- phys = <&psgtr 1 PHY_TYPE_DP 0 3 27000000>,
- <&psgtr 0 PHY_TYPE_DP 1 3 27000000>;
+ phys = <&psgtr 1 PHY_TYPE_DP 0 3>,
+ <&psgtr 0 PHY_TYPE_DP 1 3>;
phy-names = "dp-phy0", "dp-phy1";
};
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: display: xilinx: Fix example with psgtr
2021-10-18 6:40 [PATCH] dt-bindings: display: xilinx: Fix example with psgtr Michal Simek
@ 2021-10-18 7:25 ` Laurent Pinchart
2021-10-26 23:37 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2021-10-18 7:25 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, monstr, git, Daniel Vetter, David Airlie, Hyun Kwon,
Rob Herring, Sam Ravnborg, devicetree, dri-devel,
linux-arm-kernel
Hi Michal,
Thank you for the patch.
On Mon, Oct 18, 2021 at 08:40:12AM +0200, Michal Simek wrote:
> Commit cea0f76a483d ("dt-bindings: phy: Add DT bindings for Xilinx ZynqMP
> PSGTR PHY") clearly defines #phy-cells as 4. In past 5 cells were used by
> it never went to upstream. That's why fix example by using only 4 cells
> instead of 5.
>
> Fixes: e7c7970a678d ("dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings")
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> index d88bd93f4b80..10ec78ca1c65 100644
> --- a/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> +++ b/Documentation/devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml
> @@ -160,8 +160,8 @@ examples:
> <&xlnx_dpdma 2>,
> <&xlnx_dpdma 3>;
>
> - phys = <&psgtr 1 PHY_TYPE_DP 0 3 27000000>,
> - <&psgtr 0 PHY_TYPE_DP 1 3 27000000>;
> + phys = <&psgtr 1 PHY_TYPE_DP 0 3>,
> + <&psgtr 0 PHY_TYPE_DP 1 3>;
>
> phy-names = "dp-phy0", "dp-phy1";
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: display: xilinx: Fix example with psgtr
2021-10-18 6:40 [PATCH] dt-bindings: display: xilinx: Fix example with psgtr Michal Simek
2021-10-18 7:25 ` Laurent Pinchart
@ 2021-10-26 23:37 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-10-26 23:37 UTC (permalink / raw)
To: Michal Simek
Cc: linux-arm-kernel, Laurent Pinchart, linux-kernel, David Airlie,
Daniel Vetter, monstr, Sam Ravnborg, Rob Herring, dri-devel, git,
devicetree, Hyun Kwon
On Mon, 18 Oct 2021 08:40:12 +0200, Michal Simek wrote:
> Commit cea0f76a483d ("dt-bindings: phy: Add DT bindings for Xilinx ZynqMP
> PSGTR PHY") clearly defines #phy-cells as 4. In past 5 cells were used by
> it never went to upstream. That's why fix example by using only 4 cells
> instead of 5.
>
> Fixes: e7c7970a678d ("dt-bindings: display: xlnx: Add ZynqMP DP subsystem bindings")
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-26 23:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-18 6:40 [PATCH] dt-bindings: display: xilinx: Fix example with psgtr Michal Simek
2021-10-18 7:25 ` Laurent Pinchart
2021-10-26 23:37 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).