* [PATCH v4 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers [not found] <20211105030434.2828845-1-sean@poorly.run> @ 2021-11-05 3:04 ` Sean Paul 2021-11-12 22:06 ` Rob Herring 2021-11-05 3:04 ` [PATCH v4 13/14] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller Sean Paul 1 sibling, 1 reply; 6+ messages in thread From: Sean Paul @ 2021-11-05 3:04 UTC (permalink / raw) To: dri-devel, intel-gfx, freedreno Cc: bjorn.andersson, swboyd, jani.nikula, abhinavk, Sean Paul, Rob Herring, Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Rob Herring, Kuogee Hsieh, linux-arm-msm, devicetree From: Sean Paul <seanpaul@chromium.org> This patch adds the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. We'll use a new compatible string for this since the fields are optional. Cc: Rob Herring <robh@kernel.org> Cc: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-13-sean@poorly.run #v1 Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-13-sean@poorly.run #v2 Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-13-sean@poorly.run #v3 Changes in v2: -Drop register range names (Stephen) -Fix yaml errors (Rob) Changes in v3: -Add new compatible string for dp-hdcp -Add descriptions to reg -Add minItems/maxItems to reg -Make reg depend on the new hdcp compatible string Changes in v4: -Rebase on Bjorn's multi-dp patchset --- .../devicetree/bindings/display/msm/dp-controller.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index b36d74c1da7c..f6e4b102373a 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -21,12 +21,16 @@ properties: - qcom,sc8180x-edp reg: + minItems: 5 + maxItems: 7 items: - description: ahb register block - description: aux register block - description: link register block - description: p0 register block - description: p1 register block + - description: (Optional) Registers for HDCP device key injection + - description: (Optional) Registers for HDCP TrustZone interaction interrupts: maxItems: 1 @@ -111,7 +115,9 @@ examples: <0xae90200 0x200>, <0xae90400 0xc00>, <0xae91000 0x400>, - <0xae91400 0x400>; + <0xae91400 0x400>, + <0x0aed1000 0x174>, + <0x0aee1000 0x2c>; interrupt-parent = <&mdss>; interrupts = <12>; clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, -- Sean Paul, Software Engineer, Google / Chromium OS ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers 2021-11-05 3:04 ` [PATCH v4 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers Sean Paul @ 2021-11-12 22:06 ` Rob Herring 2021-11-15 20:21 ` [PATCH v4.5 " Sean Paul 0 siblings, 1 reply; 6+ messages in thread From: Rob Herring @ 2021-11-12 22:06 UTC (permalink / raw) To: Sean Paul Cc: dri-devel, intel-gfx, freedreno, bjorn.andersson, swboyd, jani.nikula, abhinavk, Sean Paul, Rob Clark, David Airlie, Daniel Vetter, Kuogee Hsieh, linux-arm-msm, devicetree On Thu, Nov 04, 2021 at 11:04:29PM -0400, Sean Paul wrote: > From: Sean Paul <seanpaul@chromium.org> > > This patch adds the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/encryption. > > We'll use a new compatible string for this since the fields are optional. > > Cc: Rob Herring <robh@kernel.org> > Cc: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-13-sean@poorly.run #v1 > Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-13-sean@poorly.run #v2 > Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-13-sean@poorly.run #v3 > > Changes in v2: > -Drop register range names (Stephen) > -Fix yaml errors (Rob) > Changes in v3: > -Add new compatible string for dp-hdcp > -Add descriptions to reg > -Add minItems/maxItems to reg > -Make reg depend on the new hdcp compatible string > Changes in v4: > -Rebase on Bjorn's multi-dp patchset > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index b36d74c1da7c..f6e4b102373a 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -21,12 +21,16 @@ properties: > - qcom,sc8180x-edp > > reg: > + minItems: 5 > + maxItems: 7 This should be a warning. Not sure why the bot didn't run. You just need 'minItems: 5' > items: > - description: ahb register block > - description: aux register block > - description: link register block > - description: p0 register block > - description: p1 register block > + - description: (Optional) Registers for HDCP device key injection > + - description: (Optional) Registers for HDCP TrustZone interaction > > interrupts: > maxItems: 1 > @@ -111,7 +115,9 @@ examples: > <0xae90200 0x200>, > <0xae90400 0xc00>, > <0xae91000 0x400>, > - <0xae91400 0x400>; > + <0xae91400 0x400>, > + <0x0aed1000 0x174>, > + <0x0aee1000 0x2c>; Be consistent and drop the leading 0. > interrupt-parent = <&mdss>; > interrupts = <12>; > clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, > -- > Sean Paul, Software Engineer, Google / Chromium OS > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v4.5 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers 2021-11-12 22:06 ` Rob Herring @ 2021-11-15 20:21 ` Sean Paul 2021-11-29 22:03 ` Rob Herring 0 siblings, 1 reply; 6+ messages in thread From: Sean Paul @ 2021-11-15 20:21 UTC (permalink / raw) To: dri-devel, intel-gfx, freedreno Cc: bjorn.andersson, swboyd, jani.nikula, abhinavk, seanpaul, robh, robh+dt, khsieh, linux-arm-msm, devicetree, Rob Clark, Sean Paul, David Airlie, Daniel Vetter From: Sean Paul <seanpaul@chromium.org> This patch adds the bindings for the MSM DisplayPort HDCP registers which are required to write the HDCP key into the display controller as well as the registers to enable HDCP authentication/key exchange/encryption. We'll use a new compatible string for this since the fields are optional. Cc: Rob Herring <robh@kernel.org> Cc: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-13-sean@poorly.run #v1 Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-13-sean@poorly.run #v2 Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-13-sean@poorly.run #v3 Link: https://patchwork.freedesktop.org/patch/msgid/20211105030434.2828845-13-sean@poorly.run #v4 Changes in v2: -Drop register range names (Stephen) -Fix yaml errors (Rob) Changes in v3: -Add new compatible string for dp-hdcp -Add descriptions to reg -Add minItems/maxItems to reg -Make reg depend on the new hdcp compatible string Changes in v4: -Rebase on Bjorn's multi-dp patchset Changes in v4.5: -Remove maxItems from reg (Rob) -Remove leading zeros in example (Rob) --- .../devicetree/bindings/display/msm/dp-controller.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index b36d74c1da7c..aff7d45ba6ed 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -21,12 +21,15 @@ properties: - qcom,sc8180x-edp reg: + minItems: 5 items: - description: ahb register block - description: aux register block - description: link register block - description: p0 register block - description: p1 register block + - description: (Optional) Registers for HDCP device key injection + - description: (Optional) Registers for HDCP TrustZone interaction interrupts: maxItems: 1 @@ -111,7 +114,9 @@ examples: <0xae90200 0x200>, <0xae90400 0xc00>, <0xae91000 0x400>, - <0xae91400 0x400>; + <0xae91400 0x400>, + <0xaed1000 0x174>, + <0xaee1000 0x2c>; interrupt-parent = <&mdss>; interrupts = <12>; clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, -- Sean Paul, Software Engineer, Google / Chromium OS ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v4.5 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers 2021-11-15 20:21 ` [PATCH v4.5 " Sean Paul @ 2021-11-29 22:03 ` Rob Herring 0 siblings, 0 replies; 6+ messages in thread From: Rob Herring @ 2021-11-29 22:03 UTC (permalink / raw) To: Sean Paul Cc: swboyd, seanpaul, linux-arm-msm, Rob Clark, khsieh, intel-gfx, freedreno, devicetree, jani.nikula, Daniel Vetter, abhinavk, David Airlie, dri-devel, bjorn.andersson, robh+dt On Mon, 15 Nov 2021 20:21:48 +0000, Sean Paul wrote: > From: Sean Paul <seanpaul@chromium.org> > > This patch adds the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/encryption. > > We'll use a new compatible string for this since the fields are optional. > > Cc: Rob Herring <robh@kernel.org> > Cc: Stephen Boyd <swboyd@chromium.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-13-sean@poorly.run #v1 > Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-13-sean@poorly.run #v2 > Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-13-sean@poorly.run #v3 > Link: https://patchwork.freedesktop.org/patch/msgid/20211105030434.2828845-13-sean@poorly.run #v4 > > Changes in v2: > -Drop register range names (Stephen) > -Fix yaml errors (Rob) > Changes in v3: > -Add new compatible string for dp-hdcp > -Add descriptions to reg > -Add minItems/maxItems to reg > -Make reg depend on the new hdcp compatible string > Changes in v4: > -Rebase on Bjorn's multi-dp patchset > Changes in v4.5: > -Remove maxItems from reg (Rob) > -Remove leading zeros in example (Rob) > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v4 13/14] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller [not found] <20211105030434.2828845-1-sean@poorly.run> 2021-11-05 3:04 ` [PATCH v4 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers Sean Paul @ 2021-11-05 3:04 ` Sean Paul 2021-12-08 22:06 ` [Freedreno] " Rob Clark 1 sibling, 1 reply; 6+ messages in thread From: Sean Paul @ 2021-11-05 3:04 UTC (permalink / raw) To: dri-devel, intel-gfx, freedreno Cc: bjorn.andersson, swboyd, jani.nikula, abhinavk, Sean Paul, Andy Gross, Rob Herring, linux-arm-msm, devicetree From: Sean Paul <seanpaul@chromium.org> This patch adds the register ranges required for HDCP key injection and HDCP TrustZone interaction as described in the dt-bindings for the sc7180 dp controller. Now that these are supported, change the compatible string to "dp-hdcp". Signed-off-by: Sean Paul <seanpaul@chromium.org> Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-15-sean@poorly.run #v1 Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-14-sean@poorly.run #v2 Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-14-sean@poorly.run #v3 Changes in v3: -Split off into a new patch containing just the dts change (Stephen) -Add hdcp compatible string (Stephen) Changes in v4: -Rebase on Bjorn's multi-dp patchset --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi index c8921e2d6480..838270f70b62 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -3088,7 +3088,13 @@ mdss_dp: displayport-controller@ae90000 { compatible = "qcom,sc7180-dp"; status = "disabled"; - reg = <0 0x0ae90000 0 0x1400>; + reg = <0 0x0ae90000 0 0x200>, + <0 0x0ae90200 0 0x200>, + <0 0x0ae90400 0 0xc00>, + <0 0x0ae91000 0 0x400>, + <0 0x0ae91400 0 0x400>, + <0 0x0aed1000 0 0x175>, + <0 0x0aee1000 0 0x2c>; interrupt-parent = <&mdss>; interrupts = <12>; -- Sean Paul, Software Engineer, Google / Chromium OS ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Freedreno] [PATCH v4 13/14] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller 2021-11-05 3:04 ` [PATCH v4 13/14] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller Sean Paul @ 2021-12-08 22:06 ` Rob Clark 0 siblings, 0 replies; 6+ messages in thread From: Rob Clark @ 2021-12-08 22:06 UTC (permalink / raw) To: Sean Paul Cc: dri-devel, Intel Graphics Development, freedreno, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Jani Nikula, linux-arm-msm, Abhinav Kumar, Stephen Boyd, Rob Herring, Andy Gross, Sean Paul, Bjorn Andersson On Thu, Nov 4, 2021 at 8:05 PM Sean Paul <sean@poorly.run> wrote: > > From: Sean Paul <seanpaul@chromium.org> > > This patch adds the register ranges required for HDCP key injection and > HDCP TrustZone interaction as described in the dt-bindings for the > sc7180 dp controller. Now that these are supported, change the > compatible string to "dp-hdcp". > > Signed-off-by: Sean Paul <seanpaul@chromium.org> > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-15-sean@poorly.run #v1 > Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-14-sean@poorly.run #v2 > Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-14-sean@poorly.run #v3 > > Changes in v3: > -Split off into a new patch containing just the dts change (Stephen) > -Add hdcp compatible string (Stephen) > Changes in v4: > -Rebase on Bjorn's multi-dp patchset > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index c8921e2d6480..838270f70b62 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -3088,7 +3088,13 @@ mdss_dp: displayport-controller@ae90000 { > compatible = "qcom,sc7180-dp"; > status = "disabled"; > > - reg = <0 0x0ae90000 0 0x1400>; > + reg = <0 0x0ae90000 0 0x200>, > + <0 0x0ae90200 0 0x200>, > + <0 0x0ae90400 0 0xc00>, > + <0 0x0ae91000 0 0x400>, > + <0 0x0ae91400 0 0x400>, > + <0 0x0aed1000 0 0x175>, > + <0 0x0aee1000 0 0x2c>; So one small issue, if someone tries to get linux running on a sc7180 windows laptop (which uses qcom's tz instead of the CrOS tz), things will go BOOM! We might want instead to move this somewhere chromebook specific, maybe sc7180-trogdor.dtsi? BR, -R > > interrupt-parent = <&mdss>; > interrupts = <12>; > -- > Sean Paul, Software Engineer, Google / Chromium OS > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-08 22:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211105030434.2828845-1-sean@poorly.run>
2021-11-05 3:04 ` [PATCH v4 12/14] dt-bindings: msm/dp: Add bindings for HDCP registers Sean Paul
2021-11-12 22:06 ` Rob Herring
2021-11-15 20:21 ` [PATCH v4.5 " Sean Paul
2021-11-29 22:03 ` Rob Herring
2021-11-05 3:04 ` [PATCH v4 13/14] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller Sean Paul
2021-12-08 22:06 ` [Freedreno] " Rob Clark
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).