[PATCH 0/2] Add cpuidle driver for Sunplus SP7021

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/2] Add cpuidle driver for Sunplus SP7021
@ 2021-11-08  7:55 Edwin chiu
  2021-11-08  7:55 ` [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml Edwin chiu
  2021-11-08  7:55 ` [PATCH 2/2] cpuidle:sunplus:create cpuidle driver for sunplus sp7021 Edwin chiu
  0 siblings, 2 replies; 9+ messages in thread
From: Edwin chiu @ 2021-11-08  7:55 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-kernel, rafael, daniel.lezcano,
	linux-pm
  Cc: Edwin chiu

This is a patch series for cpuidle driver for Sunplus SP7021 SoC.

Sunplus SP7021 is an ARM Cortex A7 (4 cores) based SoC. It integrates
many peripherals (ex: UART, I2C, SPI, SDIO, eMMC, USB, SD card and 
etc.) into a single chip. It is designed for industrial control.

Refer to:
https://sunplus-tibbo.atlassian.net/wiki/spaces/doc/overview
https://tibbo.com/store/plus1.html

Edwin chiu (2):
  dt-bingings:arm:sunplus:add sp7021 compatible string to
    sunplus,idle-state.yaml
  cpuidle:sunplus:create cpuidle driver for sunplus sp7021

 .../bindings/arm/sunplus/sunplus,idle-state.yaml   |  55 ++++++
 MAINTAINERS                                        |   9 +
 drivers/cpuidle/Kconfig.arm                        |   7 +
 drivers/cpuidle/Makefile                           |   1 +
 drivers/cpuidle/cpuidle-sunplus.c                  | 185 +++++++++++++++++++++
 include/linux/platform_data/cpuidle-sunplus.h      |  14 ++
 6 files changed, 271 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
 create mode 100644 drivers/cpuidle/cpuidle-sunplus.c
 create mode 100644 include/linux/platform_data/cpuidle-sunplus.h

-- 
2.7.4


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml
  2021-11-08  7:55 [PATCH 0/2] Add cpuidle driver for Sunplus SP7021 Edwin chiu
@ 2021-11-08  7:55 ` Edwin chiu
  2021-11-08 13:03   ` Rob Herring
  2021-11-08  7:55 ` [PATCH 2/2] cpuidle:sunplus:create cpuidle driver for sunplus sp7021 Edwin chiu
  1 sibling, 1 reply; 9+ messages in thread
From: Edwin chiu @ 2021-11-08  7:55 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-kernel, rafael, daniel.lezcano,
	linux-pm
  Cc: Edwin chiu

Add the compatible string for cpuidle state on sp7021

Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>
---
 .../bindings/arm/sunplus/sunplus,idle-state.yaml   | 55 ++++++++++++++++++++++
 MAINTAINERS                                        |  6 +++
 2 files changed, 61 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml

diff --git a/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml b/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
new file mode 100644
index 0000000..649e953
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) Sunplus Co., Ltd. 2021
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/sunplus/sunplus,idle-state.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sunplus cpuidle state
+
+maintainers:
+  - edwin.chiu <edwin.chiu@sunplus.com>
+
+description: |
+  Sunplus SOC cpuidle state
+
+properties:
+  compatible:
+    const: arm,idle-state
+
+  entry-latency-us:
+    description:
+      Worst case latency in microseconds required to enter the idle state.
+
+  exit-latency-us:
+    description:
+      Worst case latency in microseconds required to exit the idle state.
+      The exit-latency-us duration may be guaranteed only after
+      entry-latency-us has passed.
+
+  min-residency-us:
+    description:
+      Minimum residency duration in microseconds, inclusive of preparation
+      and entry, for this idle state to be considered worthwhile energy wise
+      (refer to section 2 of this document for a complete description).
+
+required:
+  - compatible
+  - entry-latency-us
+  - exit-latency-us
+  - min-residency-us
+
+additionalProperties: true
+
+examples:
+  - |
+    idle-states {
+      CLUSTER_SLEEP_BIG: cluster-sleep-big {
+        compatible = "arm,idle-state";
+        entry-latency-us = <8000>;
+        exit-latency-us = <700>;
+        min-residency-us = <9000>;
+      };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 3b79fd4..52f17ec 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17945,6 +17945,12 @@ L:	netdev@vger.kernel.org
 S:	Maintained
 F:	drivers/net/ethernet/dlink/sundance.c
 
+SUNPLUS CPUIDLE DRIVER
+M:	Edwin Chiu <edwin.chiu@sunplus.com>
+S:	Maintained
+F:	Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
+
+
 SUPERH
 M:	Yoshinori Sato <ysato@users.sourceforge.jp>
 M:	Rich Felker <dalias@libc.org>
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml
  2021-11-08  7:55 ` [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml Edwin chiu
@ 2021-11-08 13:03   ` Rob Herring
  2021-11-09  6:58     ` Edwin Chiu 邱垂峰
  0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2021-11-08 13:03 UTC (permalink / raw)
  To: Edwin chiu
  Cc: robh+dt, daniel.lezcano, devicetree, linux-kernel, rafael,
	linux-pm, Edwin chiu

On Mon, 08 Nov 2021 15:55:09 +0800, Edwin chiu wrote:
> Add the compatible string for cpuidle state on sp7021
> 
> Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>
> ---
>  .../bindings/arm/sunplus/sunplus,idle-state.yaml   | 55 ++++++++++++++++++++++
>  MAINTAINERS                                        |  6 +++
>  2 files changed, 61 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1552228


spc: compatible:0: 'arm,idle-state' was expected
	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml

spc: compatible: Additional items are not allowed ('arm,idle-state' was unexpected)
	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml

spc: compatible: ['qcom,idle-state-spc', 'arm,idle-state'] is too long
	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml


^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml
  2021-11-08 13:03   ` Rob Herring
@ 2021-11-09  6:58     ` Edwin Chiu 邱垂峰
  2021-11-12 22:58       ` Rob Herring
  0 siblings, 1 reply; 9+ messages in thread
From: Edwin Chiu 邱垂峰 @ 2021-11-09  6:58 UTC (permalink / raw)
  To: Rob Herring, Edwin chiu
  Cc: robh+dt@kernel.org, daniel.lezcano@linaro.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	rafael@kernel.org, linux-pm@vger.kernel.org

Hi Rob:

Look into the full log, it show you check 3 programs
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Context	Check	Description
robh/checkpatch	warning	total: 0 errors, 1 warnings, 67 lines checked
robh/dt-meta-schema	success	
robh/dtbs-check	fail	build log
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1) The checkpatch warning is WARNING: From:/Signed-off-by: email address mismatch: 'From: Edwin chiu <edwinchiu0505tw@gmail.com>' != 'Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>'
==> I want explain to you that <edwin.chiu@sunplus.com> is my email in the company, but it disagree operate by "git send-email".
    So I used <edwinchiu0505tw@gmail.com> in my linux system to operate with "git send-email".
   Actually I checkpatch in my side was 0 error 0 warning.

2) Regarding to dtbs-check issue, your list warnings related to others company's yaml file, it not my yaml file case. 
   What is the purpose you want? Or what should I do?

3) Execute=>make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
There are many config select items…..I don't know how to select them.
(I execute "make config " and "make all" were pass)
Can you teach me how to do "make dtbs_check"?

邱垂峰 EdwinChiu
智能運算專案
T: +886-3-5786005 ext.2590
edwin.chiu@sunplus.com
300 新竹科學園區創新一路19號

-----Original Message-----
From: Rob Herring <robh@kernel.org> 
Sent: Monday, November 8, 2021 9:03 PM
To: Edwin chiu <edwinchiu0505tw@gmail.com>
Cc: robh+dt@kernel.org; daniel.lezcano@linaro.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; rafael@kernel.org; linux-pm@vger.kernel.org; Edwin Chiu 邱垂峰 <edwin.chiu@sunplus.com>
Subject: Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml

On Mon, 08 Nov 2021 15:55:09 +0800, Edwin chiu wrote:
> Add the compatible string for cpuidle state on sp7021
> 
> Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>
> ---
>  .../bindings/arm/sunplus/sunplus,idle-state.yaml   | 55 ++++++++++++++++++++++
>  MAINTAINERS                                        |  6 +++
>  2 files changed, 61 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1552228


spc: compatible:0: 'arm,idle-state' was expected
	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml

spc: compatible: Additional items are not allowed ('arm,idle-state' was unexpected)
	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml

spc: compatible: ['qcom,idle-state-spc', 'arm,idle-state'] is too long
	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml
  2021-11-09  6:58     ` Edwin Chiu 邱垂峰
@ 2021-11-12 22:58       ` Rob Herring
  2021-11-15  9:07         ` Edwin Chiu 邱垂峰
                           ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Rob Herring @ 2021-11-12 22:58 UTC (permalink / raw)
  To: Edwin Chiu 邱垂峰
  Cc: Edwin chiu, daniel.lezcano@linaro.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, rafael@kernel.org,
	linux-pm@vger.kernel.org

On Tue, Nov 09, 2021 at 06:58:24AM +0000, Edwin Chiu 邱垂峰 wrote:
> Hi Rob:
> 
> Look into the full log, it show you check 3 programs
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Context	Check	Description
> robh/checkpatch	warning	total: 0 errors, 1 warnings, 67 lines checked
> robh/dt-meta-schema	success	
> robh/dtbs-check	fail	build log
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> 1) The checkpatch warning is WARNING: From:/Signed-off-by: email address mismatch: 'From: Edwin chiu <edwinchiu0505tw@gmail.com>' != 'Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>'
> ==> I want explain to you that <edwin.chiu@sunplus.com> is my email in the company, but it disagree operate by "git send-email".
>     So I used <edwinchiu0505tw@gmail.com> in my linux system to operate with "git send-email".
>    Actually I checkpatch in my side was 0 error 0 warning.

The email used to send and the author emails are independent in git. 
There should be a 'From:' line in the resulting patch when the sender 
and author don't match.

Maybe you need to set sendemail.from config option to your corp email.

> 
> 2) Regarding to dtbs-check issue, your list warnings related to others company's yaml file, it not my yaml file case. 
>    What is the purpose you want? Or what should I do?

You aren't adding anything custom, so why are you even adding the 
schema? arm/idle-states.yaml should be enough.

> 
> 3) Execute=>make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
> There are many config select items…..I don't know how to select them.
> (I execute "make config " and "make all" were pass)
> Can you teach me how to do "make dtbs_check"?

Did you read Documentation/devicetree/bindings/writing-schema.rst?

To check all dts files (for an arch) and run the validation, do:

make allmodconfig
make dtbs_check

Rob

> 
> 邱垂峰 EdwinChiu
> 智能運算專案
> T: +886-3-5786005 ext.2590
> edwin.chiu@sunplus.com
> 300 新竹科學園區創新一路19號
> 
> -----Original Message-----
> From: Rob Herring <robh@kernel.org> 
> Sent: Monday, November 8, 2021 9:03 PM
> To: Edwin chiu <edwinchiu0505tw@gmail.com>
> Cc: robh+dt@kernel.org; daniel.lezcano@linaro.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; rafael@kernel.org; linux-pm@vger.kernel.org; Edwin Chiu 邱垂峰 <edwin.chiu@sunplus.com>
> Subject: Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml
> 
> On Mon, 08 Nov 2021 15:55:09 +0800, Edwin chiu wrote:
> > Add the compatible string for cpuidle state on sp7021
> > 
> > Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>
> > ---
> >  .../bindings/arm/sunplus/sunplus,idle-state.yaml   | 55 ++++++++++++++++++++++
> >  MAINTAINERS                                        |  6 +++
> >  2 files changed, 61 insertions(+)
> >  create mode 100644 
> > Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
> > 
> 
> Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/1552228
> 
> 
> spc: compatible:0: 'arm,idle-state' was expected
> 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> 
> spc: compatible: Additional items are not allowed ('arm,idle-state' was unexpected)
> 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> 
> spc: compatible: ['qcom,idle-state-spc', 'arm,idle-state'] is too long
> 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> 

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml
  2021-11-12 22:58       ` Rob Herring
@ 2021-11-15  9:07         ` Edwin Chiu 邱垂峰
  2021-11-26  5:59         ` Edwin Chiu 邱垂峰
  2021-12-03  7:04         ` Edwin Chiu 邱垂峰
  2 siblings, 0 replies; 9+ messages in thread
From: Edwin Chiu 邱垂峰 @ 2021-11-15  9:07 UTC (permalink / raw)
  To: Rob Herring
  Cc: Edwin chiu, daniel.lezcano@linaro.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, rafael@kernel.org,
	linux-pm@vger.kernel.org

Hi Rob:

Thanks your response.
Reply your question as below:
> > 1) The checkpatch warning is WARNING: From:/Signed-off-by: email address mismatch: 'From: Edwin
> chiu <edwinchiu0505tw@gmail.com>' != 'Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>'
> > ==> I want explain to you that <edwin.chiu@sunplus.com> is my email in the company, but it disagree
> operate by "git send-email".
> >     So I used <edwinchiu0505tw@gmail.com> in my linux system to operate with "git send-email".
> >    Actually I checkpatch in my side was 0 error 0 warning.
> 
> The email used to send and the author emails are independent in git.
> There should be a 'From:' line in the resulting patch when the sender and author don't match.
> 
> Maybe you need to set sendemail.from config option to your corp email.
> 
==> Please understanding it is our company secure policy.
    It disagree operate by "git send-email".
   But I am pretty sure I can receive email on both edwin.chiu@sunplus.com and edwinchiu0505tw@gmail.com .

> >
> > 2) Regarding to dtbs-check issue, your list warnings related to others company's yaml file, it not my
> yaml file case.
> >    What is the purpose you want? Or what should I do?
> 
> You aren't adding anything custom, so why are you even adding the schema? arm/idle-states.yaml
> should be enough.
> 
===> Yes, I want to apply arm/idle-state structure to my idle function.
    I thought every function submit, all need edit yaml file together.
    Do you mean I can submit cpuidle-sunplus.c without my sunplus,idle-state.yaml ?

On the other hand, I confirm my yaml file can pass dt_binding_check and dtbs_check as below:
edwinchiu@scdiu3:~/code/code1/linux/kernel$ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
  DTEX    Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dts
  DTC     Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dt.yaml
  CHECK   Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dt.yaml
edwinchiu@scdiu3:~/code/code1/linux/kernel$

edwinchiu@scdiu3:~/code/code1/linux/kernel$ export ARCH=arm
edwinchiu@scdiu3:~/code/code1/linux/kernel$ echo $ARCH
arm
edwinchiu@scdiu3:~/code/code1/linux/kernel$ make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
  SYNC    include/config/auto.conf.cmd
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  UPD     include/config/kernel.release
  DTC     arch/arm/boot/dts/sp7021-bpi-f2p.dtb
  DTC     arch/arm/boot/dts/sp7021-bpi-f2s.dtb
  DTC     arch/arm/boot/dts/sp7021-demov2.dtb
  DTC     arch/arm/boot/dts/sp7021-demov3.dtb
  DTC     arch/arm/boot/dts/sp7021-ev.dtb
  DTC     arch/arm/boot/dts/sp7021-ev-ttl.dtb
  DTC     arch/arm/boot/dts/sp7021-ltpp3g2revD.dtb
  DTC     arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dtb
  DTC     arch/arm/boot/dts/sp7021-bpi-f2p.dt.yaml
  CHECK   arch/arm/boot/dts/sp7021-bpi-f2p.dt.yaml
  DTC     arch/arm/boot/dts/sp7021-bpi-f2s.dt.yaml
  CHECK   arch/arm/boot/dts/sp7021-bpi-f2s.dt.yaml
  DTC     arch/arm/boot/dts/sp7021-demov2.dt.yaml
  CHECK   arch/arm/boot/dts/sp7021-demov2.dt.yaml
  DTC     arch/arm/boot/dts/sp7021-demov3.dt.yaml
  CHECK   arch/arm/boot/dts/sp7021-demov3.dt.yaml
  DTC     arch/arm/boot/dts/sp7021-ev.dt.yaml
  CHECK   arch/arm/boot/dts/sp7021-ev.dt.yaml
  DTC     arch/arm/boot/dts/sp7021-ev-ttl.dt.yaml
  CHECK   arch/arm/boot/dts/sp7021-ev-ttl.dt.yaml
  DTC     arch/arm/boot/dts/sp7021-ltpp3g2revD.dt.yaml
  CHECK   arch/arm/boot/dts/sp7021-ltpp3g2revD.dt.yaml
  DTC     arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dt.yaml
  CHECK   arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dt.yaml
edwinchiu@scdiu3:~/code/code1/linux/kernel$



邱垂峰 EdwinChiu
智能運算專案
T: +886-3-5786005 ext.2590
edwin.chiu@sunplus.com
300 新竹科學園區創新一路19號


> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Saturday, November 13, 2021 6:59 AM
> To: Edwin Chiu 邱垂峰 <edwin.chiu@sunplus.com>
> Cc: Edwin chiu <edwinchiu0505tw@gmail.com>; daniel.lezcano@linaro.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; rafael@kernel.org; linux-pm@vger.kernel.org
> Subject: Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to
> sunplus,idle-state.yaml
> 
> On Tue, Nov 09, 2021 at 06:58:24AM +0000, Edwin Chiu 邱垂峰 wrote:
> > Hi Rob:
> >
> > Look into the full log, it show you check 3 programs
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > Context	Check	Description
> > robh/checkpatch	warning	total: 0 errors, 1 warnings, 67 lines checked
> > robh/dt-meta-schema	success
> > robh/dtbs-check	fail	build log
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > 1) The checkpatch warning is WARNING: From:/Signed-off-by: email address mismatch: 'From: Edwin
> chiu <edwinchiu0505tw@gmail.com>' != 'Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>'
> > ==> I want explain to you that <edwin.chiu@sunplus.com> is my email in the company, but it disagree
> operate by "git send-email".
> >     So I used <edwinchiu0505tw@gmail.com> in my linux system to operate with "git send-email".
> >    Actually I checkpatch in my side was 0 error 0 warning.
> 
> The email used to send and the author emails are independent in git.
> There should be a 'From:' line in the resulting patch when the sender and author don't match.
> 
> Maybe you need to set sendemail.from config option to your corp email.
> 
> >
> > 2) Regarding to dtbs-check issue, your list warnings related to others company's yaml file, it not my
> yaml file case.
> >    What is the purpose you want? Or what should I do?
> 
> You aren't adding anything custom, so why are you even adding the schema? arm/idle-states.yaml
> should be enough.
> 
> >
> > 3) Execute=>make dtbs_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,
> > idle-state.yaml There are many config select items…..I don't know how
> > to select them.
> > (I execute "make config " and "make all" were pass) Can you teach me
> > how to do "make dtbs_check"?
> 
> Did you read Documentation/devicetree/bindings/writing-schema.rst?
> 
> To check all dts files (for an arch) and run the validation, do:
> 
> make allmodconfig
> make dtbs_check
> 
> Rob
> 
> >
> > 邱垂峰 EdwinChiu
> > 智能運算專案
> > T: +886-3-5786005 ext.2590
> > edwin.chiu@sunplus.com
> > 300 新竹科學園區創新一路19號
> >
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Monday, November 8, 2021 9:03 PM
> > To: Edwin chiu <edwinchiu0505tw@gmail.com>
> > Cc: robh+dt@kernel.org; daniel.lezcano@linaro.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > rafael@kernel.org; linux-pm@vger.kernel.org; Edwin Chiu 邱垂峰
> > <edwin.chiu@sunplus.com>
> > Subject: Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible
> > string to sunplus,idle-state.yaml
> >
> > On Mon, 08 Nov 2021 15:55:09 +0800, Edwin chiu wrote:
> > > Add the compatible string for cpuidle state on sp7021
> > >
> > > Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>
> > > ---
> > >  .../bindings/arm/sunplus/sunplus,idle-state.yaml   | 55 ++++++++++++++++++++++
> > >  MAINTAINERS                                        |  6 +++
> > >  2 files changed, 61 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yam
> > > l
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if
> they are expected or the schema is incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/1552228
> >
> >
> > spc: compatible:0: 'arm,idle-state' was expected
> > 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> >
> > spc: compatible: Additional items are not allowed ('arm,idle-state' was unexpected)
> > 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> >
> > spc: compatible: ['qcom,idle-state-spc', 'arm,idle-state'] is too long
> > 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> > 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> >

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml
  2021-11-12 22:58       ` Rob Herring
  2021-11-15  9:07         ` Edwin Chiu 邱垂峰
@ 2021-11-26  5:59         ` Edwin Chiu 邱垂峰
  2021-12-03  7:04         ` Edwin Chiu 邱垂峰
  2 siblings, 0 replies; 9+ messages in thread
From: Edwin Chiu 邱垂峰 @ 2021-11-26  5:59 UTC (permalink / raw)
  To: Rob Herring
  Cc: Edwin chiu, daniel.lezcano@linaro.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, rafael@kernel.org,
	linux-pm@vger.kernel.org

Hi Rob:

What is the status now?
Are you agree my submit?

邱垂峰 EdwinChiu
智能運算專案
T: +886-3-5786005 ext.2590
edwin.chiu@sunplus.com
300 新竹科學園區創新一路19號


> -----Original Message-----
> From: Edwin Chiu 邱垂峰
> Sent: Monday, November 15, 2021 5:08 PM
> To: 'Rob Herring' <robh@kernel.org>
> Cc: Edwin chiu <edwinchiu0505tw@gmail.com>; daniel.lezcano@linaro.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; rafael@kernel.org; linux-pm@vger.kernel.org
> Subject: RE: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to
> sunplus,idle-state.yaml
> 
> Hi Rob:
> 
> Thanks your response.
> Reply your question as below:
> > > 1) The checkpatch warning is WARNING: From:/Signed-off-by: email
> > > address mismatch: 'From: Edwin
> > chiu <edwinchiu0505tw@gmail.com>' != 'Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>'
> > > ==> I want explain to you that <edwin.chiu@sunplus.com> is my email
> > > in the company, but it disagree
> > operate by "git send-email".
> > >     So I used <edwinchiu0505tw@gmail.com> in my linux system to operate with "git send-email".
> > >    Actually I checkpatch in my side was 0 error 0 warning.
> >
> > The email used to send and the author emails are independent in git.
> > There should be a 'From:' line in the resulting patch when the sender and author don't match.
> >
> > Maybe you need to set sendemail.from config option to your corp email.
> >
> ==> Please understanding it is our company secure policy.
>     It disagree operate by "git send-email".
>    But I am pretty sure I can receive email on both edwin.chiu@sunplus.com and
> edwinchiu0505tw@gmail.com .
> 
> > >
> > > 2) Regarding to dtbs-check issue, your list warnings related to
> > > others company's yaml file, it not my
> > yaml file case.
> > >    What is the purpose you want? Or what should I do?
> >
> > You aren't adding anything custom, so why are you even adding the
> > schema? arm/idle-states.yaml should be enough.
> >
> ===> Yes, I want to apply arm/idle-state structure to my idle function.
>     I thought every function submit, all need edit yaml file together.
>     Do you mean I can submit cpuidle-sunplus.c without my sunplus,idle-state.yaml ?
> 
> On the other hand, I confirm my yaml file can pass dt_binding_check and dtbs_check as below:
> edwinchiu@scdiu3:~/code/code1/linux/kernel$ make dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
>   DTEX    Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dts
>   DTC     Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dt.yaml
>   CHECK   Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dt.yaml
> edwinchiu@scdiu3:~/code/code1/linux/kernel$
> 
> edwinchiu@scdiu3:~/code/code1/linux/kernel$ export ARCH=arm
> edwinchiu@scdiu3:~/code/code1/linux/kernel$ echo $ARCH arm
> edwinchiu@scdiu3:~/code/code1/linux/kernel$ make dtbs_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
>   SYNC    include/config/auto.conf.cmd
>   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>   UPD     include/config/kernel.release
>   DTC     arch/arm/boot/dts/sp7021-bpi-f2p.dtb
>   DTC     arch/arm/boot/dts/sp7021-bpi-f2s.dtb
>   DTC     arch/arm/boot/dts/sp7021-demov2.dtb
>   DTC     arch/arm/boot/dts/sp7021-demov3.dtb
>   DTC     arch/arm/boot/dts/sp7021-ev.dtb
>   DTC     arch/arm/boot/dts/sp7021-ev-ttl.dtb
>   DTC     arch/arm/boot/dts/sp7021-ltpp3g2revD.dtb
>   DTC     arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dtb
>   DTC     arch/arm/boot/dts/sp7021-bpi-f2p.dt.yaml
>   CHECK   arch/arm/boot/dts/sp7021-bpi-f2p.dt.yaml
>   DTC     arch/arm/boot/dts/sp7021-bpi-f2s.dt.yaml
>   CHECK   arch/arm/boot/dts/sp7021-bpi-f2s.dt.yaml
>   DTC     arch/arm/boot/dts/sp7021-demov2.dt.yaml
>   CHECK   arch/arm/boot/dts/sp7021-demov2.dt.yaml
>   DTC     arch/arm/boot/dts/sp7021-demov3.dt.yaml
>   CHECK   arch/arm/boot/dts/sp7021-demov3.dt.yaml
>   DTC     arch/arm/boot/dts/sp7021-ev.dt.yaml
>   CHECK   arch/arm/boot/dts/sp7021-ev.dt.yaml
>   DTC     arch/arm/boot/dts/sp7021-ev-ttl.dt.yaml
>   CHECK   arch/arm/boot/dts/sp7021-ev-ttl.dt.yaml
>   DTC     arch/arm/boot/dts/sp7021-ltpp3g2revD.dt.yaml
>   CHECK   arch/arm/boot/dts/sp7021-ltpp3g2revD.dt.yaml
>   DTC     arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dt.yaml
>   CHECK   arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dt.yaml
> edwinchiu@scdiu3:~/code/code1/linux/kernel$
> 
> 
> 
> 邱垂峰 EdwinChiu
> 智能運算專案
> T: +886-3-5786005 ext.2590
> edwin.chiu@sunplus.com
> 300 新竹科學園區創新一路19號
> 
> 
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Saturday, November 13, 2021 6:59 AM
> > To: Edwin Chiu 邱垂峰 <edwin.chiu@sunplus.com>
> > Cc: Edwin chiu <edwinchiu0505tw@gmail.com>; daniel.lezcano@linaro.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > rafael@kernel.org; linux-pm@vger.kernel.org
> > Subject: Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible
> > string to sunplus,idle-state.yaml
> >
> > On Tue, Nov 09, 2021 at 06:58:24AM +0000, Edwin Chiu 邱垂峰 wrote:
> > > Hi Rob:
> > >
> > > Look into the full log, it show you check 3 programs
> > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > Context	Check	Description
> > > robh/checkpatch	warning	total: 0 errors, 1 warnings, 67 lines checked
> > > robh/dt-meta-schema	success
> > > robh/dtbs-check	fail	build log
> > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >
> > > 1) The checkpatch warning is WARNING: From:/Signed-off-by: email
> > > address mismatch: 'From: Edwin
> > chiu <edwinchiu0505tw@gmail.com>' != 'Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>'
> > > ==> I want explain to you that <edwin.chiu@sunplus.com> is my email
> > > in the company, but it disagree
> > operate by "git send-email".
> > >     So I used <edwinchiu0505tw@gmail.com> in my linux system to operate with "git send-email".
> > >    Actually I checkpatch in my side was 0 error 0 warning.
> >
> > The email used to send and the author emails are independent in git.
> > There should be a 'From:' line in the resulting patch when the sender and author don't match.
> >
> > Maybe you need to set sendemail.from config option to your corp email.
> >
> > >
> > > 2) Regarding to dtbs-check issue, your list warnings related to
> > > others company's yaml file, it not my
> > yaml file case.
> > >    What is the purpose you want? Or what should I do?
> >
> > You aren't adding anything custom, so why are you even adding the
> > schema? arm/idle-states.yaml should be enough.
> >
> > >
> > > 3) Execute=>make dtbs_check
> > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplu
> > > s, idle-state.yaml There are many config select items…..I don't know
> > > how to select them.
> > > (I execute "make config " and "make all" were pass) Can you teach me
> > > how to do "make dtbs_check"?
> >
> > Did you read Documentation/devicetree/bindings/writing-schema.rst?
> >
> > To check all dts files (for an arch) and run the validation, do:
> >
> > make allmodconfig
> > make dtbs_check
> >
> > Rob
> >
> > >
> > > 邱垂峰 EdwinChiu
> > > 智能運算專案
> > > T: +886-3-5786005 ext.2590
> > > edwin.chiu@sunplus.com
> > > 300 新竹科學園區創新一路19號
> > >
> > > -----Original Message-----
> > > From: Rob Herring <robh@kernel.org>
> > > Sent: Monday, November 8, 2021 9:03 PM
> > > To: Edwin chiu <edwinchiu0505tw@gmail.com>
> > > Cc: robh+dt@kernel.org; daniel.lezcano@linaro.org;
> > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > rafael@kernel.org; linux-pm@vger.kernel.org; Edwin Chiu 邱垂峰
> > > <edwin.chiu@sunplus.com>
> > > Subject: Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021
> > > compatible string to sunplus,idle-state.yaml
> > >
> > > On Mon, 08 Nov 2021 15:55:09 +0800, Edwin chiu wrote:
> > > > Add the compatible string for cpuidle state on sp7021
> > > >
> > > > Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>
> > > > ---
> > > >  .../bindings/arm/sunplus/sunplus,idle-state.yaml   | 55 ++++++++++++++++++++++
> > > >  MAINTAINERS                                        |  6 +++
> > > >  2 files changed, 61 insertions(+)  create mode 100644
> > > > Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.y
> > > > am
> > > > l
> > > >
> > >
> > > Running 'make dtbs_check' with the schema in this patch gives the
> > > following warnings. Consider if
> > they are expected or the schema is incorrect. These may not be new warnings.
> > >
> > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > This will change in the future.
> > >
> > > Full log is available here:
> > > https://patchwork.ozlabs.org/patch/1552228
> > >
> > >
> > > spc: compatible:0: 'arm,idle-state' was expected
> > > 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> > >
> > > spc: compatible: Additional items are not allowed ('arm,idle-state' was unexpected)
> > > 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> > >
> > > spc: compatible: ['qcom,idle-state-spc', 'arm,idle-state'] is too long
> > > 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> > > 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> > >

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml
  2021-11-12 22:58       ` Rob Herring
  2021-11-15  9:07         ` Edwin Chiu 邱垂峰
  2021-11-26  5:59         ` Edwin Chiu 邱垂峰
@ 2021-12-03  7:04         ` Edwin Chiu 邱垂峰
  2 siblings, 0 replies; 9+ messages in thread
From: Edwin Chiu 邱垂峰 @ 2021-12-03  7:04 UTC (permalink / raw)
  To: Rob Herring
  Cc: Edwin chiu, daniel.lezcano@linaro.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, rafael@kernel.org,
	linux-pm@vger.kernel.org

Hi Rob :

Are you agree my answer?
Should I send patch again?

邱垂峰 EdwinChiu
智能運算專案
T: +886-3-5786005 ext.2590
edwin.chiu@sunplus.com
300 新竹科學園區創新一路19號


> -----Original Message-----
> From: Edwin Chiu 邱垂峰
> Sent: Friday, November 26, 2021 1:59 PM
> To: 'Rob Herring' <robh@kernel.org>
> Cc: 'Edwin chiu' <edwinchiu0505tw@gmail.com>; 'daniel.lezcano@linaro.org'
> <daniel.lezcano@linaro.org>; 'devicetree@vger.kernel.org' <devicetree@vger.kernel.org>;
> 'linux-kernel@vger.kernel.org' <linux-kernel@vger.kernel.org>; 'rafael@kernel.org' <rafael@kernel.org>;
> 'linux-pm@vger.kernel.org' <linux-pm@vger.kernel.org>
> Subject: RE: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to
> sunplus,idle-state.yaml
> 
> Hi Rob:
> 
> What is the status now?
> Are you agree my submit?
> 
> 邱垂峰 EdwinChiu
> 智能運算專案
> T: +886-3-5786005 ext.2590
> edwin.chiu@sunplus.com
> 300 新竹科學園區創新一路19號
> 
> 
> > -----Original Message-----
> > From: Edwin Chiu 邱垂峰
> > Sent: Monday, November 15, 2021 5:08 PM
> > To: 'Rob Herring' <robh@kernel.org>
> > Cc: Edwin chiu <edwinchiu0505tw@gmail.com>; daniel.lezcano@linaro.org;
> > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > rafael@kernel.org; linux-pm@vger.kernel.org
> > Subject: RE: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible
> > string to sunplus,idle-state.yaml
> >
> > Hi Rob:
> >
> > Thanks your response.
> > Reply your question as below:
> > > > 1) The checkpatch warning is WARNING: From:/Signed-off-by: email
> > > > address mismatch: 'From: Edwin
> > > chiu <edwinchiu0505tw@gmail.com>' != 'Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>'
> > > > ==> I want explain to you that <edwin.chiu@sunplus.com> is my
> > > > email in the company, but it disagree
> > > operate by "git send-email".
> > > >     So I used <edwinchiu0505tw@gmail.com> in my linux system to operate with "git
> send-email".
> > > >    Actually I checkpatch in my side was 0 error 0 warning.
> > >
> > > The email used to send and the author emails are independent in git.
> > > There should be a 'From:' line in the resulting patch when the sender and author don't match.
> > >
> > > Maybe you need to set sendemail.from config option to your corp email.
> > >
> > ==> Please understanding it is our company secure policy.
> >     It disagree operate by "git send-email".
> >    But I am pretty sure I can receive email on both
> > edwin.chiu@sunplus.com and edwinchiu0505tw@gmail.com .
> >
> > > >
> > > > 2) Regarding to dtbs-check issue, your list warnings related to
> > > > others company's yaml file, it not my
> > > yaml file case.
> > > >    What is the purpose you want? Or what should I do?
> > >
> > > You aren't adding anything custom, so why are you even adding the
> > > schema? arm/idle-states.yaml should be enough.
> > >
> > ===> Yes, I want to apply arm/idle-state structure to my idle function.
> >     I thought every function submit, all need edit yaml file together.
> >     Do you mean I can submit cpuidle-sunplus.c without my sunplus,idle-state.yaml ?
> >
> > On the other hand, I confirm my yaml file can pass dt_binding_check and dtbs_check as below:
> > edwinchiu@scdiu3:~/code/code1/linux/kernel$ make dt_binding_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
> >   DTEX    Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dts
> >   DTC     Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dt.yaml
> >   CHECK   Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.example.dt.yaml
> > edwinchiu@scdiu3:~/code/code1/linux/kernel$
> >
> > edwinchiu@scdiu3:~/code/code1/linux/kernel$ export ARCH=arm
> > edwinchiu@scdiu3:~/code/code1/linux/kernel$ echo $ARCH arm
> > edwinchiu@scdiu3:~/code/code1/linux/kernel$ make dtbs_check
> > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
> >   SYNC    include/config/auto.conf.cmd
> >   SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> >   UPD     include/config/kernel.release
> >   DTC     arch/arm/boot/dts/sp7021-bpi-f2p.dtb
> >   DTC     arch/arm/boot/dts/sp7021-bpi-f2s.dtb
> >   DTC     arch/arm/boot/dts/sp7021-demov2.dtb
> >   DTC     arch/arm/boot/dts/sp7021-demov3.dtb
> >   DTC     arch/arm/boot/dts/sp7021-ev.dtb
> >   DTC     arch/arm/boot/dts/sp7021-ev-ttl.dtb
> >   DTC     arch/arm/boot/dts/sp7021-ltpp3g2revD.dtb
> >   DTC     arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dtb
> >   DTC     arch/arm/boot/dts/sp7021-bpi-f2p.dt.yaml
> >   CHECK   arch/arm/boot/dts/sp7021-bpi-f2p.dt.yaml
> >   DTC     arch/arm/boot/dts/sp7021-bpi-f2s.dt.yaml
> >   CHECK   arch/arm/boot/dts/sp7021-bpi-f2s.dt.yaml
> >   DTC     arch/arm/boot/dts/sp7021-demov2.dt.yaml
> >   CHECK   arch/arm/boot/dts/sp7021-demov2.dt.yaml
> >   DTC     arch/arm/boot/dts/sp7021-demov3.dt.yaml
> >   CHECK   arch/arm/boot/dts/sp7021-demov3.dt.yaml
> >   DTC     arch/arm/boot/dts/sp7021-ev.dt.yaml
> >   CHECK   arch/arm/boot/dts/sp7021-ev.dt.yaml
> >   DTC     arch/arm/boot/dts/sp7021-ev-ttl.dt.yaml
> >   CHECK   arch/arm/boot/dts/sp7021-ev-ttl.dt.yaml
> >   DTC     arch/arm/boot/dts/sp7021-ltpp3g2revD.dt.yaml
> >   CHECK   arch/arm/boot/dts/sp7021-ltpp3g2revD.dt.yaml
> >   DTC     arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dt.yaml
> >   CHECK   arch/arm/boot/dts/sp7021-ltpp3g2-sunplus.dt.yaml
> > edwinchiu@scdiu3:~/code/code1/linux/kernel$
> >
> >
> >
> > 邱垂峰 EdwinChiu
> > 智能運算專案
> > T: +886-3-5786005 ext.2590
> > edwin.chiu@sunplus.com
> > 300 新竹科學園區創新一路19號
> >
> >
> > > -----Original Message-----
> > > From: Rob Herring <robh@kernel.org>
> > > Sent: Saturday, November 13, 2021 6:59 AM
> > > To: Edwin Chiu 邱垂峰 <edwin.chiu@sunplus.com>
> > > Cc: Edwin chiu <edwinchiu0505tw@gmail.com>;
> > > daniel.lezcano@linaro.org; devicetree@vger.kernel.org;
> > > linux-kernel@vger.kernel.org; rafael@kernel.org;
> > > linux-pm@vger.kernel.org
> > > Subject: Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021
> > > compatible string to sunplus,idle-state.yaml
> > >
> > > On Tue, Nov 09, 2021 at 06:58:24AM +0000, Edwin Chiu 邱垂峰 wrote:
> > > > Hi Rob:
> > > >
> > > > Look into the full log, it show you check 3 programs
> > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > > Context	Check	Description
> > > > robh/checkpatch	warning	total: 0 errors, 1 warnings, 67 lines checked
> > > > robh/dt-meta-schema	success
> > > > robh/dtbs-check	fail	build log
> > > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > >
> > > > 1) The checkpatch warning is WARNING: From:/Signed-off-by: email
> > > > address mismatch: 'From: Edwin
> > > chiu <edwinchiu0505tw@gmail.com>' != 'Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>'
> > > > ==> I want explain to you that <edwin.chiu@sunplus.com> is my
> > > > email in the company, but it disagree
> > > operate by "git send-email".
> > > >     So I used <edwinchiu0505tw@gmail.com> in my linux system to operate with "git
> send-email".
> > > >    Actually I checkpatch in my side was 0 error 0 warning.
> > >
> > > The email used to send and the author emails are independent in git.
> > > There should be a 'From:' line in the resulting patch when the sender and author don't match.
> > >
> > > Maybe you need to set sendemail.from config option to your corp email.
> > >
> > > >
> > > > 2) Regarding to dtbs-check issue, your list warnings related to
> > > > others company's yaml file, it not my
> > > yaml file case.
> > > >    What is the purpose you want? Or what should I do?
> > >
> > > You aren't adding anything custom, so why are you even adding the
> > > schema? arm/idle-states.yaml should be enough.
> > >
> > > >
> > > > 3) Execute=>make dtbs_check
> > > > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/sunplus/sunp
> > > > lu s, idle-state.yaml There are many config select items…..I don't
> > > > know how to select them.
> > > > (I execute "make config " and "make all" were pass) Can you teach
> > > > me how to do "make dtbs_check"?
> > >
> > > Did you read Documentation/devicetree/bindings/writing-schema.rst?
> > >
> > > To check all dts files (for an arch) and run the validation, do:
> > >
> > > make allmodconfig
> > > make dtbs_check
> > >
> > > Rob
> > >
> > > >
> > > > 邱垂峰 EdwinChiu
> > > > 智能運算專案
> > > > T: +886-3-5786005 ext.2590
> > > > edwin.chiu@sunplus.com
> > > > 300 新竹科學園區創新一路19號
> > > >
> > > > -----Original Message-----
> > > > From: Rob Herring <robh@kernel.org>
> > > > Sent: Monday, November 8, 2021 9:03 PM
> > > > To: Edwin chiu <edwinchiu0505tw@gmail.com>
> > > > Cc: robh+dt@kernel.org; daniel.lezcano@linaro.org;
> > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> > > > rafael@kernel.org; linux-pm@vger.kernel.org; Edwin Chiu 邱垂峰
> > > > <edwin.chiu@sunplus.com>
> > > > Subject: Re: [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021
> > > > compatible string to sunplus,idle-state.yaml
> > > >
> > > > On Mon, 08 Nov 2021 15:55:09 +0800, Edwin chiu wrote:
> > > > > Add the compatible string for cpuidle state on sp7021
> > > > >
> > > > > Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>
> > > > > ---
> > > > >  .../bindings/arm/sunplus/sunplus,idle-state.yaml   | 55 ++++++++++++++++++++++
> > > > >  MAINTAINERS                                        |  6 +++
> > > > >  2 files changed, 61 insertions(+)  create mode 100644
> > > > > Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state
> > > > > .y
> > > > > am
> > > > > l
> > > > >
> > > >
> > > > Running 'make dtbs_check' with the schema in this patch gives the
> > > > following warnings. Consider if
> > > they are expected or the schema is incorrect. These may not be new warnings.
> > > >
> > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > > > This will change in the future.
> > > >
> > > > Full log is available here:
> > > > https://patchwork.ozlabs.org/patch/1552228
> > > >
> > > >
> > > > spc: compatible:0: 'arm,idle-state' was expected
> > > > 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> > > >
> > > > spc: compatible: Additional items are not allowed ('arm,idle-state' was unexpected)
> > > > 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> > > >
> > > > spc: compatible: ['qcom,idle-state-spc', 'arm,idle-state'] is too long
> > > > 	arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8064-cm-qs600.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8064-ifc6410.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8064-sony-xperia-yuga.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8074-dragonboard.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8084-ifc6540.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-apq8084-mtp.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-fairphone-fp2.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-samsung-klte.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-amami.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-castor.dt.yaml
> > > > 	arch/arm/boot/dts/qcom-msm8974-sony-xperia-honami.dt.yaml
> > > >

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH 2/2] cpuidle:sunplus:create cpuidle driver for sunplus sp7021
  2021-11-08  7:55 [PATCH 0/2] Add cpuidle driver for Sunplus SP7021 Edwin chiu
  2021-11-08  7:55 ` [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml Edwin chiu
@ 2021-11-08  7:55 ` Edwin chiu
  1 sibling, 0 replies; 9+ messages in thread
From: Edwin chiu @ 2021-11-08  7:55 UTC (permalink / raw)
  To: robh+dt, devicetree, linux-kernel, rafael, daniel.lezcano,
	linux-pm
  Cc: Edwin chiu

Create cpuidle driver for sunplus sp7021 chip

Signed-off-by: Edwin chiu <edwin.chiu@sunplus.com>
---
 MAINTAINERS                                   |   5 +-
 drivers/cpuidle/Kconfig.arm                   |   7 +
 drivers/cpuidle/Makefile                      |   1 +
 drivers/cpuidle/cpuidle-sunplus.c             | 185 ++++++++++++++++++++++++++
 include/linux/platform_data/cpuidle-sunplus.h |  14 ++
 5 files changed, 211 insertions(+), 1 deletion(-)
 create mode 100644 drivers/cpuidle/cpuidle-sunplus.c
 create mode 100644 include/linux/platform_data/cpuidle-sunplus.h

diff --git a/MAINTAINERS b/MAINTAINERS
index 52f17ec..050fe3b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -17949,7 +17949,10 @@ SUNPLUS CPUIDLE DRIVER
 M:	Edwin Chiu <edwin.chiu@sunplus.com>
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/sunplus/sunplus,idle-state.yaml
-
+F:	drivers/cpuidle/Kconfig.arm
+F:	drivers/cpuidle/Makefile
+F:	drivers/cpuidle/cpuidle-sunplus.c
+F:	include/linux/platform_data/cpuidle-sunplus.h
 
 SUPERH
 M:	Yoshinori Sato <ysato@users.sourceforge.jp>
diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
index 334f83e..ad9956c 100644
--- a/drivers/cpuidle/Kconfig.arm
+++ b/drivers/cpuidle/Kconfig.arm
@@ -117,3 +117,10 @@ config ARM_QCOM_SPM_CPUIDLE
 	  The Subsystem Power Manager (SPM) controls low power modes for the
 	  CPU and L2 cores. It interface with various system drivers to put
 	  the cores in low power modes.
+
+config ARM_SUNPLUS_CPUIDLE
+	bool "CPU Idle Driver For SUNPLUS SoCs"
+	depends on !ARM64
+	select DT_IDLE_STATES
+	help
+	  Select this to enable cpuidle on SP7021 processors.
diff --git a/drivers/cpuidle/Makefile b/drivers/cpuidle/Makefile
index 26bbc5e..0a020d1 100644
--- a/drivers/cpuidle/Makefile
+++ b/drivers/cpuidle/Makefile
@@ -25,6 +25,7 @@ obj-$(CONFIG_ARM_PSCI_CPUIDLE)		+= cpuidle-psci.o
 obj-$(CONFIG_ARM_PSCI_CPUIDLE_DOMAIN)	+= cpuidle-psci-domain.o
 obj-$(CONFIG_ARM_TEGRA_CPUIDLE)		+= cpuidle-tegra.o
 obj-$(CONFIG_ARM_QCOM_SPM_CPUIDLE)	+= cpuidle-qcom-spm.o
+obj-$(CONFIG_ARM_SUNPLUS_CPUIDLE)		+= cpuidle-sunplus.o
 
 ###############################################################################
 # MIPS drivers
diff --git a/drivers/cpuidle/cpuidle-sunplus.c b/drivers/cpuidle/cpuidle-sunplus.c
new file mode 100644
index 0000000..4a7a0c0
--- /dev/null
+++ b/drivers/cpuidle/cpuidle-sunplus.c
@@ -0,0 +1,185 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * ARM/ARM64 generic CPU idle driver.
+ *
+ * Copyright (C) 2014 ARM Ltd.
+ * Author: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
+ */
+#define pr_fmt(fmt) "CPUidle arm: " fmt
+
+#include <linux/cpu_cooling.h>
+#include <linux/cpuidle.h>
+#include <linux/cpumask.h>
+#include <linux/cpu_pm.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/slab.h>
+#include <linux/platform_data/cpuidle-sunplus.h>
+
+#include <asm/cpuidle.h>
+#include <asm/suspend.h>
+
+#include "dt_idle_states.h"
+
+static int sp7021_wfi_finisher(unsigned long flags)
+{
+	cpu_v7_do_idle();   // idle to WFI
+
+	return -1;
+}
+
+static int sp7021_enter_idle_state(struct cpuidle_device *dev,
+				struct cpuidle_driver *drv, int idx)
+{
+	int ret;
+
+  // if idx=0, call cpu_do_idle()
+	if (!idx) {
+		cpu_v7_do_idle();
+		return idx;
+	}
+
+	// if idx>0, call cpu_suspend()
+	ret = cpu_pm_enter();
+	if (!ret) {
+	/*
+	 * Pass idle state index to cpuidle_suspend which in turn
+	 * will call the CPU ops suspend protocol with idle index as a
+	 * parameter.
+	 */
+		ret = cpu_suspend(idx, sp7021_wfi_finisher);
+	  //cpu_pm_exit();
+	}
+	cpu_pm_exit();
+
+	return ret ? -1:idx;
+}
+
+static struct cpuidle_driver sp7021_idle_driver __initdata = {
+	.name = "sp7021_idle",
+	.owner = THIS_MODULE,
+	/*
+	 * State at index 0 is standby wfi and considered standard
+	 * on all ARM platforms. If in some platforms simple wfi
+	 * can't be used as "state 0", DT bindings must be implemented
+	 * to work around this issue and allow installing a special
+	 * handler for idle state index 0.
+	 */
+	.states[0] = {
+		.enter                  = sp7021_enter_idle_state,
+		.exit_latency           = 1,
+		.target_residency       = 1,
+		.power_usage		= UINT_MAX,
+		.name                   = "WFI",
+		.desc                   = "ARM WFI",
+	}
+};
+
+static const struct of_device_id sp7021_idle_state_match[] __initconst = {
+	{ .compatible = "arm,idle-state",
+		.data = sp7021_enter_idle_state },
+	{ },
+};
+
+/*
+ * arm_idle_init - Initializes arm cpuidle driver
+ *
+ * Initializes arm cpuidle driver for all CPUs, if any CPU fails
+ * to register cpuidle driver then rollback to cancel all CPUs
+ * registration.
+ */
+static int __init sp7021_idle_init(void)
+{
+	int cpu, ret;
+	struct cpuidle_driver *drv;
+	struct cpuidle_device *dev;
+
+	drv = kmemdup(&sp7021_idle_driver, sizeof(*drv), GFP_KERNEL);
+	if (!drv)
+		return -ENOMEM;
+
+	drv->cpumask = (struct cpumask *)cpumask_of(cpu);
+	/*
+	 * Initialize idle states data, starting at index 1.  This
+	 * driver is DT only, if no DT idle states are detected (ret
+	 * == 0) let the driver initialization fail accordingly since
+	 * there is no reason to initialize the idle driver if only
+	 * wfi is supported.
+	 */
+	ret = dt_init_idle_driver(drv, sp7021_idle_state_match, 1);
+	if (ret <= 0)
+		return ret ? : -ENODEV;
+
+	ret = cpuidle_register_driver(drv);
+	if (ret) {
+		pr_err("Failed to register cpuidle driver\n");
+		return ret;
+	}
+
+	/*
+	 * Call arch CPU operations in order to initialize
+	 * idle states suspend back-end specific data
+	 */
+	for_each_possible_cpu(cpu) {
+		/*
+		 * Skip the cpuidle device initialization if the reported
+		 * failure is a HW misconfiguration/breakage (-ENXIO)
+		 */
+		if (ret == -ENXIO)
+			continue;
+
+		if (ret) {
+			pr_err("CPU %d failed to init idle CPU ops\n", cpu);
+			goto out_fail;
+		}
+		dev = kzalloc(sizeof(*dev), GFP_KERNEL);
+		if (!dev) {
+			ret = -ENOMEM;
+			goto out_fail;
+		}
+		dev->cpu = cpu;
+
+		ret = cpuidle_register_device(dev);
+		if (ret) {
+			pr_err("Failed to register cpuidle device for CPU %d\n", cpu);
+			kfree(dev);
+			goto out_fail;
+		}
+	}
+
+	return 0;
+
+out_fail:
+	while (--cpu >= 0) {
+		dev = per_cpu(cpuidle_devices, cpu);
+		cpuidle_unregister_device(dev);
+		kfree(dev);
+	}
+	cpuidle_unregister_driver(drv);
+
+	return ret;
+}
+static int __init idle_init(void)
+{
+	int ret;
+
+	if (of_machine_is_compatible("sunplus,sp7021-achip")) {
+		sp7021_idle_init();
+		ret = 0;
+	}	else
+		ret = -1;
+
+	if (ret) {
+		pr_err("failed to cpuidle init\n");
+		return ret;
+	}
+
+	return ret;
+}
+
+device_initcall(idle_init);
+
+MODULE_AUTHOR("Edwin Chiu <edwin.chiu@sunplus.com>");
+MODULE_DESCRIPTION("Sunplus sp7021 cpuidle driver");
+MODULE_LICENSE("GPL");
diff --git a/include/linux/platform_data/cpuidle-sunplus.h b/include/linux/platform_data/cpuidle-sunplus.h
new file mode 100644
index 0000000..43e6001
--- /dev/null
+++ b/include/linux/platform_data/cpuidle-sunplus.h
@@ -0,0 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#ifndef __CPUIDLE_SP7021_H
+#define __CPUIDLE_SP7021_H
+
+
+extern int cpu_v7_do_idle(void);
+
+#endif
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-12-03  7:04 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-08  7:55 [PATCH 0/2] Add cpuidle driver for Sunplus SP7021 Edwin chiu
2021-11-08  7:55 ` [PATCH 1/2] dt-bingings:arm:sunplus:add sp7021 compatible string to sunplus,idle-state.yaml Edwin chiu
2021-11-08 13:03   ` Rob Herring
2021-11-09  6:58     ` Edwin Chiu 邱垂峰
2021-11-12 22:58       ` Rob Herring
2021-11-15  9:07         ` Edwin Chiu 邱垂峰
2021-11-26  5:59         ` Edwin Chiu 邱垂峰
2021-12-03  7:04         ` Edwin Chiu 邱垂峰
2021-11-08  7:55 ` [PATCH 2/2] cpuidle:sunplus:create cpuidle driver for sunplus sp7021 Edwin chiu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).