* [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus
@ 2021-10-26 16:32 David Heidelberg
2021-10-26 16:47 ` Alex Elder
2021-11-01 18:49 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: David Heidelberg @ 2021-10-26 16:32 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, David S. Miller, Jakub Kicinski,
Rob Herring, Alex Elder
Cc: ~okias/devicetree, David Heidelberg, linux-arm-msm, netdev,
devicetree, linux-kernel
Fix warnings as:
arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml: ipa@1e40000: iommus: [[21, 1504, 0], [21, 1506, 0]] is too long
From schema: Documentation/devicetree/bindings/net/qcom,ipa.yaml
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Documentation/devicetree/bindings/net/qcom,ipa.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index b8a0b392b24e..b86edf67ce62 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -64,7 +64,8 @@ properties:
- const: gsi
iommus:
- maxItems: 1
+ minItems: 1
+ maxItems: 2
clocks:
maxItems: 1
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus
2021-10-26 16:32 [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus David Heidelberg
@ 2021-10-26 16:47 ` Alex Elder
2021-10-26 17:02 ` David Heidelberg
2021-11-01 18:49 ` Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: Alex Elder @ 2021-10-26 16:47 UTC (permalink / raw)
To: David Heidelberg, Andy Gross, Bjorn Andersson, David S. Miller,
Jakub Kicinski, Rob Herring, Alex Elder
Cc: ~okias/devicetree, linux-arm-msm, netdev, devicetree,
linux-kernel
On 10/26/21 11:32 AM, David Heidelberg wrote:
> Fix warnings as:
> arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml: ipa@1e40000: iommus: [[21, 1504, 0], [21, 1506, 0]] is too long
> From schema: Documentation/devicetree/bindings/net/qcom,ipa.yaml
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Looks good to me. I'm not sure why the minItems is required,
unless it's to indicate that it must be at least 1 and can't
be missing. But iommus is also stated to be required elsewhere
in the binding.
In the future, it's helpful to indicate the command you
used to produce the warning in your commit message. And
furthermore, describing the problem (and not just including
the error message) is even more helpful.
Reviewed-by: Alex Elder <elder@linaro.org>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index b8a0b392b24e..b86edf67ce62 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -64,7 +64,8 @@ properties:
> - const: gsi
>
> iommus:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> clocks:
> maxItems: 1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus
2021-10-26 16:47 ` Alex Elder
@ 2021-10-26 17:02 ` David Heidelberg
0 siblings, 0 replies; 4+ messages in thread
From: David Heidelberg @ 2021-10-26 17:02 UTC (permalink / raw)
To: Alex Elder
Cc: Andy Gross, Bjorn Andersson, David S. Miller, Jakub Kicinski,
Rob Herring, Alex Elder, ~okias/devicetree, linux-arm-msm, netdev,
devicetree, linux-kernel
thanks, I'll try to work on my commit messages :)
David
On Tue, Oct 26 2021 at 11:47:46 -0500, Alex Elder <elder@ieee.org>
wrote:
> On 10/26/21 11:32 AM, David Heidelberg wrote:
>> Fix warnings as:
>> arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml: ipa@1e40000: iommus: [[21,
>> 1504, 0], [21, 1506, 0]] is too long
>> From schema: Documentation/devicetree/bindings/net/qcom,ipa.yaml
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>
> Looks good to me. I'm not sure why the minItems is required,
> unless it's to indicate that it must be at least 1 and can't
> be missing. But iommus is also stated to be required elsewhere
> in the binding.
>
> In the future, it's helpful to indicate the command you
> used to produce the warning in your commit message. And
> furthermore, describing the problem (and not just including
> the error message) is even more helpful.
>
> Reviewed-by: Alex Elder <elder@linaro.org>
>
>> ---
>> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> index b8a0b392b24e..b86edf67ce62 100644
>> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> @@ -64,7 +64,8 @@ properties:
>> - const: gsi
>> \x7f iommus:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 2
>> \x7f clocks:
>> maxItems: 1
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus
2021-10-26 16:32 [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus David Heidelberg
2021-10-26 16:47 ` Alex Elder
@ 2021-11-01 18:49 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-11-01 18:49 UTC (permalink / raw)
To: David Heidelberg
Cc: Jakub Kicinski, netdev, Bjorn Andersson, Andy Gross, Rob Herring,
David S. Miller, Alex Elder, linux-arm-msm, ~okias/devicetree,
devicetree, linux-kernel
On Tue, 26 Oct 2021 18:32:40 +0200, David Heidelberg wrote:
> Fix warnings as:
> arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml: ipa@1e40000: iommus: [[21, 1504, 0], [21, 1506, 0]] is too long
> From schema: Documentation/devicetree/bindings/net/qcom,ipa.yaml
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Documentation/devicetree/bindings/net/qcom,ipa.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-01 18:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-26 16:32 [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two iommus David Heidelberg
2021-10-26 16:47 ` Alex Elder
2021-10-26 17:02 ` David Heidelberg
2021-11-01 18:49 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).