From: Rob Herring <robh@kernel.org>
To: Robert Foss <robert.foss@linaro.org>
Cc: todor.too@gmail.com, agross@kernel.org,
bjorn.andersson@linaro.org, mchehab@kernel.org,
angelogioacchino.delregno@somainline.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Andrey Konovalov <andrey.konovalov@linaro.org>
Subject: Re: [PATCH v1 2/2] media: dt-bindings: media: camss: Document clock-lanes property
Date: Mon, 1 Nov 2021 15:30:21 -0500 [thread overview]
Message-ID: <YYBOXQOXM8USks0G@robh.at.kernel.org> (raw)
In-Reply-To: <20211025103322.160913-2-robert.foss@linaro.org>
On Mon, Oct 25, 2021 at 12:33:22PM +0200, Robert Foss wrote:
> The clock-lanes property corresponds to a hardware register field
> that is required to be set, in order to enable the CSI clock signal.
>
> The physical lane of the clock signal is not programmable, but only
> togglable On or Off, which what BIT(7) of the
> CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(5) register controls.
>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
> ---
> .../devicetree/bindings/media/qcom,msm8996-camss.yaml | 5 +++++
> .../devicetree/bindings/media/qcom,sdm660-camss.yaml | 5 +++++
> .../devicetree/bindings/media/qcom,sdm845-camss.yaml | 5 +++++
> 3 files changed, 15 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> index 38be41e932f0..d4da1fad12cf 100644
> --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> @@ -106,6 +106,11 @@ properties:
>
> properties:
> clock-lanes:
> + description:
> + The index of the clock-lane is not programmable by
> + the hardware, but is required to define a CSI port.
> + Lane 7 reflects the hardware register field that enables
> + the clock lane.
If it is fixed, then it should not be required. Fix the required part.
> items:
> - const: 7
I don't know how we let that in, but this should be the lane number.
Each binding can't be making up its own interpretation.
Rob
next prev parent reply other threads:[~2021-11-01 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 10:33 [PATCH v1 1/2] media: dt-bindings: media: camss: sdm845: Make clock-lanes property const Robert Foss
2021-10-25 10:33 ` [PATCH v1 2/2] media: dt-bindings: media: camss: Document clock-lanes property Robert Foss
2021-11-01 20:30 ` Rob Herring [this message]
2021-11-02 11:49 ` Robert Foss
2021-11-02 14:18 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYBOXQOXM8USks0G@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andrey.konovalov@linaro.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robert.foss@linaro.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).