* [PATCH v2] dt-bindings: usb: dwc2: document the port when usb-role-switch is used
@ 2021-10-27 12:12 Fabrice Gasnier
2021-11-01 21:32 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Gasnier @ 2021-10-27 12:12 UTC (permalink / raw)
To: hminas, gregkh, robh+dt
Cc: linux-usb, linux-kernel, linux-stm32, devicetree, amelie.delaunay,
fabrice.gasnier, alexandre.torgue
Document the "port" property, which is used with "usb-role-switch"
to describe the bus connector.
Definition is inspired from mediatek,mtu3.yaml.
This fixes some errors seen when running "make dtbs_check":
... 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: ... Documentation/devicetree/bindings/usb/dwc2.yaml
Note: add dependencies so that 'usb-role-switch' without port is valid or
both must be present.
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
Changes in v2:
Rob's review comments:
- drop reference to graph.txt
- drop unneeded quotes
---
Documentation/devicetree/bindings/usb/dwc2.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/usb/dwc2.yaml b/Documentation/devicetree/bindings/usb/dwc2.yaml
index 10c7d9b..a351f3c 100644
--- a/Documentation/devicetree/bindings/usb/dwc2.yaml
+++ b/Documentation/devicetree/bindings/usb/dwc2.yaml
@@ -130,6 +130,16 @@ properties:
description: If present indicates that we need to reset the PHY when we
detect a wakeup. This is due to a hardware errata.
+ port:
+ description:
+ Any connector to the data bus of this controller should be modelled
+ using the OF graph bindings specified, if the "usb-role-switch"
+ property is used.
+ $ref: /schemas/graph.yaml#/properties/port
+
+dependencies:
+ port: [ usb-role-switch ]
+
required:
- compatible
- reg
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dt-bindings: usb: dwc2: document the port when usb-role-switch is used
2021-10-27 12:12 [PATCH v2] dt-bindings: usb: dwc2: document the port when usb-role-switch is used Fabrice Gasnier
@ 2021-11-01 21:32 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2021-11-01 21:32 UTC (permalink / raw)
To: Fabrice Gasnier
Cc: amelie.delaunay, linux-stm32, devicetree, linux-kernel,
alexandre.torgue, gregkh, robh+dt, linux-usb, hminas
On Wed, 27 Oct 2021 14:12:32 +0200, Fabrice Gasnier wrote:
> Document the "port" property, which is used with "usb-role-switch"
> to describe the bus connector.
> Definition is inspired from mediatek,mtu3.yaml.
>
> This fixes some errors seen when running "make dtbs_check":
> ... 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: ... Documentation/devicetree/bindings/usb/dwc2.yaml
>
> Note: add dependencies so that 'usb-role-switch' without port is valid or
> both must be present.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> ---
> Changes in v2:
> Rob's review comments:
> - drop reference to graph.txt
> - drop unneeded quotes
> ---
> Documentation/devicetree/bindings/usb/dwc2.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-01 21:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-27 12:12 [PATCH v2] dt-bindings: usb: dwc2: document the port when usb-role-switch is used Fabrice Gasnier
2021-11-01 21:32 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).