From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Fenglin Wu <quic_fenglinw@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
sboyd@kernel.org, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, collinsd@codeaurora.org,
subbaram@codeaurora.org
Subject: Re: [PATCH v1] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format
Date: Wed, 3 Nov 2021 15:20:24 -0700 [thread overview]
Message-ID: <YYMLKCspjdyaKWUK@ripper> (raw)
In-Reply-To: <1635836275-8873-1-git-send-email-quic_fenglinw@quicinc.com>
On Mon 01 Nov 23:57 PDT 2021, Fenglin Wu wrote:
[..]
> diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> new file mode 100644
> index 0000000..05bb114
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> @@ -0,0 +1,122 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/spmi/qcom,spmi-pmic-arb.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SPMI PMIC Arbiter
> +
> +maintainers:
> + - Fenglin Wu <quic_fenglinw@quicinc.com>
> +
> +description: |
> + The SPMI PMIC Arbiter is found on Snapdragon chipsets. It is an SPMI
> + controller with wrapping arbitration logic to allow for multiple
> + on-chip devices to control a single SPMI master.
> +
> + The PMIC Arbiter can also act as an interrupt controller, providing
> + interrupts to slave devices.
> +
> + See Documentation/devicetree/bindings/spmi/spmi.yaml for the generic
> + SPMI controller binding requirements for child nodes.
> +
> +properties:
> + $nodename:
> + pattern: "^qcom,spmi@.*"
Node names should never contain "qcom,". Seems the agreed upon node
named should be "spmi@.*".
The rest looks like a reasonable conversion to me.
[..]
> +examples:
> + - |
> + qcom,spmi@fc4cf000 {
Regards,
Bjorn
next prev parent reply other threads:[~2021-11-03 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 6:57 [PATCH v1] dt-bindings: convert qcom,spmi-pmic-arb binding to YAML format Fenglin Wu
2021-11-03 22:20 ` Bjorn Andersson [this message]
2021-11-04 1:54 ` Fenglin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYMLKCspjdyaKWUK@ripper \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_fenglinw@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=subbaram@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).