Re: [RFC PATCH 3/6] leds: add function to configure offload leds

Randy Dunlap
2021-11-07T22:45:56Z

On 11/7/21 9:57 AM, Ansuel Smith wrote:
> diff --git a/Documentation/leds/leds-class.rst b/Documentation/leds/leds-class.rst
> index ab50b58d6a21..af84cce09068 100644
> --- a/Documentation/leds/leds-class.rst
> +++ b/Documentation/leds/leds-class.rst
> @@ -191,6 +191,18 @@ If the second argument (enable) to the trigger_offload() method is false, any
> active HW offloading must be deactivated. In this case errors are not permitted
> in the trigger_offload() method.
>
> +The offload trigger will use the function configure_offload() provided by the driver
> +that will configure the offloaded mode for the LED.
> +This function pass as the first argument (offload_flags) a u32 flag, it's in the LED

passes flag. It's

> +driver interest how to elaborate this flags and to declare support for a particular

flag
although that sentence is not very clear.

> +offload trigger.
> +The second argument (cmd) of the configure_offload() method can be used to do various
> +operation for the specific trigger. We currently support ENABLE, DISABLE and READ to

operations

> +enable, disable and read the state of the offload trigger for the LED driver.
> +If the driver return -ENOTSUPP on configure_offload, the trigger activation will

returns

> +fail as the driver doesn't support that specific offload trigger or don't know

doesn't know

> +how to handle the provided flags.

--
~Randy