From: Matthias Kaehlcke <mka@chromium.org>
To: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Add WCN6750 WiFi node
Date: Wed, 24 Nov 2021 09:57:29 -0800 [thread overview]
Message-ID: <YZ59CYVwrMtb7ser@google.com> (raw)
In-Reply-To: <1637732438-17016-1-git-send-email-quic_mpubbise@quicinc.com>
On Wed, Nov 24, 2021 at 11:10:38AM +0530, Manikanta Pubbisetty wrote:
> Adding DTS node for WCN6750 WiFi chipset.
>
> Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@quicinc.com>
> ---
> Depends on:
> - https://patchwork.kernel.org/project/linux-arm-msm/patch/1637299488-22336-1-git-send-email-pillair@codeaurora.org/
> - https://patchwork.kernel.org/project/linux-wireless/patch/1637693434-15462-20-git-send-email-quic_mpubbise@quicinc.com/
>
> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 7 +++++
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 47 ++++++++++++++++++++++++++++++++
> 2 files changed, 54 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index d623d71..ee152b9 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -598,3 +598,10 @@
> bias-pull-up;
> };
> };
> +
> +&wifi {
> + status = "okay";
> + wifi-firmware {
> + iommus = <&apps_smmu 0x1C02 0x1>;
nit: the convention in this file seems to be to use lowercase characters
in hex numbers
> + };
> +};
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 1969e8dfb..eb7106f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -83,6 +83,11 @@
> #size-cells = <2>;
> ranges;
>
> + wlan_ce_mem: memory@4cd000 {
> + no-map;
> + reg = <0x0 0x4cd000 0x0 0x1000>;
> + };
> +
> hyp_mem: memory@80000000 {
> reg = <0x0 0x80000000 0x0 0x600000>;
> no-map;
> @@ -1579,6 +1584,48 @@
> qcom,bcm-voters = <&apps_bcm_voter>;
> };
>
> + wifi: wifi@17a10040 {
> + compatible = "qcom,wcn6750-wifi";
> + reg = <0 0x17A10040 0 0x0>;
ditto
> + reg-names = "msi_addr";
> + iommus = <&apps_smmu 0x1C00 0x1>;
ditto
next prev parent reply other threads:[~2021-11-24 17:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 5:40 [PATCH] arm64: dts: qcom: sc7280: Add WCN6750 WiFi node Manikanta Pubbisetty
2021-11-24 17:57 ` Matthias Kaehlcke [this message]
2021-11-25 10:20 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ59CYVwrMtb7ser@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_mpubbise@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).