From: "Gabriel L. Somlo" <gsomlo@gmail.com>
To: Stafford Horne <shorne@gmail.com>
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, ulf.hansson@linaro.org,
linux-mmc@vger.kernel.org, kgugala@antmicro.com,
mholenko@antmicro.com, krakoczy@antmicro.com,
mdudek@internships.antmicro.com, paulus@ozlabs.org,
joel@jms.id.au, geert@linux-m68k.org,
david.abdurachmanov@sifive.com, florent@enjoy-digital.fr
Subject: Re: [PATCH v1 3/3] mmc: Add driver for LiteX's LiteSDCard interface
Date: Sun, 5 Dec 2021 17:55:49 -0500 [thread overview]
Message-ID: <Ya1Ddbe6+Ch2ZeFL@errol.ini.cmu.edu> (raw)
In-Reply-To: <Ya0xmCTrp7BJmiBs@antec>
On Mon, Dec 06, 2021 at 06:39:36AM +0900, Stafford Horne wrote:
> On Fri, Dec 03, 2021 at 06:41:55PM -0500, Gabriel Somlo wrote:
> > LiteX (https://github.com/enjoy-digital/litex) is a SoC framework
> > that targets FPGAs. LiteSDCard is a small footprint, configurable
> > SDCard core commonly used in LiteX designs.
> >
> > The driver was first written in May 2020 and has been maintained
> > cooperatively by the LiteX community. Thanks to all contributors!
> >
> > Co-developed-by: Kamil Rakoczy <krakoczy@antmicro.com>
> > Signed-off-by: Kamil Rakoczy <krakoczy@antmicro.com>
> > Co-developed-by: Maciej Dudek <mdudek@internships.antmicro.com>
> > Signed-off-by: Maciej Dudek <mdudek@internships.antmicro.com>
> > Co-developed-by: Paul Mackerras <paulus@ozlabs.org>
> > Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
> > Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
> > Cc: Mateusz Holenko <mholenko@antmicro.com>
> > Cc: Karol Gugala <kgugala@antmicro.com>
> > Cc: Joel Stanley <joel@jms.id.au>
> > Cc: Stafford Horne <shorne@gmail.com>
> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: David Abdurachmanov <david.abdurachmanov@sifive.com>
> > Cc: Florent Kermarrec <florent@enjoy-digital.fr>
> > ---
> > drivers/mmc/host/Kconfig | 6 +
> > drivers/mmc/host/Makefile | 1 +
> > drivers/mmc/host/litex_mmc.c | 677 +++++++++++++++++++++++++++++++++++
> > 3 files changed, 684 insertions(+)
> > create mode 100644 drivers/mmc/host/litex_mmc.c
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index 5af8494c31b5..84c64e72195d 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -1093,3 +1093,9 @@ config MMC_OWL
> >
> > config MMC_SDHCI_EXTERNAL_DMA
> > bool
> > +
> > +config MMC_LITEX
> > + tristate "Support for the MMC Controller in LiteX SOCs"
> > + depends on OF && LITEX
> > + help
> > + Generic MCC driver for LiteX
>
> I just noticed this while configuring the kernel. This doesn't really follow
> the pattern of other drivers, we should think of putting "Litex" near the
> beginning of the line. It makes it easier to spot in menuconfig.
>
> For example:
>
> LiteX MMC Controller support
>
> This selects support for the MMC Host Controller found in LiteX SOCs.
>
> It unsure, say N.
Done, and also lined up for v3. Thanks!
--Gabriel
next prev parent reply other threads:[~2021-12-05 22:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 23:41 [PATCH v1 0/3] mmc: Add LiteSDCard mmc driver Gabriel Somlo
2021-12-03 23:41 ` [PATCH v1 1/3] MAINTAINERS: co-maintain LiteX platform Gabriel Somlo
2021-12-03 23:41 ` [PATCH v1 2/3] dt-bindings: mmc: Add bindings for LiteSDCard Gabriel Somlo
2021-12-06 9:38 ` Geert Uytterhoeven
2021-12-06 12:35 ` Gabriel L. Somlo
2021-12-03 23:41 ` [PATCH v1 3/3] mmc: Add driver for LiteX's LiteSDCard interface Gabriel Somlo
2021-12-04 0:20 ` Randy Dunlap
2021-12-04 0:33 ` Gabriel L. Somlo
2021-12-04 4:41 ` kernel test robot
2021-12-04 7:29 ` Stafford Horne
2021-12-05 21:39 ` Stafford Horne
2021-12-05 22:55 ` Gabriel L. Somlo [this message]
2021-12-06 10:53 ` Joel Stanley
2021-12-06 12:16 ` Geert Uytterhoeven
2021-12-06 23:51 ` Joel Stanley
2021-12-07 0:53 ` Gabriel L. Somlo
2021-12-07 8:01 ` Geert Uytterhoeven
2021-12-07 1:23 ` Gabriel L. Somlo
2021-12-07 2:46 ` Joel Stanley
2021-12-07 18:51 ` Gabriel L. Somlo
2021-12-08 16:46 ` Gabriel L. Somlo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya1Ddbe6+Ch2ZeFL@errol.ini.cmu.edu \
--to=gsomlo@gmail.com \
--cc=david.abdurachmanov@sifive.com \
--cc=devicetree@vger.kernel.org \
--cc=florent@enjoy-digital.fr \
--cc=geert@linux-m68k.org \
--cc=joel@jms.id.au \
--cc=kgugala@antmicro.com \
--cc=krakoczy@antmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mdudek@internships.antmicro.com \
--cc=mholenko@antmicro.com \
--cc=paulus@ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=shorne@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).